[INFO] cloning repository https://github.com/Jos635/cz2020-usbtool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jos635/cz2020-usbtool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJos635%2Fcz2020-usbtool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJos635%2Fcz2020-usbtool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ec80516989d4e0c53e5de536848d6103695d3376 [INFO] checking Jos635/cz2020-usbtool/ec80516989d4e0c53e5de536848d6103695d3376 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJos635%2Fcz2020-usbtool" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Jos635/cz2020-usbtool on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Jos635/cz2020-usbtool [INFO] finished tweaking git repo https://github.com/Jos635/cz2020-usbtool [INFO] tweaked toml for git repo https://github.com/Jos635/cz2020-usbtool written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Jos635/cz2020-usbtool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae13b1658bb292bc66e1abbeb94f948077187b004d9eaf9730dd8aaa2d6e50fd [INFO] running `Command { std: "docker" "start" "-a" "ae13b1658bb292bc66e1abbeb94f948077187b004d9eaf9730dd8aaa2d6e50fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae13b1658bb292bc66e1abbeb94f948077187b004d9eaf9730dd8aaa2d6e50fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae13b1658bb292bc66e1abbeb94f948077187b004d9eaf9730dd8aaa2d6e50fd", kill_on_drop: false }` [INFO] [stdout] ae13b1658bb292bc66e1abbeb94f948077187b004d9eaf9730dd8aaa2d6e50fd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b45ca975a3df1a2f828d96c2f7590d44bd1daa5d31e5e16904da79cc920d0876 [INFO] running `Command { std: "docker" "start" "-a" "b45ca975a3df1a2f828d96c2f7590d44bd1daa5d31e5e16904da79cc920d0876", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling syn v1.0.36 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling rle-decode-fast v1.0.1 [INFO] [stderr] Compiling adler32 v1.2.0 [INFO] [stderr] Compiling take_mut v0.2.2 [INFO] [stderr] Compiling cc v1.0.58 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling libflate v0.1.27 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling fuse v0.3.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.3 [INFO] [stderr] Compiling proc-macro-error v1.0.3 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Checking pin-project-lite v0.1.7 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking crossbeam-channel v0.4.3 [INFO] [stderr] Compiling filetime v0.2.11 [INFO] [stderr] Compiling xattr v0.2.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking slice-deque v0.2.4 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking termios v0.3.2 [INFO] [stderr] Compiling tar v0.4.29 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Compiling libusb1-sys v0.3.7 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking rusb v0.6.2 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Compiling structopt-derive v0.4.8 [INFO] [stderr] Checking tokio v0.2.22 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking structopt v0.3.15 [INFO] [stderr] Checking cz2020-usbtool v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | fn str_to_null_terminated_buf>(s: S) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | / CString::new(s.as_ref()) [INFO] [stdout] 50 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:143:19 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn new(device: Device) -> Badge { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | data: Mutex::new(BadgeData { [INFO] [stdout] | ___________________^ [INFO] [stdout] 144 | | wakers: HashMap::new(), [INFO] [stdout] 145 | | last_message_id: 0, [INFO] [stdout] 146 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 172 | let mut data = self.data.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let request_data = Arc::new(Mutex::new(BadgeRequestData { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(BadgeRequest { data: request_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn dir>(path: P, ino: u64) -> Ino { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | data: InoData::Directory { children: None }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:350:17 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn new(badge: Arc, io: &'a Stream) -> AppFS<'a> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let flash = Arc::new(RefCell::new(Ino { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let sdcard = Arc::new(RefCell::new(Ino { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let serial = Arc::new(RefCell::new(Ino { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | let run = Arc::new(RefCell::new(Ino { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | rt: Arc::new(RefCell::new(Runtime::new().unwrap())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:373:37 [INFO] [stdout] | [INFO] [stdout] 373 | .filter(|n| n.borrow().name.as_str() == name) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:550:56 [INFO] [stdout] | [INFO] [stdout] 550 | ... children.retain(|item| item.borrow().path != path); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:590:56 [INFO] [stdout] | [INFO] [stdout] 590 | ... children.retain(|item| item.borrow().path != path); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:645:56 [INFO] [stdout] | [INFO] [stdout] 645 | ... .filter(|item| item.borrow().path == from_path) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:654:61 [INFO] [stdout] | [INFO] [stdout] 654 | ... from_children.retain(|item| item.borrow().path != from_path); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:774:26 [INFO] [stdout] | [INFO] [stdout] 774 | .map(|n| n.borrow().path.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/fs.rs:960:33 [INFO] [stdout] | [INFO] [stdout] 960 | ... drop(contents); [INFO] [stdout] | ^^^^^--------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Vec` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 960 - drop(contents); [INFO] [stdout] 960 + let _ = contents; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | fn str_to_null_terminated_buf>(s: S) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | / CString::new(s.as_ref()) [INFO] [stdout] 50 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:143:19 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn new(device: Device) -> Badge { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | data: Mutex::new(BadgeData { [INFO] [stdout] | ___________________^ [INFO] [stdout] 144 | | wakers: HashMap::new(), [INFO] [stdout] 145 | | last_message_id: 0, [INFO] [stdout] 146 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 172 | let mut data = self.data.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let request_data = Arc::new(Mutex::new(BadgeRequestData { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(BadgeRequest { data: request_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn dir>(path: P, ino: u64) -> Ino { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | data: InoData::Directory { children: None }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:350:17 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn new(badge: Arc, io: &'a Stream) -> AppFS<'a> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let flash = Arc::new(RefCell::new(Ino { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let sdcard = Arc::new(RefCell::new(Ino { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let serial = Arc::new(RefCell::new(Ino { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | let run = Arc::new(RefCell::new(Ino { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | rt: Arc::new(RefCell::new(Runtime::new().unwrap())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:373:37 [INFO] [stdout] | [INFO] [stdout] 373 | .filter(|n| n.borrow().name.as_str() == name) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:550:56 [INFO] [stdout] | [INFO] [stdout] 550 | ... children.retain(|item| item.borrow().path != path); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:590:56 [INFO] [stdout] | [INFO] [stdout] 590 | ... children.retain(|item| item.borrow().path != path); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:645:56 [INFO] [stdout] | [INFO] [stdout] 645 | ... .filter(|item| item.borrow().path == from_path) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:654:61 [INFO] [stdout] | [INFO] [stdout] 654 | ... from_children.retain(|item| item.borrow().path != from_path); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:774:26 [INFO] [stdout] | [INFO] [stdout] 774 | .map(|n| n.borrow().path.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/fs.rs:960:33 [INFO] [stdout] | [INFO] [stdout] 960 | ... drop(contents); [INFO] [stdout] | ^^^^^--------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Vec` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 960 - drop(contents); [INFO] [stdout] 960 + let _ = contents; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cz2020-usbtool` (bin "cz2020-usbtool") due to 12 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cz2020-usbtool` (bin "cz2020-usbtool" test) due to 12 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b45ca975a3df1a2f828d96c2f7590d44bd1daa5d31e5e16904da79cc920d0876", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b45ca975a3df1a2f828d96c2f7590d44bd1daa5d31e5e16904da79cc920d0876", kill_on_drop: false }` [INFO] [stdout] b45ca975a3df1a2f828d96c2f7590d44bd1daa5d31e5e16904da79cc920d0876