[INFO] cloning repository https://github.com/Jorbon/gl_engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jorbon/gl_engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJorbon%2Fgl_engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJorbon%2Fgl_engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 74ade9569440bcedb1ab85ff1c02c1e065dba97d [INFO] checking Jorbon/gl_engine/74ade9569440bcedb1ab85ff1c02c1e065dba97d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJorbon%2Fgl_engine" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Jorbon/gl_engine on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Jorbon/gl_engine [INFO] finished tweaking git repo https://github.com/Jorbon/gl_engine [INFO] tweaked toml for git repo https://github.com/Jorbon/gl_engine written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Jorbon/gl_engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c6d8c46238646fa96e3418c1bcf0c34ed8183c8ef6d68b8275a2104f822c00a [INFO] running `Command { std: "docker" "start" "-a" "7c6d8c46238646fa96e3418c1bcf0c34ed8183c8ef6d68b8275a2104f822c00a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c6d8c46238646fa96e3418c1bcf0c34ed8183c8ef6d68b8275a2104f822c00a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c6d8c46238646fa96e3418c1bcf0c34ed8183c8ef6d68b8275a2104f822c00a", kill_on_drop: false }` [INFO] [stdout] 7c6d8c46238646fa96e3418c1bcf0c34ed8183c8ef6d68b8275a2104f822c00a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 424d97af1b15aee99c571b6314678e2ba967357b401247b62817f050fbc40f6c [INFO] running `Command { std: "docker" "start" "-a" "424d97af1b15aee99c571b6314678e2ba967357b401247b62817f050fbc40f6c", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling xml-rs v0.8.16 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking libloading v0.8.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling thiserror v1.0.46 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Compiling slotmap v1.0.6 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Compiling servo-fontconfig-sys v5.1.0 [INFO] [stderr] Compiling crossfont v0.5.1 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.0 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Compiling cc v1.0.82 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking tiny-skia-path v0.7.0 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking png v0.17.9 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling glutin_glx_sys v0.1.8 [INFO] [stderr] Compiling glutin_egl_sys v0.1.6 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking gimli v0.27.3 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling glium v0.32.1 [INFO] [stderr] Checking object v0.31.1 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking tiny-skia v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Compiling freetype-sys v0.13.1 [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Compiling backtrace v0.3.68 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking freetype-rs v0.26.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking servo-fontconfig v0.5.1 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking addr2line v0.20.0 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking takeable-option v0.5.0 [INFO] [stderr] Checking spin_sleep v1.2.0 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking wayland-egl v0.29.5 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.46 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Checking tiff v0.9.0 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking exr v1.7.0 [INFO] [stderr] Checking image v0.24.7 [INFO] [stderr] Checking sctk-adwaita v0.4.3 [INFO] [stderr] Checking winit v0.27.5 [INFO] [stderr] Checking glutin v0.29.1 [INFO] [stderr] Checking gl_engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `v1` [INFO] [stdout] --> src/physics.rs:172:6 [INFO] [stdout] | [INFO] [stdout] 172 | let v1 = objects[i].velocity + objects[i].angular_velocity.cross(p - objects[i].transform.get_position()); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v2` [INFO] [stdout] --> src/physics.rs:173:6 [INFO] [stdout] | [INFO] [stdout] 173 | let v2 = objects[j].velocity + objects[j].angular_velocity.cross(p - objects[j].transform.get_position()); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/physics.rs:170:65 [INFO] [stdout] | [INFO] [stdout] 170 | fn collide(objects: &mut [Object], i: usize, j: usize, p: Vec3, n: Vec3) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v1` [INFO] [stdout] --> src/physics.rs:172:6 [INFO] [stdout] | [INFO] [stdout] 172 | let v1 = objects[i].velocity + objects[i].angular_velocity.cross(p - objects[i].transform.get_position()); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v2` [INFO] [stdout] --> src/physics.rs:173:6 [INFO] [stdout] | [INFO] [stdout] 173 | let v2 = objects[j].velocity + objects[j].angular_velocity.cross(p - objects[j].transform.get_position()); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/physics.rs:170:65 [INFO] [stdout] | [INFO] [stdout] 170 | fn collide(objects: &mut [Object], i: usize, j: usize, p: Vec3, n: Vec3) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `edges` is never read [INFO] [stdout] --> src/object.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Object { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub edges: Box<[(u16, u16)]>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Object` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fov` is never read [INFO] [stdout] --> src/render.rs:58:6 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct Renderer { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 58 | pub fov: f32, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:40:4 [INFO] [stdout] | [INFO] [stdout] 18 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); // might switch to dynamic later [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, unsafe { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let mut edges = std::collections::HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | (Self { [INFO] [stdout] | __________^ [INFO] [stdout] 41 | | vertices: vertices.to_vec().into_boxed_slice(), [INFO] [stdout] 42 | | indices: indices.to_vec().into_boxed_slice(), [INFO] [stdout] 43 | | edges: edges.into_iter().collect::>().into_boxed_slice(), [INFO] [stdout] ... | [INFO] [stdout] 46 | | angular_velocity: Vec3(0.0, 0.0, 0.0) [INFO] [stdout] 47 | | }, vertex_buffer, index_buffer) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gl_engine` (bin "gl_engine" test) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `edges` is never read [INFO] [stdout] --> src/object.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Object { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub edges: Box<[(u16, u16)]>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Object` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fov` is never read [INFO] [stdout] --> src/render.rs:58:6 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct Renderer { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 58 | pub fov: f32, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:40:4 [INFO] [stdout] | [INFO] [stdout] 18 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); // might switch to dynamic later [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, unsafe { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let mut edges = std::collections::HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | (Self { [INFO] [stdout] | __________^ [INFO] [stdout] 41 | | vertices: vertices.to_vec().into_boxed_slice(), [INFO] [stdout] 42 | | indices: indices.to_vec().into_boxed_slice(), [INFO] [stdout] 43 | | edges: edges.into_iter().collect::>().into_boxed_slice(), [INFO] [stdout] ... | [INFO] [stdout] 46 | | angular_velocity: Vec3(0.0, 0.0, 0.0) [INFO] [stdout] 47 | | }, vertex_buffer, index_buffer) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gl_engine` (bin "gl_engine") due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "424d97af1b15aee99c571b6314678e2ba967357b401247b62817f050fbc40f6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "424d97af1b15aee99c571b6314678e2ba967357b401247b62817f050fbc40f6c", kill_on_drop: false }` [INFO] [stdout] 424d97af1b15aee99c571b6314678e2ba967357b401247b62817f050fbc40f6c