[INFO] cloning repository https://github.com/Jonesey13/Rusty_Dodge [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jonesey13/Rusty_Dodge" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJonesey13%2FRusty_Dodge", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJonesey13%2FRusty_Dodge'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e2b4a08b5ce69649526bd859540593d894f2f8ec [INFO] checking Jonesey13/Rusty_Dodge/e2b4a08b5ce69649526bd859540593d894f2f8ec against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJonesey13%2FRusty_Dodge" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Jonesey13/Rusty_Dodge on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Jonesey13/Rusty_Dodge [INFO] finished tweaking git repo https://github.com/Jonesey13/Rusty_Dodge [INFO] tweaked toml for git repo https://github.com/Jonesey13/Rusty_Dodge written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Jonesey13/Rusty_Dodge already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f1980e5ea9c608ece718ca71f689d5ad62610a7b31ae27c004a9275a17708556 [INFO] running `Command { std: "docker" "start" "-a" "f1980e5ea9c608ece718ca71f689d5ad62610a7b31ae27c004a9275a17708556", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f1980e5ea9c608ece718ca71f689d5ad62610a7b31ae27c004a9275a17708556", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1980e5ea9c608ece718ca71f689d5ad62610a7b31ae27c004a9275a17708556", kill_on_drop: false }` [INFO] [stdout] f1980e5ea9c608ece718ca71f689d5ad62610a7b31ae27c004a9275a17708556 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f2abbcef1c8a46547625f9530d2130c11c809ab9c3cb3ecbfb0d2f2cda4596f [INFO] running `Command { std: "docker" "start" "-a" "7f2abbcef1c8a46547625f9530d2130c11c809ab9c3cb3ecbfb0d2f2cda4596f", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.11 [INFO] [stderr] Checking winapi v0.2.7 [INFO] [stderr] Compiling bitflags v0.7.0 [INFO] [stderr] Compiling gcc v0.3.28 [INFO] [stderr] Checking lazy_static v0.2.1 [INFO] [stderr] Compiling libloading v0.2.2 [INFO] [stderr] Checking lazy_static v0.1.16 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Compiling khronos_api v1.0.0 [INFO] [stderr] Compiling log v0.3.6 [INFO] [stderr] Checking kernel32-sys v0.2.2 [INFO] [stderr] Compiling xml-rs v0.3.4 [INFO] [stderr] Compiling pkg-config v0.3.8 [INFO] [stderr] Checking crossbeam v0.2.9 [INFO] [stderr] Compiling dbghelp-sys v0.2.0 [INFO] [stderr] Checking dlib v0.3.0 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking fs2 v0.2.4 [INFO] [stderr] Compiling x11-dl v2.5.1 [INFO] [stderr] Compiling tempfile v2.1.3 [INFO] [stderr] Checking memmap v0.2.3 [INFO] [stderr] Checking shared_library v0.1.4 [INFO] [stderr] Checking byteorder v0.5.1 [INFO] [stderr] Compiling freetype-sys v0.3.1 [INFO] [stderr] Compiling backtrace-sys v0.1.4 [INFO] [stderr] Compiling libz-sys v1.0.3 [INFO] [stderr] Checking osmesa-sys v0.1.0 [INFO] [stderr] Compiling wayland-scanner v0.5.11 [INFO] [stderr] Compiling gl_generator v0.5.1 [INFO] [stderr] Checking cfg-if v0.1.0 [INFO] [stderr] Checking debug-builders v0.1.0 [INFO] [stderr] Checking smallvec v0.1.7 [INFO] [stderr] Checking backtrace v0.1.8 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Compiling wayland-client v0.5.12 [INFO] [stderr] Compiling glutin v0.5.2 [INFO] [stderr] Compiling glium v0.14.0 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking glium_text v0.9.0 [INFO] [stderr] Checking rusty_dodge v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/polar_game/player.rs:80:109 [INFO] [stdout] | [INFO] [stdout] 80 | self.destruct_parts[i].angle = self.destruct_parts[i].angle + angle_shift.mult(time_passed);; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/polar_game/mod.rs:95:62 [INFO] [stdout] | [INFO] [stdout] 95 | let mut new_survival_time = self.state.survival_time;; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/polar_game/mod.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | self.player.collide();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/polar_game/mod.rs:71:35 [INFO] [stdout] | [INFO] [stdout] 71 | self.player.collide();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/polar_game/player.rs:80:109 [INFO] [stdout] | [INFO] [stdout] 80 | self.destruct_parts[i].angle = self.destruct_parts[i].angle + angle_shift.mult(time_passed);; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/polar_game/mod.rs:95:62 [INFO] [stdout] | [INFO] [stdout] 95 | let mut new_survival_time = self.state.survival_time;; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/polar_game/mod.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | self.player.collide();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/polar_game/mod.rs:71:35 [INFO] [stdout] | [INFO] [stdout] 71 | self.player.collide();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/polar_game/mod.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | for mut f in self.flares.iter_mut(){ [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `player_death` is never read [INFO] [stdout] --> src/polar_game/mod.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 139 | pub struct GameState{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 140 | pub player_death: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GameState` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:84:28 [INFO] [stdout] | [INFO] [stdout] 40 | let display = if cfg!(any(target_os = "macos", target_os = "windows")){ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let program = glium::Program::from_source(&display, &shader.shaders[0], &shader.shaders[1], Some(&shader.shaders[2])).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let txt_system = glium_text::TextSystem::new(&display); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let font_file = match File::open(&Path::new("OpenSans.ttf")){ [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Err(_) => match File::open(&Path::new("src/OpenSans.ttf")){ [INFO] [stdout] 72 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Err(_) => match File::open(&Path::new("../OpenSans.ttf")){ [INFO] [stdout] 74 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let font = glium_text::FontTexture::new(&display, font_file, 120).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | vertex_buffer: glium::VertexBuffer::empty(&display, 0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty_dodge` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/polar_game/mod.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | for mut f in self.flares.iter_mut(){ [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `player_death` is never read [INFO] [stdout] --> src/polar_game/mod.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 139 | pub struct GameState{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 140 | pub player_death: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GameState` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:84:28 [INFO] [stdout] | [INFO] [stdout] 40 | let display = if cfg!(any(target_os = "macos", target_os = "windows")){ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let program = glium::Program::from_source(&display, &shader.shaders[0], &shader.shaders[1], Some(&shader.shaders[2])).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let txt_system = glium_text::TextSystem::new(&display); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let font_file = match File::open(&Path::new("OpenSans.ttf")){ [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Err(_) => match File::open(&Path::new("src/OpenSans.ttf")){ [INFO] [stdout] 72 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Err(_) => match File::open(&Path::new("../OpenSans.ttf")){ [INFO] [stdout] 74 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let font = glium_text::FontTexture::new(&display, font_file, 120).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | vertex_buffer: glium::VertexBuffer::empty(&display, 0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty_dodge` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7f2abbcef1c8a46547625f9530d2130c11c809ab9c3cb3ecbfb0d2f2cda4596f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f2abbcef1c8a46547625f9530d2130c11c809ab9c3cb3ecbfb0d2f2cda4596f", kill_on_drop: false }` [INFO] [stdout] 7f2abbcef1c8a46547625f9530d2130c11c809ab9c3cb3ecbfb0d2f2cda4596f