[INFO] updating cached repository https://github.com/JohnFredok/gfold [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3dfc4d7672a296d27fdd7e06c5a98295f7d0b182 [INFO] checking JohnFredok/gfold/3dfc4d7672a296d27fdd7e06c5a98295f7d0b182 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJohnFredok%2Fgfold" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JohnFredok/gfold on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config [INFO] started tweaking git repo https://github.com/JohnFredok/gfold [INFO] finished tweaking git repo https://github.com/JohnFredok/gfold [INFO] tweaked toml for git repo https://github.com/JohnFredok/gfold written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JohnFredok/gfold already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] warning: /workspace/builds/worker-6-tc2/source/lib/libgfold/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `git2` dependency) [INFO] [stderr] warning: /workspace/builds/worker-6-tc2/source/lib/libgfold/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `env_logger` dependency) [INFO] [stderr] warning: /workspace/builds/worker-6-tc2/source/bin/gfold/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `env_logger` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5db1a38ff12ab49ea1aa81f9bda880503287edd508fb2ba02d6eaf735ddaa9a9 [INFO] running `Command { std: "docker" "start" "-a" "5db1a38ff12ab49ea1aa81f9bda880503287edd508fb2ba02d6eaf735ddaa9a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5db1a38ff12ab49ea1aa81f9bda880503287edd508fb2ba02d6eaf735ddaa9a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5db1a38ff12ab49ea1aa81f9bda880503287edd508fb2ba02d6eaf735ddaa9a9", kill_on_drop: false }` [INFO] [stdout] 5db1a38ff12ab49ea1aa81f9bda880503287edd508fb2ba02d6eaf735ddaa9a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 385e59d4506890be38f5a06f000da74948b8a02a902de3d682f33e0b50e34fa6 [INFO] running `Command { std: "docker" "start" "-a" "385e59d4506890be38f5a06f000da74948b8a02a902de3d682f33e0b50e34fa6", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] warning: /opt/rustwide/workdir/bin/gfold/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `env_logger` dependency) [INFO] [stderr] warning: /opt/rustwide/workdir/lib/libgfold/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `git2` dependency) [INFO] [stderr] warning: /opt/rustwide/workdir/lib/libgfold/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `env_logger` dependency) [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling serde v1.0.167 [INFO] [stderr] Compiling rustix v0.38.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling thiserror v1.0.43 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling rustversion v1.0.13 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking gimli v0.27.3 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking equivalent v1.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking object v0.31.1 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking winnow v0.4.8 [INFO] [stderr] Compiling serde_json v1.0.100 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling syn v2.0.23 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling tempfile v3.6.0 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking ryu v1.0.14 [INFO] [stderr] Checking itoa v1.0.8 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling jobserver v0.1.26 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Compiling libz-sys v1.1.9 [INFO] [stderr] Compiling libgit2-sys v0.15.2+1.6.4 [INFO] [stderr] Compiling backtrace v0.3.68 [INFO] [stderr] Checking addr2line v0.20.0 [INFO] [stderr] Compiling serde_derive v1.0.167 [INFO] [stderr] Compiling thiserror-impl v1.0.43 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Compiling strum_macros v0.25.1 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking git2 v0.17.2 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Checking xtask v0.1.0 (/opt/rustwide/workdir/bin/xtask) [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking libgfold v0.1.1 (/opt/rustwide/workdir/lib/libgfold) [INFO] [stdout] warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC for more information [INFO] [stdout] --> lib/libgfold/src/lib.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | private_in_public, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC for more information [INFO] [stdout] --> lib/libgfold/src/lib.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | private_in_public, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking toml_edit v0.19.12 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/libgfold/src/status.rs:19:41 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/libgfold/src/status.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 50 | let head = match repo.head() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Ok(head) => Some(head), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let (remote, remote_name) = match repo.find_remote("origin") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Ok(origin) => (Some(origin), Some("origin".to_string())), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let mut opts = StatusOptions::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(v) if v.is_empty() => match &head { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Ok((status, head, remote)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/libgfold/src/status.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 125 | let remotes = repository.remotes()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Ok(match remotes.get(0) { [INFO] [stdout] | ____________^ [INFO] [stdout] 127 | | Some(remote_name) => ( [INFO] [stdout] 128 | | Some(repository.find_remote(remote_name)?), [INFO] [stdout] 129 | | Some(remote_name.to_string()), [INFO] [stdout] 130 | | ), [INFO] [stdout] 131 | | None => (None, None), [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libgfold` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/libgfold/src/status.rs:19:41 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/libgfold/src/status.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 50 | let head = match repo.head() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Ok(head) => Some(head), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let (remote, remote_name) = match repo.find_remote("origin") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Ok(origin) => (Some(origin), Some("origin".to_string())), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let mut opts = StatusOptions::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(v) if v.is_empty() => match &head { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Ok((status, head, remote)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/libgfold/src/status.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 125 | let remotes = repository.remotes()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Ok(match remotes.get(0) { [INFO] [stdout] | ____________^ [INFO] [stdout] 127 | | Some(remote_name) => ( [INFO] [stdout] 128 | | Some(repository.find_remote(remote_name)?), [INFO] [stdout] 129 | | Some(remote_name.to_string()), [INFO] [stdout] 130 | | ), [INFO] [stdout] 131 | | None => (None, None), [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libgfold` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "385e59d4506890be38f5a06f000da74948b8a02a902de3d682f33e0b50e34fa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "385e59d4506890be38f5a06f000da74948b8a02a902de3d682f33e0b50e34fa6", kill_on_drop: false }` [INFO] [stdout] 385e59d4506890be38f5a06f000da74948b8a02a902de3d682f33e0b50e34fa6