[INFO] cloning repository https://github.com/Johan-Mi/ol [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Johan-Mi/ol" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJohan-Mi%2Fol", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJohan-Mi%2Fol'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7094594a48ebf002eb29742487c253647cbd9295 [INFO] checking Johan-Mi/ol/7094594a48ebf002eb29742487c253647cbd9295 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJohan-Mi%2Fol" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Johan-Mi/ol on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Johan-Mi/ol [INFO] finished tweaking git repo https://github.com/Johan-Mi/ol [INFO] tweaked toml for git repo https://github.com/Johan-Mi/ol written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Johan-Mi/ol already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 568ce84e2126a4d5bba116c1a76aa67a175c7fae1d3f8b373d59d28df39a07d5 [INFO] running `Command { std: "docker" "start" "-a" "568ce84e2126a4d5bba116c1a76aa67a175c7fae1d3f8b373d59d28df39a07d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "568ce84e2126a4d5bba116c1a76aa67a175c7fae1d3f8b373d59d28df39a07d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "568ce84e2126a4d5bba116c1a76aa67a175c7fae1d3f8b373d59d28df39a07d5", kill_on_drop: false }` [INFO] [stdout] 568ce84e2126a4d5bba116c1a76aa67a175c7fae1d3f8b373d59d28df39a07d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0478c1068b15a6d226515788501799c9a960f6e5747295971dc00f440acb272a [INFO] running `Command { std: "docker" "start" "-a" "0478c1068b15a6d226515788501799c9a960f6e5747295971dc00f440acb272a", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking winnow v0.4.4 [INFO] [stderr] Checking ol v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `properties` is never read [INFO] [stdout] --> src/object.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Object { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 6 | pub class: ClassID, [INFO] [stdout] 7 | pub properties: HashMap, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Object` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/value.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | I32(i32), [INFO] [stdout] | --- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Value` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 9 | I32(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 69 | let unit_literal = ('(', ws, ')').value(Expression::Literal(Value::Unit)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | let r#true = keyword("true").value(Expression::Literal(Value::Bool(true))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let r#false = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / alt(( [INFO] [stdout] 80 | | unit_literal, [INFO] [stdout] 81 | | parenthesized_expression, [INFO] [stdout] 82 | | r#true, [INFO] [stdout] ... | [INFO] [stdout] 89 | | local_variable, [INFO] [stdout] 90 | | )) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 188 | let normal = take_till1("\"\\\n").map(Cow::Borrowed); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let null = terminated('0', not(digit1)).value(Cow::Borrowed("\0")); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let character_escape_sequence = alt(( [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let hex_escape_sequence = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | preceded('x', count::<_, _, (), _, _>(hex_digit, 2).recognize()); [INFO] [stdout] 205 | let hex4digits = count::<_, _, (), _, _>(hex_digit, 4).recognize(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let bracketed_unicode = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | delimited('{', take_while(1..=6, |c: char| c.is_ascii_hexdigit()), '}'); [INFO] [stdout] 208 | let unicode_escape_sequence = [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | preceded('u', alt((hex4digits, bracketed_unicode))); [INFO] [stdout] 210 | let escape_sequence = preceded( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let string_char = alt((normal, escape_sequence)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | / delimited('"', repeat0(string_char), '"') [INFO] [stdout] 225 | | .map(|strs: Vec<_>| strs.concat()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 11 | expression: expression::Of, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ) -> Result { [INFO] [stdout] 13 | Ok(match expression { [INFO] [stdout] | ____________^ [INFO] [stdout] 14 | | expression::Of::Literal(value) => expression::Of::Literal(value), [INFO] [stdout] 15 | | expression::Of::MethodCall { [INFO] [stdout] 16 | | name, [INFO] [stdout] ... | [INFO] [stdout] 63 | | ), [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `properties` is never read [INFO] [stdout] --> src/object.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Object { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 6 | pub class: ClassID, [INFO] [stdout] 7 | pub properties: HashMap, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Object` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/value.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | I32(i32), [INFO] [stdout] | --- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Value` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 9 | I32(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 69 | let unit_literal = ('(', ws, ')').value(Expression::Literal(Value::Unit)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | let r#true = keyword("true").value(Expression::Literal(Value::Bool(true))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let r#false = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / alt(( [INFO] [stdout] 80 | | unit_literal, [INFO] [stdout] 81 | | parenthesized_expression, [INFO] [stdout] 82 | | r#true, [INFO] [stdout] ... | [INFO] [stdout] 89 | | local_variable, [INFO] [stdout] 90 | | )) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 188 | let normal = take_till1("\"\\\n").map(Cow::Borrowed); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let null = terminated('0', not(digit1)).value(Cow::Borrowed("\0")); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let character_escape_sequence = alt(( [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let hex_escape_sequence = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | preceded('x', count::<_, _, (), _, _>(hex_digit, 2).recognize()); [INFO] [stdout] 205 | let hex4digits = count::<_, _, (), _, _>(hex_digit, 4).recognize(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let bracketed_unicode = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | delimited('{', take_while(1..=6, |c: char| c.is_ascii_hexdigit()), '}'); [INFO] [stdout] 208 | let unicode_escape_sequence = [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | preceded('u', alt((hex4digits, bracketed_unicode))); [INFO] [stdout] 210 | let escape_sequence = preceded( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let string_char = alt((normal, escape_sequence)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | / delimited('"', repeat0(string_char), '"') [INFO] [stdout] 225 | | .map(|strs: Vec<_>| strs.concat()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolve.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 11 | expression: expression::Of, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ) -> Result { [INFO] [stdout] 13 | Ok(match expression { [INFO] [stdout] | ____________^ [INFO] [stdout] 14 | | expression::Of::Literal(value) => expression::Of::Literal(value), [INFO] [stdout] 15 | | expression::Of::MethodCall { [INFO] [stdout] 16 | | name, [INFO] [stdout] ... | [INFO] [stdout] 63 | | ), [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ol` (bin "ol") due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ol` (bin "ol" test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0478c1068b15a6d226515788501799c9a960f6e5747295971dc00f440acb272a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0478c1068b15a6d226515788501799c9a960f6e5747295971dc00f440acb272a", kill_on_drop: false }` [INFO] [stdout] 0478c1068b15a6d226515788501799c9a960f6e5747295971dc00f440acb272a