[INFO] cloning repository https://github.com/JimPaine/bop [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JimPaine/bop" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJimPaine%2Fbop", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJimPaine%2Fbop'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 56aca3b027822072a7b2317f5bff423238a2be23 [INFO] checking JimPaine/bop/56aca3b027822072a7b2317f5bff423238a2be23 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJimPaine%2Fbop" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JimPaine/bop on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JimPaine/bop [INFO] finished tweaking git repo https://github.com/JimPaine/bop [INFO] tweaked toml for git repo https://github.com/JimPaine/bop written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JimPaine/bop already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6922a9eebd6158e985efc4066d5dbf98afa4f81e1216513dc32c50811892bde1 [INFO] running `Command { std: "docker" "start" "-a" "6922a9eebd6158e985efc4066d5dbf98afa4f81e1216513dc32c50811892bde1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6922a9eebd6158e985efc4066d5dbf98afa4f81e1216513dc32c50811892bde1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6922a9eebd6158e985efc4066d5dbf98afa4f81e1216513dc32c50811892bde1", kill_on_drop: false }` [INFO] [stdout] 6922a9eebd6158e985efc4066d5dbf98afa4f81e1216513dc32c50811892bde1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0c0e291b3f558ac96bf896c456bdd6387bef66ce0f4697ec9391d09d09af7c4f [INFO] running `Command { std: "docker" "start" "-a" "0c0e291b3f558ac96bf896c456bdd6387bef66ce0f4697ec9391d09d09af7c4f", kill_on_drop: false }` [INFO] [stderr] Checking bop v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/lexer.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | for i in 0..self.source.len() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/lexer.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | for i in 0..self.source.len() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Lexer` is never constructed [INFO] [stdout] --> src/lexer.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Lexer { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/lexer.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Lexer { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 12 | [INFO] [stdout] 13 | pub fn new(source: &str) -> Lexer { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn scan(&mut self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | fn get_identifier(&mut self) -> Token { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 83 | fn get_number(&mut self) -> Token { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 101 | fn get_string(&mut self) -> Token { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 119 | fn collect_until(&mut self, condition: impl Fn(&mut Lexer) -> bool, eof_reached_error: Option) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 133 | fn peek(&mut self) -> char { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 137 | fn forward(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | fn is_alphanumeric(c: char) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 145 | fn is_numeric(c: char) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `child` is never read [INFO] [stdout] --> src/parser.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct PropertyExpression { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 9 | pub name: String, [INFO] [stdout] 10 | pub child: Option> [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `left` and `right` are never read [INFO] [stdout] --> src/parser.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct AssignmentExpression { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 23 | pub left: PropertyExpression, [INFO] [stdout] | ^^^^ [INFO] [stdout] 24 | pub right: Box [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `display` and `typename` are never used [INFO] [stdout] --> src/parser.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub trait ExpressionEvaluator { [INFO] [stdout] | ------------------- methods in this trait [INFO] [stdout] 49 | fn display(&self) -> String; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 50 | fn typename(&self) -> String; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `visit_assignment` is never used [INFO] [stdout] --> src/parser.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 53 | pub trait Visitor { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 54 | fn visit_assignment(&mut self, lhs: PropertyExpression) -> AssignmentExpression; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `parse` are never used [INFO] [stdout] --> src/parser.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 61 | impl Parser { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 62 | pub fn new(tokens: Vec) -> Parser { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 68 | pub fn parse(&mut self) -> Vec { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `line` is never read [INFO] [stdout] --> src/models/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 4 | pub line: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/models/mod.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum TokenType { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 9 | // Punctuation [INFO] [stdout] 10 | DOT, [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | ASSIGN, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | IDENTIFIER, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 17 | STRING, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 18 | NUMBER, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | EOL, [INFO] [stdout] | ^^^ [INFO] [stdout] 22 | EOF [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:146:65 [INFO] [stdout] | [INFO] [stdout] 131 | let mut child = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | PropertyExpression { name: token.lexeme.clone(), child: match child { [INFO] [stdout] | _________________________________________________________________^ [INFO] [stdout] 147 | | Some(c) => Some(Box::new(c)), [INFO] [stdout] 148 | | _ => None, [INFO] [stdout] 149 | | }} [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `tokens` is never read [INFO] [stdout] --> src/lexer.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Lexer { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | tokens: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:146:65 [INFO] [stdout] | [INFO] [stdout] 131 | let mut child = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | PropertyExpression { name: token.lexeme.clone(), child: match child { [INFO] [stdout] | _________________________________________________________________^ [INFO] [stdout] 147 | | Some(c) => Some(Box::new(c)), [INFO] [stdout] 148 | | _ => None, [INFO] [stdout] 149 | | }} [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bop` (bin "bop") due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bop` (bin "bop" test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0c0e291b3f558ac96bf896c456bdd6387bef66ce0f4697ec9391d09d09af7c4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c0e291b3f558ac96bf896c456bdd6387bef66ce0f4697ec9391d09d09af7c4f", kill_on_drop: false }` [INFO] [stdout] 0c0e291b3f558ac96bf896c456bdd6387bef66ce0f4697ec9391d09d09af7c4f