[INFO] cloning repository https://github.com/Jess3Jane/json-api [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jess3Jane/json-api" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJess3Jane%2Fjson-api", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJess3Jane%2Fjson-api'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 15d2cae53b1c8eb66795f72d6360d51fcf9a617e [INFO] checking Jess3Jane/json-api/15d2cae53b1c8eb66795f72d6360d51fcf9a617e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJess3Jane%2Fjson-api" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Jess3Jane/json-api on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Jess3Jane/json-api [INFO] finished tweaking git repo https://github.com/Jess3Jane/json-api [INFO] tweaked toml for git repo https://github.com/Jess3Jane/json-api written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Jess3Jane/json-api already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e66901bc59bddfbfbbc28d2aeac0d543fe92c61785bb329b5ba487a3dd34cd7d [INFO] running `Command { std: "docker" "start" "-a" "e66901bc59bddfbfbbc28d2aeac0d543fe92c61785bb329b5ba487a3dd34cd7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e66901bc59bddfbfbbc28d2aeac0d543fe92c61785bb329b5ba487a3dd34cd7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e66901bc59bddfbfbbc28d2aeac0d543fe92c61785bb329b5ba487a3dd34cd7d", kill_on_drop: false }` [INFO] [stdout] e66901bc59bddfbfbbc28d2aeac0d543fe92c61785bb329b5ba487a3dd34cd7d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e1bc70dc0b328ab311ef33ccdd153d851c058d2a408d66292fe6a1444e63396b [INFO] running `Command { std: "docker" "start" "-a" "e1bc70dc0b328ab311ef33ccdd153d851c058d2a408d66292fe6a1444e63396b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.39 [INFO] [stderr] Compiling serde v1.0.94 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling serde_derive v1.0.94 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking json-api v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Deserialize` [INFO] [stdout] --> src/optional_vec.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | use serde_derive::{Serialize, Deserialize}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/object/resource.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | use serde_json::{Error, Value, self}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TryInto` [INFO] [stdout] --> src/object/resource.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | use std::convert::{TryFrom, TryInto}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Links` and `Relationships` [INFO] [stdout] --> src/object/identifier.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{Meta, Relationships, Links, GenericObject, ResourceObject, Attributes}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::ObjectConversionError` [INFO] [stdout] --> src/object/identifier.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use super::ObjectConversionError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Value` [INFO] [stdout] --> src/object/conversion_error.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Value, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/links.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/object/generic.rs:136:10 [INFO] [stdout] | [INFO] [stdout] 136 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/object/resource.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | use serde_json::{Error, Value, self}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Links` and `Relationships` [INFO] [stdout] --> src/object/identifier.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{Meta, Relationships, Links, GenericObject, ResourceObject, Attributes}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::ObjectConversionError` [INFO] [stdout] --> src/object/identifier.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use super::ObjectConversionError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Value` [INFO] [stdout] --> src/object/conversion_error.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | Value, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/links.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> src/object/resource.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 73 | fn links(id: &str) -> Option { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optional_vec.rs:68:15 [INFO] [stdout] | [INFO] [stdout] 60 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | match serde_json::from_value::>(v.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/generic.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 40 | fn from(ro: ResourceObject) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | attributes: serde_json::from_value(v).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/resource.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 85 | let attributes = if let Some(m) = go.attributes { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let v = Value::Object(m.into_iter().collect()); [INFO] [stdout] 87 | let a : A = serde_json::from_value(v)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | id: go.id, [INFO] [stdout] 93 | | attributes, [INFO] [stdout] 94 | | relationships: go.relationships, [INFO] [stdout] 95 | | links: go.links, [INFO] [stdout] 96 | | meta: go.meta, [INFO] [stdout] 97 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/resource.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 108 | let attributes = if let Some(m) = &go.attributes { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let v = Value::Object(m.iter().map(|(k,v)| (k.clone(), v.clone())).collect()); [INFO] [stdout] 110 | let a : A = serde_json::from_value(v)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok( Self{ [INFO] [stdout] | _____________^ [INFO] [stdout] 115 | | id: go.id.clone(), [INFO] [stdout] 116 | | attributes, [INFO] [stdout] 117 | | relationships: go.relationships.clone(), [INFO] [stdout] 118 | | links: go.links.clone(), [INFO] [stdout] 119 | | meta: go.meta.clone(), [INFO] [stdout] 120 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `json-api` (lib) due to 5 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> src/object/resource.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 73 | fn links(id: &str) -> Option { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optional_vec.rs:68:15 [INFO] [stdout] | [INFO] [stdout] 60 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | match serde_json::from_value::>(v.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/generic.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 40 | fn from(ro: ResourceObject) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | attributes: serde_json::from_value(v).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/resource.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 85 | let attributes = if let Some(m) = go.attributes { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let v = Value::Object(m.into_iter().collect()); [INFO] [stdout] 87 | let a : A = serde_json::from_value(v)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | id: go.id, [INFO] [stdout] 93 | | attributes, [INFO] [stdout] 94 | | relationships: go.relationships, [INFO] [stdout] 95 | | links: go.links, [INFO] [stdout] 96 | | meta: go.meta, [INFO] [stdout] 97 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/resource.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 108 | let attributes = if let Some(m) = &go.attributes { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let v = Value::Object(m.iter().map(|(k,v)| (k.clone(), v.clone())).collect()); [INFO] [stdout] 110 | let a : A = serde_json::from_value(v)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok( Self{ [INFO] [stdout] | _____________^ [INFO] [stdout] 115 | | id: go.id.clone(), [INFO] [stdout] 116 | | attributes, [INFO] [stdout] 117 | | relationships: go.relationships.clone(), [INFO] [stdout] 118 | | links: go.links.clone(), [INFO] [stdout] 119 | | meta: go.meta.clone(), [INFO] [stdout] 120 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `json-api` (lib test) due to 5 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e1bc70dc0b328ab311ef33ccdd153d851c058d2a408d66292fe6a1444e63396b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1bc70dc0b328ab311ef33ccdd153d851c058d2a408d66292fe6a1444e63396b", kill_on_drop: false }` [INFO] [stdout] e1bc70dc0b328ab311ef33ccdd153d851c058d2a408d66292fe6a1444e63396b