[INFO] cloning repository https://github.com/JeffreyThijs/boombox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JeffreyThijs/boombox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJeffreyThijs%2Fboombox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJeffreyThijs%2Fboombox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1d63e92892f02d8c382e01a688aaa18f6253c59a [INFO] checking JeffreyThijs/boombox/1d63e92892f02d8c382e01a688aaa18f6253c59a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJeffreyThijs%2Fboombox" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JeffreyThijs/boombox on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JeffreyThijs/boombox [INFO] finished tweaking git repo https://github.com/JeffreyThijs/boombox [INFO] tweaked toml for git repo https://github.com/JeffreyThijs/boombox written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JeffreyThijs/boombox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 754fdae133d9c665cdacc6db8c09e7bb3254fcee0ef445d2a800a42b95bffdbc [INFO] running `Command { std: "docker" "start" "-a" "754fdae133d9c665cdacc6db8c09e7bb3254fcee0ef445d2a800a42b95bffdbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "754fdae133d9c665cdacc6db8c09e7bb3254fcee0ef445d2a800a42b95bffdbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "754fdae133d9c665cdacc6db8c09e7bb3254fcee0ef445d2a800a42b95bffdbc", kill_on_drop: false }` [INFO] [stdout] 754fdae133d9c665cdacc6db8c09e7bb3254fcee0ef445d2a800a42b95bffdbc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6870634ee860688b0cec9a3d26c062a8c032158225a90f7dcc4094cee65acd17 [INFO] running `Command { std: "docker" "start" "-a" "6870634ee860688b0cec9a3d26c062a8c032158225a90f7dcc4094cee65acd17", kill_on_drop: false }` [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking symphonia-core v0.5.3 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling libpulse-sys v1.21.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling libpulse-simple-sys v1.21.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking symphonia-metadata v0.5.3 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.3 [INFO] [stderr] Checking symphonia-codec-alac v0.5.3 [INFO] [stderr] Checking symphonia-codec-aac v0.5.3 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.3 [INFO] [stderr] Checking primal-check v0.3.3 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking transpose v0.2.2 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.3 [INFO] [stderr] Checking symphonia-format-wav v0.5.3 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.3 [INFO] [stderr] Checking symphonia-format-isomp4 v0.5.3 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.3 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.3 [INFO] [stderr] Checking symphonia-format-mkv v0.5.3 [INFO] [stderr] Checking symphonia-format-ogg v0.5.3 [INFO] [stderr] Checking rustfft v5.1.1 [INFO] [stderr] Checking symphonia v0.5.3 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking libpulse-binding v2.28.1 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking libpulse-simple-binding v2.28.1 [INFO] [stderr] Checking boombox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `stft_result` [INFO] [stdout] --> src/display.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | let stft_result = self.stft(&mono, 256, 128); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stft_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tb` [INFO] [stdout] --> src/main.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | let tb = track.codec_params.time_base; [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_tb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dur` [INFO] [stdout] --> src/main.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | let dur = track.codec_params.n_frames.map(|frames| track.codec_params.start_ts + frames); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dur` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_progress` is never used [INFO] [stdout] --> src/main.rs:449:4 [INFO] [stdout] | [INFO] [stdout] 449 | fn print_progress(ts: u64, dur: Option, tb: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `flush` is never used [INFO] [stdout] --> src/display.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Display { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 6 | fn write(&mut self, decoded: AudioBufferRef<'_>) -> Result<()>; [INFO] [stdout] 7 | fn flush(&mut self); [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:124:11 [INFO] [stdout] | [INFO] [stdout] 88 | let source = if path_str == "-" { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let mss = MediaSourceStream::new(source, Default::default()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | match symphonia::default::get_probe().format(&hint, mss, &format_opts, &metadata_opts) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 36 | let sample_buf = RawSampleBuffer::::new(duration, spec); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(Box::new(STFTDisplay { sample_buf })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boombox` (bin "boombox") due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `stft_result` [INFO] [stdout] --> src/display.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | let stft_result = self.stft(&mono, 256, 128); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stft_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tb` [INFO] [stdout] --> src/main.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | let tb = track.codec_params.time_base; [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_tb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dur` [INFO] [stdout] --> src/main.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | let dur = track.codec_params.n_frames.map(|frames| track.codec_params.start_ts + frames); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dur` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_progress` is never used [INFO] [stdout] --> src/main.rs:449:4 [INFO] [stdout] | [INFO] [stdout] 449 | fn print_progress(ts: u64, dur: Option, tb: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `flush` is never used [INFO] [stdout] --> src/display.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Display { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 6 | fn write(&mut self, decoded: AudioBufferRef<'_>) -> Result<()>; [INFO] [stdout] 7 | fn flush(&mut self); [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:124:11 [INFO] [stdout] | [INFO] [stdout] 88 | let source = if path_str == "-" { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let mss = MediaSourceStream::new(source, Default::default()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | match symphonia::default::get_probe().format(&hint, mss, &format_opts, &metadata_opts) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 36 | let sample_buf = RawSampleBuffer::::new(duration, spec); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(Box::new(STFTDisplay { sample_buf })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boombox` (bin "boombox" test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6870634ee860688b0cec9a3d26c062a8c032158225a90f7dcc4094cee65acd17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6870634ee860688b0cec9a3d26c062a8c032158225a90f7dcc4094cee65acd17", kill_on_drop: false }` [INFO] [stdout] 6870634ee860688b0cec9a3d26c062a8c032158225a90f7dcc4094cee65acd17