[INFO] cloning repository https://github.com/JayAlwaysCodes/rust_blockchain [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JayAlwaysCodes/rust_blockchain" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJayAlwaysCodes%2Frust_blockchain", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJayAlwaysCodes%2Frust_blockchain'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 13e094b9eae139a9096ec3f16b4c414889f80984 [INFO] checking JayAlwaysCodes/rust_blockchain/13e094b9eae139a9096ec3f16b4c414889f80984 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJayAlwaysCodes%2Frust_blockchain" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JayAlwaysCodes/rust_blockchain on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JayAlwaysCodes/rust_blockchain [INFO] finished tweaking git repo https://github.com/JayAlwaysCodes/rust_blockchain [INFO] tweaked toml for git repo https://github.com/JayAlwaysCodes/rust_blockchain written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JayAlwaysCodes/rust_blockchain already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0758c6be20c5207e28800579cadbe4bdf6de45ec1651c43c29c8d22611bf8b22 [INFO] running `Command { std: "docker" "start" "-a" "0758c6be20c5207e28800579cadbe4bdf6de45ec1651c43c29c8d22611bf8b22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0758c6be20c5207e28800579cadbe4bdf6de45ec1651c43c29c8d22611bf8b22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0758c6be20c5207e28800579cadbe4bdf6de45ec1651c43c29c8d22611bf8b22", kill_on_drop: false }` [INFO] [stdout] 0758c6be20c5207e28800579cadbe4bdf6de45ec1651c43c29c8d22611bf8b22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c38e0ab31f7df011b5b0fa4ba5429448381c9d92d39bf16f0f6357ed3fe5e614 [INFO] running `Command { std: "docker" "start" "-a" "c38e0ab31f7df011b5b0fa4ba5429448381c9d92d39bf16f0f6357ed3fe5e614", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.199 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking bitcoin_hashes v0.7.6 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking typeable v0.1.2 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking error v0.1.9 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.199 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking merkle-cbt v0.3.2 [INFO] [stderr] Checking blockchain v0.1.9 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking bitcoincash-addr v0.5.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking rust-blockchain v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `blockchain::Blockchain` [INFO] [stdout] --> src/block.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::{blockchain::Blockchain, transaction::Transaction}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/block.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | for mut tx in self.transactions{ [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/block.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | for mut tx in self.transactions{ [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `can_unlock_output_with` is never used [INFO] [stdout] --> src/tx.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl TXInput { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] 30 | /// CanUnlockOutputWith checks whether the address initiated the transaction [INFO] [stdout] 31 | pub fn can_unlock_output_with(&self, unlocking_data: &[u8]) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `can_be_unlock_with`, `lock`, and `new` are never used [INFO] [stdout] --> src/tx.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl TXOutput { [INFO] [stdout] | ------------- associated items in this implementation [INFO] [stdout] 42 | /// CanBeUnlockedWith checks if the output can be unlocked with the provided data [INFO] [stdout] 43 | pub fn can_be_unlock_with(&self, unlocking_data: &[u8]) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 48 | fn lock(&mut self, address: &str) -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn new(value: i32, address: String) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 33 | let db = sled::open("data/blocks")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let hash = match db.get("LAST")? { [INFO] [stdout] 35 | Some(l) => l.to_vec(), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Blockchain { tip: lasthash, db }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_UTXO` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn find_UTXO(&self) -> HashMap { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `find_utxo` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_prev_TXs` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:158:8 [INFO] [stdout] | [INFO] [stdout] 158 | fn get_prev_TXs(&self, tx: &Transaction) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `get_prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:159:17 [INFO] [stdout] | [INFO] [stdout] 159 | let mut prev_TXs = HashMap::new(); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TX` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | let prev_TX = self.find_transacton(&vin.txid)?; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `prev_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | let prev_TXs = self.get_prev_TXs(tx)?; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | let prev_TXs = self.get_prev_TXs(tx)?; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `new_UTXO` should have a snake case name [INFO] [stdout] --> src/transaction.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new_UTXO(wallet: &Wallet, to: &str, amount: i32, utxo: &UTXOSet) -> Result { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `new_utxo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/transaction.rs:133:26 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn verify(&self, prev_TXs: HashMap) -> Result { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_Tx` should have a snake case name [INFO] [stdout] --> src/transaction.rs:147:17 [INFO] [stdout] | [INFO] [stdout] 147 | let prev_Tx = prev_TXs.get(&self.vin[in_id].txid).unwrap(); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `prev_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/transaction.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | prev_TXs: HashMap, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_Tx` should have a snake case name [INFO] [stdout] --> src/transaction.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | let prev_Tx = prev_TXs.get(&tx_copy.vin[in_id].txid).unwrap(); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `prev_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_UTXO` should have a snake case name [INFO] [stdout] --> src/utxoset.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn find_UTXO(&self, pub_key_hash: &[u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `find_utxo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn new(port: &str, miner_address: &str, utxo: UTXOSet) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let mut node_set = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | node_set.insert(String::from(KNOWN_NODE1)); [INFO] [stdout] 88 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | node_address: String::from("localhost:") + port, [INFO] [stdout] 90 | | mining_address: miner_address.to_string(), [INFO] [stdout] 91 | | inner: Arc::new(Mutex::new(ServerInner { [INFO] [stdout] ... | [INFO] [stdout] 96 | | })), [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `can_unlock_output_with` is never used [INFO] [stdout] --> src/tx.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl TXInput { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] 30 | /// CanUnlockOutputWith checks whether the address initiated the transaction [INFO] [stdout] 31 | pub fn can_unlock_output_with(&self, unlocking_data: &[u8]) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `can_be_unlock_with`, `lock`, and `new` are never used [INFO] [stdout] --> src/tx.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl TXOutput { [INFO] [stdout] | ------------- associated items in this implementation [INFO] [stdout] 42 | /// CanBeUnlockedWith checks if the output can be unlocked with the provided data [INFO] [stdout] 43 | pub fn can_be_unlock_with(&self, unlocking_data: &[u8]) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 48 | fn lock(&mut self, address: &str) -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn new(value: i32, address: String) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockchain.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 33 | let db = sled::open("data/blocks")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let hash = match db.get("LAST")? { [INFO] [stdout] 35 | Some(l) => l.to_vec(), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Blockchain { tip: lasthash, db }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_UTXO` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn find_UTXO(&self) -> HashMap { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `find_utxo` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_prev_TXs` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:158:8 [INFO] [stdout] | [INFO] [stdout] 158 | fn get_prev_TXs(&self, tx: &Transaction) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `get_prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:159:17 [INFO] [stdout] | [INFO] [stdout] 159 | let mut prev_TXs = HashMap::new(); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TX` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | let prev_TX = self.find_transacton(&vin.txid)?; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `prev_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | let prev_TXs = self.get_prev_TXs(tx)?; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/blockchain.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | let prev_TXs = self.get_prev_TXs(tx)?; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `new_UTXO` should have a snake case name [INFO] [stdout] --> src/transaction.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new_UTXO(wallet: &Wallet, to: &str, amount: i32, utxo: &UTXOSet) -> Result { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `new_utxo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/transaction.rs:133:26 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn verify(&self, prev_TXs: HashMap) -> Result { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_Tx` should have a snake case name [INFO] [stdout] --> src/transaction.rs:147:17 [INFO] [stdout] | [INFO] [stdout] 147 | let prev_Tx = prev_TXs.get(&self.vin[in_id].txid).unwrap(); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `prev_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_TXs` should have a snake case name [INFO] [stdout] --> src/transaction.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | prev_TXs: HashMap, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `prev_txs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev_Tx` should have a snake case name [INFO] [stdout] --> src/transaction.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | let prev_Tx = prev_TXs.get(&tx_copy.vin[in_id].txid).unwrap(); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `prev_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_UTXO` should have a snake case name [INFO] [stdout] --> src/utxoset.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn find_UTXO(&self, pub_key_hash: &[u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `find_utxo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn new(port: &str, miner_address: &str, utxo: UTXOSet) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let mut node_set = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | node_set.insert(String::from(KNOWN_NODE1)); [INFO] [stdout] 88 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | node_address: String::from("localhost:") + port, [INFO] [stdout] 90 | | mining_address: miner_address.to_string(), [INFO] [stdout] 91 | | inner: Arc::new(Mutex::new(ServerInner { [INFO] [stdout] ... | [INFO] [stdout] 96 | | })), [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-blockchain` (bin "rust-blockchain") due to 3 previous errors; 16 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rust-blockchain` (bin "rust-blockchain" test) due to 3 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c38e0ab31f7df011b5b0fa4ba5429448381c9d92d39bf16f0f6357ed3fe5e614", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c38e0ab31f7df011b5b0fa4ba5429448381c9d92d39bf16f0f6357ed3fe5e614", kill_on_drop: false }` [INFO] [stdout] c38e0ab31f7df011b5b0fa4ba5429448381c9d92d39bf16f0f6357ed3fe5e614