[INFO] cloning repository https://github.com/Javyre/ascworld [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Javyre/ascworld" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJavyre%2Fascworld", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJavyre%2Fascworld'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c201b52ca18fe76f0149fc9cc1e8f2868c52c4e5 [INFO] checking Javyre/ascworld/c201b52ca18fe76f0149fc9cc1e8f2868c52c4e5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJavyre%2Fascworld" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Javyre/ascworld on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Javyre/ascworld [INFO] finished tweaking git repo https://github.com/Javyre/ascworld [INFO] tweaked toml for git repo https://github.com/Javyre/ascworld written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Javyre/ascworld already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] af529cf0bedd5108431057145db19a1e4038bf4c109a5d577644f103238b8569 [INFO] running `Command { std: "docker" "start" "-a" "af529cf0bedd5108431057145db19a1e4038bf4c109a5d577644f103238b8569", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "af529cf0bedd5108431057145db19a1e4038bf4c109a5d577644f103238b8569", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af529cf0bedd5108431057145db19a1e4038bf4c109a5d577644f103238b8569", kill_on_drop: false }` [INFO] [stdout] af529cf0bedd5108431057145db19a1e4038bf4c109a5d577644f103238b8569 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cda93cf855f180025a47fd87f39b7d77b51f2afcea8a6545be32af3a9a66fef [INFO] running `Command { std: "docker" "start" "-a" "2cda93cf855f180025a47fd87f39b7d77b51f2afcea8a6545be32af3a9a66fef", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling matrixmultiply v0.1.14 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Compiling ndarray v0.11.2 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking ascworld-01 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ndarray::linalg::*` [INFO] [stdout] --> src/graphics/camera.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use ndarray::linalg::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Array1` and `Array` [INFO] [stdout] --> src/graphics/camera.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | Array, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | Array1, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ArrayBase` and `Array` [INFO] [stdout] --> src/graphics/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | Array, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 11 | ArrayBase, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ndarray::linalg::*` [INFO] [stdout] --> src/graphics/camera.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use ndarray::linalg::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Array1` and `Array` [INFO] [stdout] --> src/graphics/camera.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | Array, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | Array1, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ArrayBase` and `Array` [INFO] [stdout] --> src/graphics/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | Array, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 11 | ArrayBase, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/main.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 219 | return; [INFO] [stdout] | ------ any code following this expression is unreachable [INFO] [stdout] 220 | [INFO] [stdout] 221 | let cell_dims = (0.25, 0.5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | use std::io::{Write, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/graphics/mod.rs:105:36 [INFO] [stdout] | [INFO] [stdout] 105 | let tmin = self.map(|i, o, v, iv, ivs|{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/graphics/mod.rs:108:36 [INFO] [stdout] | [INFO] [stdout] 108 | let tmax = self.map(|i, o, v, iv, ivs|{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/graphics/mod.rs:595:46 [INFO] [stdout] | [INFO] [stdout] 595 | pub fn apply_to(&self, mut x: T) -> T { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/main.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 219 | return; [INFO] [stdout] | ------ any code following this expression is unreachable [INFO] [stdout] 220 | [INFO] [stdout] 221 | let cell_dims = (0.25, 0.5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | use std::io::{Write, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | let mut running = Arc::new(RwLock::new(true)); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dist` is never used [INFO] [stdout] --> src/graphics/mod.rs:394:8 [INFO] [stdout] | [INFO] [stdout] 394 | pub fn dist(r: &Ray3, p: &Point3) -> f64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `into_abs`, `as_rel`, `as_rel_mut`, and `abs_field` are never used [INFO] [stdout] --> src/graphics/mod.rs:619:12 [INFO] [stdout] | [INFO] [stdout] 618 | impl SelfRelative { [INFO] [stdout] | -------------------------------------- associated items in this implementation [INFO] [stdout] 619 | pub fn new(x: T) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 623 | pub fn into_abs(self) -> T { self.1.apply_to(self.0) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 624 | [INFO] [stdout] 625 | pub fn as_rel(&self) -> &T { &self.0 } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 626 | [INFO] [stdout] 627 | pub fn as_rel_mut(&mut self) -> &mut T { &mut self.0 } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 628 | [INFO] [stdout] 629 | pub fn abs_field R, R: Transformable>(&self, f: F) -> R { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `into_abs` and `abs_field` are never used [INFO] [stdout] --> src/graphics/mod.rs:658:12 [INFO] [stdout] | [INFO] [stdout] 653 | impl Relative { [INFO] [stdout] | ---------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 658 | pub fn into_abs(self) -> T { self.1.apply_to(self.0) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 664 | pub fn abs_field R, R: Transformable>(&self, f: F) -> R { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / write!(stdout, "{}{}{}{}\n\r", [INFO] [stdout] 109 | | cursor::Goto(1,1), [INFO] [stdout] 110 | | Fg(Rgb(200,200,55)), [INFO] [stdout] 111 | | (1000./(e.as_secs() as f64 *1000. [INFO] [stdout] 112 | | + e.subsec_millis() as f64)).to_string() + "fps", [INFO] [stdout] 113 | | clear::UntilNewline, [INFO] [stdout] 114 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:217:5 [INFO] [stdout] | [INFO] [stdout] 217 | event_loop.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 217 | let _ = event_loop.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 74 | fn map(&self, f: F) -> (R, R, R) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / f( [INFO] [stdout] 79 | | 0, [INFO] [stdout] 80 | | self.origin.unpack().0, [INFO] [stdout] 81 | | self.vec.unpack().0, [INFO] [stdout] 82 | | self.inv_vec.0, [INFO] [stdout] 83 | | self.inv_vec_sign.0, [INFO] [stdout] 84 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 74 | fn map(&self, f: F) -> (R, R, R) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | / f( [INFO] [stdout] 86 | | 1, [INFO] [stdout] 87 | | self.origin.unpack().1, [INFO] [stdout] 88 | | self.vec.unpack().1, [INFO] [stdout] 89 | | self.inv_vec.1, [INFO] [stdout] 90 | | self.inv_vec_sign.1, [INFO] [stdout] 91 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 74 | fn map(&self, f: F) -> (R, R, R) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / f( [INFO] [stdout] 93 | | 2, [INFO] [stdout] 94 | | self.origin.unpack().2, [INFO] [stdout] 95 | | self.vec.unpack().2, [INFO] [stdout] 96 | | self.inv_vec.2, [INFO] [stdout] 97 | | self.inv_vec_sign.2, [INFO] [stdout] 98 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayO` should have a snake case name [INFO] [stdout] --> src/graphics/mod.rs:522:36 [INFO] [stdout] | [INFO] [stdout] 522 | let Ray3 { origin: rayO, vec: rayV, .. } = ray; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `ray_o` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayV` should have a snake case name [INFO] [stdout] --> src/graphics/mod.rs:522:47 [INFO] [stdout] | [INFO] [stdout] 522 | let Ray3 { origin: rayO, vec: rayV, .. } = ray; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `ray_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayV` should have a snake case name [INFO] [stdout] --> src/graphics/mod.rs:523:21 [INFO] [stdout] | [INFO] [stdout] 523 | let rayV: Point3 = rayV.clone().into(); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `ray_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:596:9 [INFO] [stdout] | [INFO] [stdout] 595 | pub fn apply_to(&self, mut x: T) -> T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 596 | self.0.borrow().apply_to(x) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:630:25 [INFO] [stdout] | [INFO] [stdout] 629 | pub fn abs_field R, R: Transformable>(&self, f: F) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 630 | self.1.apply_to(f(self.as_rel())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:665:25 [INFO] [stdout] | [INFO] [stdout] 664 | pub fn abs_field R, R: Transformable>(&self, f: F) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 665 | self.1.apply_to(f(self.as_rel())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/graphics/mod.rs:105:36 [INFO] [stdout] | [INFO] [stdout] 105 | let tmin = self.map(|i, o, v, iv, ivs|{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/graphics/mod.rs:108:36 [INFO] [stdout] | [INFO] [stdout] 108 | let tmax = self.map(|i, o, v, iv, ivs|{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ascworld-01` (bin "ascworld-01") due to 7 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/graphics/mod.rs:595:46 [INFO] [stdout] | [INFO] [stdout] 595 | pub fn apply_to(&self, mut x: T) -> T { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | let mut running = Arc::new(RwLock::new(true)); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dist` is never used [INFO] [stdout] --> src/graphics/mod.rs:394:8 [INFO] [stdout] | [INFO] [stdout] 394 | pub fn dist(r: &Ray3, p: &Point3) -> f64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `into_abs`, `as_rel`, `as_rel_mut`, and `abs_field` are never used [INFO] [stdout] --> src/graphics/mod.rs:619:12 [INFO] [stdout] | [INFO] [stdout] 618 | impl SelfRelative { [INFO] [stdout] | -------------------------------------- associated items in this implementation [INFO] [stdout] 619 | pub fn new(x: T) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 623 | pub fn into_abs(self) -> T { self.1.apply_to(self.0) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 624 | [INFO] [stdout] 625 | pub fn as_rel(&self) -> &T { &self.0 } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 626 | [INFO] [stdout] 627 | pub fn as_rel_mut(&mut self) -> &mut T { &mut self.0 } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 628 | [INFO] [stdout] 629 | pub fn abs_field R, R: Transformable>(&self, f: F) -> R { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `into_abs` and `abs_field` are never used [INFO] [stdout] --> src/graphics/mod.rs:658:12 [INFO] [stdout] | [INFO] [stdout] 653 | impl Relative { [INFO] [stdout] | ---------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 658 | pub fn into_abs(self) -> T { self.1.apply_to(self.0) } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 664 | pub fn abs_field R, R: Transformable>(&self, f: F) -> R { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / write!(stdout, "{}{}{}{}\n\r", [INFO] [stdout] 109 | | cursor::Goto(1,1), [INFO] [stdout] 110 | | Fg(Rgb(200,200,55)), [INFO] [stdout] 111 | | (1000./(e.as_secs() as f64 *1000. [INFO] [stdout] 112 | | + e.subsec_millis() as f64)).to_string() + "fps", [INFO] [stdout] 113 | | clear::UntilNewline, [INFO] [stdout] 114 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:217:5 [INFO] [stdout] | [INFO] [stdout] 217 | event_loop.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 217 | let _ = event_loop.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 74 | fn map(&self, f: F) -> (R, R, R) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / f( [INFO] [stdout] 79 | | 0, [INFO] [stdout] 80 | | self.origin.unpack().0, [INFO] [stdout] 81 | | self.vec.unpack().0, [INFO] [stdout] 82 | | self.inv_vec.0, [INFO] [stdout] 83 | | self.inv_vec_sign.0, [INFO] [stdout] 84 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 74 | fn map(&self, f: F) -> (R, R, R) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | / f( [INFO] [stdout] 86 | | 1, [INFO] [stdout] 87 | | self.origin.unpack().1, [INFO] [stdout] 88 | | self.vec.unpack().1, [INFO] [stdout] 89 | | self.inv_vec.1, [INFO] [stdout] 90 | | self.inv_vec_sign.1, [INFO] [stdout] 91 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 74 | fn map(&self, f: F) -> (R, R, R) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / f( [INFO] [stdout] 93 | | 2, [INFO] [stdout] 94 | | self.origin.unpack().2, [INFO] [stdout] 95 | | self.vec.unpack().2, [INFO] [stdout] 96 | | self.inv_vec.2, [INFO] [stdout] 97 | | self.inv_vec_sign.2, [INFO] [stdout] 98 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayO` should have a snake case name [INFO] [stdout] --> src/graphics/mod.rs:522:36 [INFO] [stdout] | [INFO] [stdout] 522 | let Ray3 { origin: rayO, vec: rayV, .. } = ray; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `ray_o` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayV` should have a snake case name [INFO] [stdout] --> src/graphics/mod.rs:522:47 [INFO] [stdout] | [INFO] [stdout] 522 | let Ray3 { origin: rayO, vec: rayV, .. } = ray; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `ray_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `rayV` should have a snake case name [INFO] [stdout] --> src/graphics/mod.rs:523:21 [INFO] [stdout] | [INFO] [stdout] 523 | let rayV: Point3 = rayV.clone().into(); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `ray_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:596:9 [INFO] [stdout] | [INFO] [stdout] 595 | pub fn apply_to(&self, mut x: T) -> T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 596 | self.0.borrow().apply_to(x) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:630:25 [INFO] [stdout] | [INFO] [stdout] 629 | pub fn abs_field R, R: Transformable>(&self, f: F) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 630 | self.1.apply_to(f(self.as_rel())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/mod.rs:665:25 [INFO] [stdout] | [INFO] [stdout] 664 | pub fn abs_field R, R: Transformable>(&self, f: F) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 665 | self.1.apply_to(f(self.as_rel())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ascworld-01` (bin "ascworld-01" test) due to 7 previous errors; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2cda93cf855f180025a47fd87f39b7d77b51f2afcea8a6545be32af3a9a66fef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cda93cf855f180025a47fd87f39b7d77b51f2afcea8a6545be32af3a9a66fef", kill_on_drop: false }` [INFO] [stdout] 2cda93cf855f180025a47fd87f39b7d77b51f2afcea8a6545be32af3a9a66fef