[INFO] cloning repository https://github.com/JasonVranek/Flowrs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JasonVranek/Flowrs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJasonVranek%2FFlowrs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJasonVranek%2FFlowrs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3efff655fa0e86b9251feeb6991b1f7aba220d8a [INFO] checking JasonVranek/Flowrs/3efff655fa0e86b9251feeb6991b1f7aba220d8a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJasonVranek%2FFlowrs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JasonVranek/Flowrs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JasonVranek/Flowrs [INFO] finished tweaking git repo https://github.com/JasonVranek/Flowrs [INFO] tweaked toml for git repo https://github.com/JasonVranek/Flowrs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 124 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding env_logger v0.6.2 (latest: v0.11.5) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding sha1 v0.6.1 (latest: v0.10.6) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding tokio-serde v0.3.0 (latest: v0.9.0) [INFO] [stderr] Adding tokio-serde-json v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding ws v0.7.9 (latest: v0.9.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a890ae75cdd9e9567a0459a394cd34a317a9de35841e7de27b1936f848dfa72d [INFO] running `Command { std: "docker" "start" "-a" "a890ae75cdd9e9567a0459a394cd34a317a9de35841e7de27b1936f848dfa72d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a890ae75cdd9e9567a0459a394cd34a317a9de35841e7de27b1936f848dfa72d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a890ae75cdd9e9567a0459a394cd34a317a9de35841e7de27b1936f848dfa72d", kill_on_drop: false }` [INFO] [stdout] a890ae75cdd9e9567a0459a394cd34a317a9de35841e7de27b1936f848dfa72d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 398864629a4271f206baa3697e23f42c7b82151138284e839f720f0634cd0c2c [INFO] running `Command { std: "docker" "start" "-a" "398864629a4271f206baa3697e23f42c7b82151138284e839f720f0634cd0c2c", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-serde v0.3.0 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking ws v0.7.9 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking tokio-serde-json v0.2.0 [INFO] [stderr] Checking flow_rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/order/mod.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | type CustClosure = Box f64 + Send + Sync + 'static>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1 | type CustClosure = Box f64 + Send + Sync + 'static>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/controller/mod.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | pub type AsyncTask = Box + Send>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | pub type AsyncTask = Box + Send>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/order/mod.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | type CustClosure = Box f64 + Send + Sync + 'static>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1 | type CustClosure = Box f64 + Send + Sync + 'static>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/controller/mod.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | pub type AsyncTask = Box + Send>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | pub type AsyncTask = Box + Send>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 23 | let queue = Arc::new(Queue::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let bids_book = Arc::new(Book::new(TradeType::Bid)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let asks_book = Arc::new(Book::new(TradeType::Ask)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | (queue, bids_book, asks_book, Arc::new(Mutex::new(State::Process))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/tcp_json.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn tcp_listener(queue: Arc, address: String) -> Task { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let listener = TcpListener::bind(&addr).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let tcp_server = listener.incoming().for_each(move |socket| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | task: Box::new(tcp_server), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/tcp_json.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 49 | let client = TcpStream::connect(&addr).and_then(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | task: Box::new(client), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/tcp_json.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 49 | let client = TcpStream::connect(&addr).and_then(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | // Make a new json writer [INFO] [stdout] 51 | let serialized = JsonOrder::serializer(socket); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / serialized [INFO] [stdout] 55 | | .send(json).map(|_| ()) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/ws_json.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn ws_listener(queue: Arc, addr: &'static str) -> thread::JoinHandle<()> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | env_logger::init(); [INFO] [stdout] 43 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 44 | | listen(addr, |out| { [INFO] [stdout] 45 | | Server { [INFO] [stdout] 46 | | out: out, [INFO] [stdout] ... | [INFO] [stdout] 49 | | }).expect("Error with WS Server..."); [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/ws_json.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 44 | listen(addr, |out| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | queue: Arc::clone(&queue), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/auction.rs:85:18 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn async_auction_task(bids: Arc, asks: Arc, state: Arc>, duration: u64) -> Task { [INFO] [stdout] | --------------- --------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 86 | | { [INFO] [stdout] 87 | | // Obtain lock on the global state and switch to Auction mode, will stop [INFO] [stdout] 88 | | // the queue from being processed. [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] 104 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/order_processing.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn conc_recv_order(order: Order, queue: Arc) -> JoinHandle<()> { [INFO] [stdout] | ------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 27 | | // The add function acquires the lock [INFO] [stdout] 28 | | queue.add(order); [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/order_processing.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 105 | let func = match tt { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Some(Order::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 111 | | typed_json.trader_id, [INFO] [stdout] 112 | | ot, [INFO] [stdout] 113 | | tt, [INFO] [stdout] ... | [INFO] [stdout] 117 | | func, [INFO] [stdout] 118 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue.rs:35:3 [INFO] [stdout] | [INFO] [stdout] 33 | let mut items = self.items.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | // Pop all items out of the queue and return the contents as a vec [INFO] [stdout] 35 | items.drain(..).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 50 | fn process_enter(order: Order, book: Arc) -> JoinHandle<()> { [INFO] [stdout] | ------------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | // Spawn a new thread to process the order [INFO] [stdout] 52 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 53 | | // add_order acquires the lock on the book before mutating [INFO] [stdout] 54 | | book.update_max_price(&order.p_high); [INFO] [stdout] 55 | | book.update_min_price(&order.p_low); [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 50 | fn process_enter(order: Order, book: Arc) -> JoinHandle<()> { [INFO] [stdout] | ----- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match book.add_order(order) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 67 | fn process_update(order: Order, book: Arc) -> JoinHandle<()> { [INFO] [stdout] | ------------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | // update books min/max price if this overwrites current min/max OR this order contains new min/max [INFO] [stdout] 69 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 70 | | let p_high = order.p_high.clone(); [INFO] [stdout] 71 | | let p_low = order.p_low.clone(); [INFO] [stdout] 72 | | // If the order is not found, bubble error up [INFO] [stdout] ... | [INFO] [stdout] 100 | | [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:106:20 [INFO] [stdout] | [INFO] [stdout] 105 | fn process_cancel(order: Order, book: Arc) -> JoinHandle<()> { [INFO] [stdout] | ------------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 107 | | let p_high = order.p_high.clone(); [INFO] [stdout] 108 | | let p_low = order.p_low.clone(); [INFO] [stdout] ... | [INFO] [stdout] 127 | | [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn async_queue_task(queue: Arc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | bids: Arc, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | asks: Arc, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | state: Arc>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 138 | | match *state.lock().expect("Couldn't lock state in queue task") { [INFO] [stdout] 139 | | State::Process => { [INFO] [stdout] 140 | | let handles = QueueProcessor::conc_process_order_queue(Arc::clone(&queue), [INFO] [stdout] ... | [INFO] [stdout] 151 | | } [INFO] [stdout] 152 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn async_queue_task(queue: Arc, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | bids: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | asks: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | state: Arc>, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | match *state.lock().expect("Couldn't lock state in queue task") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn tcp_arrival_interval(traders: Arc, duration: u64, address: String) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 20 | | // Make new random orders [INFO] [stdout] 21 | | let orders: Vec = trader_behavior::rand_enters(10); [INFO] [stdout] 22 | | println!("{} new arrivals!", orders.len()); [INFO] [stdout] ... | [INFO] [stdout] 34 | | println!("num_traders: {}", traders.num_traders()); [INFO] [stdout] 35 | | }, duration) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn tcp_update_interval(traders: Arc, duration: u64, address: String) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 41 | | let rng_upper = 10; [INFO] [stdout] 42 | | let update_orders = trader_behavior::gen_rand_updates(Arc::clone(&traders), rng_upper); [INFO] [stdout] 43 | | println!("updating {} traders", update_orders.len()); [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn tcp_cancel_interval(traders: Arc, duration: u64, address: String) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 55 | | println!("cancel trader!"); [INFO] [stdout] 56 | | let rng_upper = 10; [INFO] [stdout] 57 | | let cancel_orders = trader_behavior::gen_rand_cancels(Arc::clone(&traders), rng_upper); [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn ws_arrival_interval(traders: Arc, duration: u64, address: &'static str) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 77 | | // Make new random orders [INFO] [stdout] 78 | | let orders: Vec = trader_behavior::rand_enters(10); [INFO] [stdout] 79 | | println!("{} new arrivals!", orders.len()); [INFO] [stdout] ... | [INFO] [stdout] 93 | | println!("num_traders: {}", traders.num_traders()); [INFO] [stdout] 94 | | }, duration) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/simulation/random_behavior.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 83 | let addr = address.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:99:18 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn ws_update_interval(traders: Arc, duration: u64, address: &'static str) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 100 | | let rng_upper = 10; [INFO] [stdout] 101 | | let update_orders = trader_behavior::gen_rand_updates(Arc::clone(&traders), rng_upper); [INFO] [stdout] 102 | | println!("updating {} traders", update_orders.len()); [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/simulation/random_behavior.rs:104:32 [INFO] [stdout] | [INFO] [stdout] 104 | let addr = address.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:117:18 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn ws_cancel_interval(traders: Arc, duration: u64, address: &'static str) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 118 | | println!("cancel trader!"); [INFO] [stdout] 119 | | let rng_upper = 10; [INFO] [stdout] 120 | | let cancel_orders = trader_behavior::gen_rand_cancels(Arc::clone(&traders), rng_upper); [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/simulation/random_behavior.rs:124:35 [INFO] [stdout] | [INFO] [stdout] 124 | let addr = address.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/simulation/random_behavior.rs:127:33 [INFO] [stdout] | [INFO] [stdout] 127 | let addr = addr.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:52:10 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(f: F) -> Task [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | task: Box::new(future::lazy(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 53 | | f(); [INFO] [stdout] 54 | | future::ok(()) [INFO] [stdout] 55 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn delay_task(f: F, millis: u64) -> Task [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let new_task = Delay::new(when) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | task: Box::new(new_task) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn rpt_task(f: F, millis: u64) -> Task [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let new_task = Interval::new_interval(Duration::from_millis(millis)) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | task: Box::new(new_task) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:103:10 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn after_delay(self, millis: u64) -> Task { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let when = Instant::now() + Duration::from_millis(millis); [INFO] [stdout] 95 | let new_task = Delay::new(when) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | task: Box::new(new_task) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flow_rs` (lib) due to 27 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 23 | let queue = Arc::new(Queue::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let bids_book = Arc::new(Book::new(TradeType::Bid)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let asks_book = Arc::new(Book::new(TradeType::Ask)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | (queue, bids_book, asks_book, Arc::new(Mutex::new(State::Process))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/tcp_json.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn tcp_listener(queue: Arc, address: String) -> Task { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let listener = TcpListener::bind(&addr).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let tcp_server = listener.incoming().for_each(move |socket| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | task: Box::new(tcp_server), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/tcp_json.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 49 | let client = TcpStream::connect(&addr).and_then(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | task: Box::new(client), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/tcp_json.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 49 | let client = TcpStream::connect(&addr).and_then(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | // Make a new json writer [INFO] [stdout] 51 | let serialized = JsonOrder::serializer(socket); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / serialized [INFO] [stdout] 55 | | .send(json).map(|_| ()) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/ws_json.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn ws_listener(queue: Arc, addr: &'static str) -> thread::JoinHandle<()> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | env_logger::init(); [INFO] [stdout] 43 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 44 | | listen(addr, |out| { [INFO] [stdout] 45 | | Server { [INFO] [stdout] 46 | | out: out, [INFO] [stdout] ... | [INFO] [stdout] 49 | | }).expect("Error with WS Server..."); [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/ws_json.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 44 | listen(addr, |out| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | queue: Arc::clone(&queue), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/auction.rs:85:18 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn async_auction_task(bids: Arc, asks: Arc, state: Arc>, duration: u64) -> Task { [INFO] [stdout] | --------------- --------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 86 | | { [INFO] [stdout] 87 | | // Obtain lock on the global state and switch to Auction mode, will stop [INFO] [stdout] 88 | | // the queue from being processed. [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] 104 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/order_processing.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn conc_recv_order(order: Order, queue: Arc) -> JoinHandle<()> { [INFO] [stdout] | ------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 27 | | // The add function acquires the lock [INFO] [stdout] 28 | | queue.add(order); [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/order_processing.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 105 | let func = match tt { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Some(Order::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 111 | | typed_json.trader_id, [INFO] [stdout] 112 | | ot, [INFO] [stdout] 113 | | tt, [INFO] [stdout] ... | [INFO] [stdout] 117 | | func, [INFO] [stdout] 118 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue.rs:35:3 [INFO] [stdout] | [INFO] [stdout] 33 | let mut items = self.items.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | // Pop all items out of the queue and return the contents as a vec [INFO] [stdout] 35 | items.drain(..).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 50 | fn process_enter(order: Order, book: Arc) -> JoinHandle<()> { [INFO] [stdout] | ------------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | // Spawn a new thread to process the order [INFO] [stdout] 52 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 53 | | // add_order acquires the lock on the book before mutating [INFO] [stdout] 54 | | book.update_max_price(&order.p_high); [INFO] [stdout] 55 | | book.update_min_price(&order.p_low); [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 50 | fn process_enter(order: Order, book: Arc) -> JoinHandle<()> { [INFO] [stdout] | ----- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match book.add_order(order) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 67 | fn process_update(order: Order, book: Arc) -> JoinHandle<()> { [INFO] [stdout] | ------------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | // update books min/max price if this overwrites current min/max OR this order contains new min/max [INFO] [stdout] 69 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 70 | | let p_high = order.p_high.clone(); [INFO] [stdout] 71 | | let p_low = order.p_low.clone(); [INFO] [stdout] 72 | | // If the order is not found, bubble error up [INFO] [stdout] ... | [INFO] [stdout] 100 | | [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:106:20 [INFO] [stdout] | [INFO] [stdout] 105 | fn process_cancel(order: Order, book: Arc) -> JoinHandle<()> { [INFO] [stdout] | ------------ --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 107 | | let p_high = order.p_high.clone(); [INFO] [stdout] 108 | | let p_low = order.p_low.clone(); [INFO] [stdout] ... | [INFO] [stdout] 127 | | [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn async_queue_task(queue: Arc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | bids: Arc, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | asks: Arc, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | state: Arc>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 138 | | match *state.lock().expect("Couldn't lock state in queue task") { [INFO] [stdout] 139 | | State::Process => { [INFO] [stdout] 140 | | let handles = QueueProcessor::conc_process_order_queue(Arc::clone(&queue), [INFO] [stdout] ... | [INFO] [stdout] 151 | | } [INFO] [stdout] 152 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exchange/queue_processing.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn async_queue_task(queue: Arc, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | bids: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | asks: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | state: Arc>, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | match *state.lock().expect("Couldn't lock state in queue task") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn tcp_arrival_interval(traders: Arc, duration: u64, address: String) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 20 | | // Make new random orders [INFO] [stdout] 21 | | let orders: Vec = trader_behavior::rand_enters(10); [INFO] [stdout] 22 | | println!("{} new arrivals!", orders.len()); [INFO] [stdout] ... | [INFO] [stdout] 34 | | println!("num_traders: {}", traders.num_traders()); [INFO] [stdout] 35 | | }, duration) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn tcp_update_interval(traders: Arc, duration: u64, address: String) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 41 | | let rng_upper = 10; [INFO] [stdout] 42 | | let update_orders = trader_behavior::gen_rand_updates(Arc::clone(&traders), rng_upper); [INFO] [stdout] 43 | | println!("updating {} traders", update_orders.len()); [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn tcp_cancel_interval(traders: Arc, duration: u64, address: String) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 55 | | println!("cancel trader!"); [INFO] [stdout] 56 | | let rng_upper = 10; [INFO] [stdout] 57 | | let cancel_orders = trader_behavior::gen_rand_cancels(Arc::clone(&traders), rng_upper); [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn ws_arrival_interval(traders: Arc, duration: u64, address: &'static str) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 77 | | // Make new random orders [INFO] [stdout] 78 | | let orders: Vec = trader_behavior::rand_enters(10); [INFO] [stdout] 79 | | println!("{} new arrivals!", orders.len()); [INFO] [stdout] ... | [INFO] [stdout] 93 | | println!("num_traders: {}", traders.num_traders()); [INFO] [stdout] 94 | | }, duration) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/simulation/random_behavior.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 83 | let addr = address.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:99:18 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn ws_update_interval(traders: Arc, duration: u64, address: &'static str) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 100 | | let rng_upper = 10; [INFO] [stdout] 101 | | let update_orders = trader_behavior::gen_rand_updates(Arc::clone(&traders), rng_upper); [INFO] [stdout] 102 | | println!("updating {} traders", update_orders.len()); [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/simulation/random_behavior.rs:104:32 [INFO] [stdout] | [INFO] [stdout] 104 | let addr = address.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulation/random_behavior.rs:117:18 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn ws_cancel_interval(traders: Arc, duration: u64, address: &'static str) -> Task { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Task::rpt_task(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 118 | | println!("cancel trader!"); [INFO] [stdout] 119 | | let rng_upper = 10; [INFO] [stdout] 120 | | let cancel_orders = trader_behavior::gen_rand_cancels(Arc::clone(&traders), rng_upper); [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | }, duration) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/simulation/random_behavior.rs:124:35 [INFO] [stdout] | [INFO] [stdout] 124 | let addr = address.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/simulation/random_behavior.rs:127:33 [INFO] [stdout] | [INFO] [stdout] 127 | let addr = addr.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:52:10 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(f: F) -> Task [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | task: Box::new(future::lazy(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 53 | | f(); [INFO] [stdout] 54 | | future::ok(()) [INFO] [stdout] 55 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn delay_task(f: F, millis: u64) -> Task [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let new_task = Delay::new(when) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | task: Box::new(new_task) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn rpt_task(f: F, millis: u64) -> Task [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let new_task = Interval::new_interval(Duration::from_millis(millis)) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | task: Box::new(new_task) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:103:10 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn after_delay(self, millis: u64) -> Task { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let when = Instant::now() + Duration::from_millis(millis); [INFO] [stdout] 95 | let new_task = Delay::new(when) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | task: Box::new(new_task) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flow_rs` (lib test) due to 27 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "398864629a4271f206baa3697e23f42c7b82151138284e839f720f0634cd0c2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "398864629a4271f206baa3697e23f42c7b82151138284e839f720f0634cd0c2c", kill_on_drop: false }` [INFO] [stdout] 398864629a4271f206baa3697e23f42c7b82151138284e839f720f0634cd0c2c