[INFO] updating cached repository https://github.com/JarrettBillingsley/adi [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4527ee502f26298bb681bbe8fbca6801a7e3790a [INFO] checking JarrettBillingsley/adi/4527ee502f26298bb681bbe8fbca6801a7e3790a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJarrettBillingsley%2Fadi" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JarrettBillingsley/adi on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JarrettBillingsley/adi [INFO] finished tweaking git repo https://github.com/JarrettBillingsley/adi [INFO] tweaked toml for git repo https://github.com/JarrettBillingsley/adi written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JarrettBillingsley/adi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e5b90e53a6717c6baeae6e43f7d563022a392b984eeed095350803931aac290 [INFO] running `Command { std: "docker" "start" "-a" "0e5b90e53a6717c6baeae6e43f7d563022a392b984eeed095350803931aac290", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e5b90e53a6717c6baeae6e43f7d563022a392b984eeed095350803931aac290", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e5b90e53a6717c6baeae6e43f7d563022a392b984eeed095350803931aac290", kill_on_drop: false }` [INFO] [stdout] 0e5b90e53a6717c6baeae6e43f7d563022a392b984eeed095350803931aac290 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc8c567d3ae522e19e18d76d6fe08352e1784db1ac4e4ebf1ca95f97723970ad [INFO] running `Command { std: "docker" "start" "-a" "cc8c567d3ae522e19e18d76d6fe08352e1784db1ac4e4ebf1ca95f97723970ad", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling syn v1.0.38 [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling rustversion v1.0.3 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Compiling aho-corasick v0.7.13 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking gimli v0.23.0 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking termios v0.3.3 [INFO] [stderr] Checking object v0.22.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking rustc-demangle v0.1.18 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling once_cell v1.5.2 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking fixedbitset v0.4.0 [INFO] [stderr] Checking petgraph v0.6.0 [INFO] [stderr] Checking simplelog v0.9.0 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking generational-arena v0.2.8 [INFO] [stderr] Checking console v0.9.2 [INFO] [stderr] Checking addr2line v0.14.0 [INFO] [stderr] Checking smallvec v1.5.1 [INFO] [stderr] Checking backtrace v0.3.55 [INFO] [stderr] Checking better-panic v0.2.0 [INFO] [stderr] Checking nes_rom v0.1.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling parse-display-derive v0.1.2 [INFO] [stderr] Compiling enum_dispatch v0.3.4 [INFO] [stderr] Compiling delegate v0.5.0 [INFO] [stderr] Compiling err-derive v0.2.4 [INFO] [stderr] Checking parse-display v0.1.2 [INFO] [stderr] Checking adi v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ir/constprop.rs:66:2 [INFO] [stdout] | [INFO] [stdout] 65 | fn new_state(regs: impl Iterator) -> State { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | regs.map(|r| (r, Info::Unk)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory/segment.rs:282:20 [INFO] [stdout] | [INFO] [stdout] 281 | fn image_slice(&self, range: impl RangeBounds) -> ImageSlice { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | self.image_slice(self.offset_bounds_from_ea_bounds(range)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program.rs:521:11 [INFO] [stdout] | [INFO] [stdout] 516 | fn new(func: &'f Function, cfg: CfgGraph) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 521 | preds: LazyCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program/data.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn rccell(t: T) -> RcCell { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Rc::new(RefCell::new(t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program/data.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new_item(&mut self, name: Option, ea: EA, ty: Type, size: usize) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | DataId(self.arena.insert_with(move |id| { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 92 | | DataItem::new(DataId(id), name, ea, ty, size) [INFO] [stdout] 93 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program/data.rs:233:15 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn array(ty: Type, len: usize) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | assert!(ty.size().is_fixed(), "arrays can only hold fixed-size values"); [INFO] [stdout] 233 | Self::Array(ArrayType { ty: Box::new(ty), len }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program/data.rs:239:13 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn ptr(to: Type, kind: Type) -> Self { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | assert!(kind.is_strict_integer(), "pointers can only be integers"); [INFO] [stdout] 239 | Self::Ptr(PtrType { to: Box::new(to), kind: Box::new(kind) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adi` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ir/constprop.rs:66:2 [INFO] [stdout] | [INFO] [stdout] 65 | fn new_state(regs: impl Iterator) -> State { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | regs.map(|r| (r, Info::Unk)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory/segment.rs:282:20 [INFO] [stdout] | [INFO] [stdout] 281 | fn image_slice(&self, range: impl RangeBounds) -> ImageSlice { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | self.image_slice(self.offset_bounds_from_ea_bounds(range)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program.rs:521:11 [INFO] [stdout] | [INFO] [stdout] 516 | fn new(func: &'f Function, cfg: CfgGraph) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 521 | preds: LazyCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program/data.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn rccell(t: T) -> RcCell { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Rc::new(RefCell::new(t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program/data.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new_item(&mut self, name: Option, ea: EA, ty: Type, size: usize) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | DataId(self.arena.insert_with(move |id| { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 92 | | DataItem::new(DataId(id), name, ea, ty, size) [INFO] [stdout] 93 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program/data.rs:233:15 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn array(ty: Type, len: usize) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | assert!(ty.size().is_fixed(), "arrays can only hold fixed-size values"); [INFO] [stdout] 233 | Self::Array(ArrayType { ty: Box::new(ty), len }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program/data.rs:239:13 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn ptr(to: Type, kind: Type) -> Self { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | assert!(kind.is_strict_integer(), "pointers can only be integers"); [INFO] [stdout] 239 | Self::Ptr(PtrType { to: Box::new(to), kind: Box::new(kind) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adi` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "cc8c567d3ae522e19e18d76d6fe08352e1784db1ac4e4ebf1ca95f97723970ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc8c567d3ae522e19e18d76d6fe08352e1784db1ac4e4ebf1ca95f97723970ad", kill_on_drop: false }` [INFO] [stdout] cc8c567d3ae522e19e18d76d6fe08352e1784db1ac4e4ebf1ca95f97723970ad