[INFO] cloning repository https://github.com/Jarcho/clippy_lint_test [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jarcho/clippy_lint_test" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJarcho%2Fclippy_lint_test", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJarcho%2Fclippy_lint_test'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0541c09ad7158e1142bfb46c84325c1f4a5ad00e [INFO] checking Jarcho/clippy_lint_test/0541c09ad7158e1142bfb46c84325c1f4a5ad00e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJarcho%2Fclippy_lint_test" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Jarcho/clippy_lint_test on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Jarcho/clippy_lint_test [INFO] finished tweaking git repo https://github.com/Jarcho/clippy_lint_test [INFO] tweaked toml for git repo https://github.com/Jarcho/clippy_lint_test written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Jarcho/clippy_lint_test already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2842ea0de1edbfba01adf33964a0eedc2a600b286abefcc676fe45ec72244a6f [INFO] running `Command { std: "docker" "start" "-a" "2842ea0de1edbfba01adf33964a0eedc2a600b286abefcc676fe45ec72244a6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2842ea0de1edbfba01adf33964a0eedc2a600b286abefcc676fe45ec72244a6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2842ea0de1edbfba01adf33964a0eedc2a600b286abefcc676fe45ec72244a6f", kill_on_drop: false }` [INFO] [stdout] 2842ea0de1edbfba01adf33964a0eedc2a600b286abefcc676fe45ec72244a6f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4af404979b5d4b35a781fe3ec2789b3b62e8d084d9e7ea5669020d0074268c92 [INFO] running `Command { std: "docker" "start" "-a" "4af404979b5d4b35a781fe3ec2789b3b62e8d084d9e7ea5669020d0074268c92", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.42 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling serde_derive v1.0.140 [INFO] [stderr] Compiling serde v1.0.140 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Compiling semver v1.0.12 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Compiling camino v1.0.9 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling argh_shared v0.1.8 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking temp-dir v0.1.11 [INFO] [stderr] Checking home v0.5.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking filetime v0.2.17 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking xattr v0.2.3 [INFO] [stderr] Checking tar v0.4.38 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling psm v0.1.20 [INFO] [stderr] Compiling stacker v0.1.15 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking rm_rf v0.6.2 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling argh_derive v0.1.8 [INFO] [stderr] Checking argh v0.1.8 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki-roots v0.22.4 [INFO] [stderr] Checking ureq v2.5.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking cargo-platform v0.1.2 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking cargo_metadata v0.15.0 [INFO] [stderr] Checking clippy_lint_test v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/download_crates.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | .map(move |v| v.iter_ids(name).map(move |id| (i, id))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/download_crates.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 143 | let mut csv = ReaderBuilder::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / csv.into_records() [INFO] [stdout] 151 | | .filter_map(|r| { [INFO] [stdout] 152 | | let r = r.expect("error reading record"); [INFO] [stdout] 153 | | let data = extract_indicies(&r, indicies); [INFO] [stdout] ... | [INFO] [stdout] 164 | | }) [INFO] [stdout] 165 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/download_crates.rs:66:31 [INFO] [stdout] | [INFO] [stdout] 66 | .map(move |v| v.iter_ids(name).map(move |id| (i, id))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/download_crates.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 143 | let mut csv = ReaderBuilder::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / csv.into_records() [INFO] [stdout] 151 | | .filter_map(|r| { [INFO] [stdout] 152 | | let r = r.expect("error reading record"); [INFO] [stdout] 153 | | let data = extract_indicies(&r, indicies); [INFO] [stdout] ... | [INFO] [stdout] 164 | | }) [INFO] [stdout] 165 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clippy_lint_test` (bin "download_crates" test) due to 3 previous errors [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `clippy_lint_test` (bin "download_crates") due to 3 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:528:5 [INFO] [stdout] | [INFO] [stdout] 524 | let mut archive = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 528 | / archive [INFO] [stdout] 529 | | .unpack(target) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:528:5 [INFO] [stdout] | [INFO] [stdout] 524 | let mut archive = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 528 | / archive [INFO] [stdout] 529 | | .unpack(target) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clippy_lint_test` (bin "clippy_lint_test" test) due to 2 previous errors [INFO] [stderr] error: could not compile `clippy_lint_test` (bin "clippy_lint_test") due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "4af404979b5d4b35a781fe3ec2789b3b62e8d084d9e7ea5669020d0074268c92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4af404979b5d4b35a781fe3ec2789b3b62e8d084d9e7ea5669020d0074268c92", kill_on_drop: false }` [INFO] [stdout] 4af404979b5d4b35a781fe3ec2789b3b62e8d084d9e7ea5669020d0074268c92