[INFO] cloning repository https://github.com/JaniM/stgolf [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JaniM/stgolf" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaniM%2Fstgolf", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaniM%2Fstgolf'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eeb1befec89351206020255731d0ad4344a593a4 [INFO] checking JaniM/stgolf/eeb1befec89351206020255731d0ad4344a593a4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaniM%2Fstgolf" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JaniM/stgolf on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JaniM/stgolf [INFO] finished tweaking git repo https://github.com/JaniM/stgolf [INFO] tweaked toml for git repo https://github.com/JaniM/stgolf written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JaniM/stgolf already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 112f8d1357181b5b65d2e41ab2b94bb64f2e60bacb970ffe8ba55bcea78b31ab [INFO] running `Command { std: "docker" "start" "-a" "112f8d1357181b5b65d2e41ab2b94bb64f2e60bacb970ffe8ba55bcea78b31ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "112f8d1357181b5b65d2e41ab2b94bb64f2e60bacb970ffe8ba55bcea78b31ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "112f8d1357181b5b65d2e41ab2b94bb64f2e60bacb970ffe8ba55bcea78b31ab", kill_on_drop: false }` [INFO] [stdout] 112f8d1357181b5b65d2e41ab2b94bb64f2e60bacb970ffe8ba55bcea78b31ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 394dc561af385f44bdaf2b13263caf9cd96a23c168fae72bf83282cd2f72eb85 [INFO] running `Command { std: "docker" "start" "-a" "394dc561af385f44bdaf2b13263caf9cd96a23c168fae72bf83282cd2f72eb85", kill_on_drop: false }` [INFO] [stderr] Compiling syn v0.15.40 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Checking stgolf v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `slice_patterns` has been stable since 1.42.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(test, slice_patterns)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `slice_patterns` has been stable since 1.42.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(test, slice_patterns)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/main.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 81 | struct ExprDecl { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 82 | name: &'static str, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ExprDecl` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:333:27 [INFO] [stdout] | [INFO] [stdout] 333 | ..TypeError::for_node(self, read_as) [INFO] [stdout] | ___________________________^ [INFO] [stdout] 334 | | .wrong_param(2, read_as, e.my_type) [INFO] [stdout] 335 | | .my_type(e.my_type) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:370:39 [INFO] [stdout] | [INFO] [stdout] 370 | .any(|(a, t)| store.get(*a).expr_type(store, Some(&[*t])).is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1124:18 [INFO] [stdout] | [INFO] [stdout] 1123 | fn from(v: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1124 | Box::new(VMError::IO(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1130:18 [INFO] [stdout] | [INFO] [stdout] 1129 | fn from(v: Box) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1130 | Box::new(VMError::TypeError(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1553:35 [INFO] [stdout] | [INFO] [stdout] 1553 | .try_for_each(|k| blocks.build_statement(&parser.ast_store, *k).map(|_| ()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stgolf` (bin "stgolf") due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/main.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 81 | struct ExprDecl { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 82 | name: &'static str, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ExprDecl` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:333:27 [INFO] [stdout] | [INFO] [stdout] 333 | ..TypeError::for_node(self, read_as) [INFO] [stdout] | ___________________________^ [INFO] [stdout] 334 | | .wrong_param(2, read_as, e.my_type) [INFO] [stdout] 335 | | .my_type(e.my_type) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:370:39 [INFO] [stdout] | [INFO] [stdout] 370 | .any(|(a, t)| store.get(*a).expr_type(store, Some(&[*t])).is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1124:18 [INFO] [stdout] | [INFO] [stdout] 1123 | fn from(v: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1124 | Box::new(VMError::IO(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1130:18 [INFO] [stdout] | [INFO] [stdout] 1129 | fn from(v: Box) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1130 | Box::new(VMError::TypeError(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1553:35 [INFO] [stdout] | [INFO] [stdout] 1553 | .try_for_each(|k| blocks.build_statement(&parser.ast_store, *k).map(|_| ()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stgolf` (bin "stgolf" test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "394dc561af385f44bdaf2b13263caf9cd96a23c168fae72bf83282cd2f72eb85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "394dc561af385f44bdaf2b13263caf9cd96a23c168fae72bf83282cd2f72eb85", kill_on_drop: false }` [INFO] [stdout] 394dc561af385f44bdaf2b13263caf9cd96a23c168fae72bf83282cd2f72eb85