[INFO] cloning repository https://github.com/JamesZFS/LeetCode [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JamesZFS/LeetCode" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesZFS%2FLeetCode", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesZFS%2FLeetCode'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 34283e6a7ea27b8a806d8726241288117896aca5 [INFO] checking JamesZFS/LeetCode/34283e6a7ea27b8a806d8726241288117896aca5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesZFS%2FLeetCode" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JamesZFS/LeetCode on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JamesZFS/LeetCode [INFO] finished tweaking git repo https://github.com/JamesZFS/LeetCode [INFO] tweaked toml for git repo https://github.com/JamesZFS/LeetCode written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JamesZFS/LeetCode already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a53ae3dff8811f00e7193f6c3b25088ffb22444825b80c01f661b4c5050c99d0 [INFO] running `Command { std: "docker" "start" "-a" "a53ae3dff8811f00e7193f6c3b25088ffb22444825b80c01f661b4c5050c99d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a53ae3dff8811f00e7193f6c3b25088ffb22444825b80c01f661b4c5050c99d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a53ae3dff8811f00e7193f6c3b25088ffb22444825b80c01f661b4c5050c99d0", kill_on_drop: false }` [INFO] [stdout] a53ae3dff8811f00e7193f6c3b25088ffb22444825b80c01f661b4c5050c99d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5d9042a701e0387f45b05c5a171ecfbc19f1257fb522c44b92a4151a6931d72d [INFO] running `Command { std: "docker" "start" "-a" "5d9042a701e0387f45b05c5a171ecfbc19f1257fb522c44b92a4151a6931d72d", kill_on_drop: false }` [INFO] [stderr] Checking leet_code v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `tail` is never used [INFO] [stdout] --> src/practice/list.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 20 | impl List { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 94 | fn tail(&self) -> &Link { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/heap.rs:77:39 [INFO] [stdout] | [INFO] [stdout] 77 | arr.iter().for_each(|x| heap.push(x.clone())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/list.rs:17:50 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(data: T) -> Self { Self { data, next: None } } [INFO] [stdout] | ------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/list.rs:59:66 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn back(&self) -> Option<&T> { self.tail_1().map(|link| &link.as_ref().unwrap().data) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/list.rs:65:86 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn back_mut(&mut self) -> Option<&mut T> { self.tail_1_mut().map(|link| &mut link.as_mut().unwrap().data) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/list.rs:190:25 [INFO] [stdout] | [INFO] [stdout] 189 | fn into_iter(mut self) -> IntoIter { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | IntoIter { cur: self.head.take() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `leet_code` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `tail` is never used [INFO] [stdout] --> src/practice/list.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 20 | impl List { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 94 | fn tail(&self) -> &Link { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> src/string/p5.rs:57:53 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(Solution::reverse_words(input.deref().into()), output.deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> src/string/p5.rs:57:77 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(Solution::reverse_words(input.deref().into()), output.deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> src/string/p6.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | assert_eq!(Solution::simplify_path(input.deref().into()), output.deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> src/string/p6.rs:69:77 [INFO] [stdout] | [INFO] [stdout] 69 | assert_eq!(Solution::simplify_path(input.deref().into()), output.deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/string/p7.rs:75:60 [INFO] [stdout] | [INFO] [stdout] 75 | assert_eq!(Solution::restore_ip_addresses(input.deref().into()), output); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Deref`, so calling `deref` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/heap.rs:77:39 [INFO] [stdout] | [INFO] [stdout] 77 | arr.iter().for_each(|x| heap.push(x.clone())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/list.rs:17:50 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(data: T) -> Self { Self { data, next: None } } [INFO] [stdout] | ------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/list.rs:59:66 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn back(&self) -> Option<&T> { self.tail_1().map(|link| &link.as_ref().unwrap().data) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/list.rs:65:86 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn back_mut(&mut self) -> Option<&mut T> { self.tail_1_mut().map(|link| &mut link.as_mut().unwrap().data) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice/list.rs:190:25 [INFO] [stdout] | [INFO] [stdout] 189 | fn into_iter(mut self) -> IntoIter { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | IntoIter { cur: self.head.take() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `leet_code` (lib test) due to 6 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5d9042a701e0387f45b05c5a171ecfbc19f1257fb522c44b92a4151a6931d72d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d9042a701e0387f45b05c5a171ecfbc19f1257fb522c44b92a4151a6931d72d", kill_on_drop: false }` [INFO] [stdout] 5d9042a701e0387f45b05c5a171ecfbc19f1257fb522c44b92a4151a6931d72d