[INFO] cloning repository https://github.com/JamesTrewern/manual_rwlock [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JamesTrewern/manual_rwlock" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesTrewern%2Fmanual_rwlock", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesTrewern%2Fmanual_rwlock'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e8ec1de0aacae20a3fede59c253e7e7f106d844e [INFO] checking JamesTrewern/manual_rwlock/e8ec1de0aacae20a3fede59c253e7e7f106d844e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesTrewern%2Fmanual_rwlock" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JamesTrewern/manual_rwlock on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JamesTrewern/manual_rwlock [INFO] finished tweaking git repo https://github.com/JamesTrewern/manual_rwlock [INFO] tweaked toml for git repo https://github.com/JamesTrewern/manual_rwlock written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JamesTrewern/manual_rwlock already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f3b53bc2ee6695ac73c39fc89c0fabbdfa2618f11f1dc5f9cb9b45cb909cf1e [INFO] running `Command { std: "docker" "start" "-a" "9f3b53bc2ee6695ac73c39fc89c0fabbdfa2618f11f1dc5f9cb9b45cb909cf1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f3b53bc2ee6695ac73c39fc89c0fabbdfa2618f11f1dc5f9cb9b45cb909cf1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f3b53bc2ee6695ac73c39fc89c0fabbdfa2618f11f1dc5f9cb9b45cb909cf1e", kill_on_drop: false }` [INFO] [stdout] 9f3b53bc2ee6695ac73c39fc89c0fabbdfa2618f11f1dc5f9cb9b45cb909cf1e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 147f09a624805056f957f7d1fdbb103fb88398f43e7759db3e1e49b7de0cb284 [INFO] running `Command { std: "docker" "start" "-a" "147f09a624805056f957f7d1fdbb103fb88398f43e7759db3e1e49b7de0cb284", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking atomic-wait v1.1.0 [INFO] [stderr] Checking manual_rwlock v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:19 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn new(data: T) -> MrwLock { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | data: UnsafeCell::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_gaurd.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn try_to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | self.state.try_to_write()?; [INFO] [stdout] 14 | Ok(WriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 15 | | state: &self.state, [INFO] [stdout] 16 | | data: self.data, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_gaurd.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | self.state.to_write()?; [INFO] [stdout] 31 | Ok(WriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | state: &self.state, [INFO] [stdout] 33 | | data: self.data, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_read_gaurd.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn try_to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | self.state.try_to_write()?; [INFO] [stdout] 25 | Ok(SliceWriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | state: &self.state, [INFO] [stdout] 27 | | data: self.data, [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_read_gaurd.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | self.state.to_write()?; [INFO] [stdout] 33 | Ok(SliceWriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | state: &self.state, [INFO] [stdout] 35 | | data: self.data, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:19 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn new(data: T) -> MrwLock { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | data: UnsafeCell::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_gaurd.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn try_to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | self.state.try_to_write()?; [INFO] [stdout] 14 | Ok(WriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 15 | | state: &self.state, [INFO] [stdout] 16 | | data: self.data, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_gaurd.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | self.state.to_write()?; [INFO] [stdout] 31 | Ok(WriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | state: &self.state, [INFO] [stdout] 33 | | data: self.data, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_read_gaurd.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn try_to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | self.state.try_to_write()?; [INFO] [stdout] 25 | Ok(SliceWriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | state: &self.state, [INFO] [stdout] 27 | | data: self.data, [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_read_gaurd.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | self.state.to_write()?; [INFO] [stdout] 33 | Ok(SliceWriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | state: &self.state, [INFO] [stdout] 35 | | data: self.data, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `manual_rwlock` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `manual_rwlock` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "147f09a624805056f957f7d1fdbb103fb88398f43e7759db3e1e49b7de0cb284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "147f09a624805056f957f7d1fdbb103fb88398f43e7759db3e1e49b7de0cb284", kill_on_drop: false }` [INFO] [stdout] 147f09a624805056f957f7d1fdbb103fb88398f43e7759db3e1e49b7de0cb284