[INFO] cloning repository https://github.com/JacktheDevel0per/patchpack [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JacktheDevel0per/patchpack" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJacktheDevel0per%2Fpatchpack", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJacktheDevel0per%2Fpatchpack'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 839a5aa3294ebe574c07d969b3253de9818729dd [INFO] checking JacktheDevel0per/patchpack/839a5aa3294ebe574c07d969b3253de9818729dd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJacktheDevel0per%2Fpatchpack" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JacktheDevel0per/patchpack on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/rust-toolchain [INFO] started tweaking git repo https://github.com/JacktheDevel0per/patchpack [INFO] finished tweaking git repo https://github.com/JacktheDevel0per/patchpack [INFO] tweaked toml for git repo https://github.com/JacktheDevel0per/patchpack written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JacktheDevel0per/patchpack already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f3484f8d68dfdadaa52e09c2624d28b10ef905c56f59790930c931afab63436 [INFO] running `Command { std: "docker" "start" "-a" "5f3484f8d68dfdadaa52e09c2624d28b10ef905c56f59790930c931afab63436", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f3484f8d68dfdadaa52e09c2624d28b10ef905c56f59790930c931afab63436", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f3484f8d68dfdadaa52e09c2624d28b10ef905c56f59790930c931afab63436", kill_on_drop: false }` [INFO] [stdout] 5f3484f8d68dfdadaa52e09c2624d28b10ef905c56f59790930c931afab63436 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d672f4704090030e7595be46b1c2a30f39422773852a58c48962c014a186b6d3 [INFO] running `Command { std: "docker" "start" "-a" "d672f4704090030e7595be46b1c2a30f39422773852a58c48962c014a186b6d3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking half v2.4.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking bsdiff v0.1.6 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking sacabase v2.0.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Compiling cdivsufsort v2.0.0 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling liblzma-sys v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking suffix_array v0.5.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking qbsdiff v1.4.1 [INFO] [stderr] Checking liblzma v0.3.0 [INFO] [stderr] Checking serde v1.0.197 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking patchpack v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 56 | let mut file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let patch_applicator = Bspatch::new(&fp.content).ok()?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Some(file.bytes().count() as isize - original.len() as isize) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 109 | let mut old_file = fs::OpenOptions::new().read(true).open(&file_path).ok()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let mut new_file = fs::OpenOptions::new().read(true).open(&file_path).ok()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | RelativeBSPatch::new(file_path, content).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 133 | let mut file = fs::OpenOptions::new().read(true).open(&file_path).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | RelativeBSPatch::new(file_path, content).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 152 | .filter_map(|p| RelativeBSPatch::from_tar(&mut p.ok()?).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 56 | let mut file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let patch_applicator = Bspatch::new(&fp.content).ok()?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Some(file.bytes().count() as isize - original.len() as isize) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 109 | let mut old_file = fs::OpenOptions::new().read(true).open(&file_path).ok()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let mut new_file = fs::OpenOptions::new().read(true).open(&file_path).ok()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | RelativeBSPatch::new(file_path, content).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 133 | let mut file = fs::OpenOptions::new().read(true).open(&file_path).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | RelativeBSPatch::new(file_path, content).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 152 | .filter_map(|p| RelativeBSPatch::from_tar(&mut p.ok()?).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `patchpack` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `patchpack` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "d672f4704090030e7595be46b1c2a30f39422773852a58c48962c014a186b6d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d672f4704090030e7595be46b1c2a30f39422773852a58c48962c014a186b6d3", kill_on_drop: false }` [INFO] [stdout] d672f4704090030e7595be46b1c2a30f39422773852a58c48962c014a186b6d3