[INFO] cloning repository https://github.com/JackThomson2/Threadpooler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JackThomson2/Threadpooler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJackThomson2%2FThreadpooler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJackThomson2%2FThreadpooler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f51c82f04fbaa442929daaf3bdd966a5b64be7c5 [INFO] checking JackThomson2/Threadpooler/f51c82f04fbaa442929daaf3bdd966a5b64be7c5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJackThomson2%2FThreadpooler" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JackThomson2/Threadpooler on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JackThomson2/Threadpooler [INFO] finished tweaking git repo https://github.com/JackThomson2/Threadpooler [INFO] tweaked toml for git repo https://github.com/JackThomson2/Threadpooler written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JackThomson2/Threadpooler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fdacc708d3bc25872fbef678241153233e59ed05e9be88e7f93aa443213ed2cf [INFO] running `Command { std: "docker" "start" "-a" "fdacc708d3bc25872fbef678241153233e59ed05e9be88e7f93aa443213ed2cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fdacc708d3bc25872fbef678241153233e59ed05e9be88e7f93aa443213ed2cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fdacc708d3bc25872fbef678241153233e59ed05e9be88e7f93aa443213ed2cf", kill_on_drop: false }` [INFO] [stdout] fdacc708d3bc25872fbef678241153233e59ed05e9be88e7f93aa443213ed2cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b3a3c1b958892f455261c3ace6f1f078dfa4a4bbc726e4c7cdd57ffbb160a48b [INFO] running `Command { std: "docker" "start" "-a" "b3a3c1b958892f455261c3ace6f1f078dfa4a4bbc726e4c7cdd57ffbb160a48b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling serde v1.0.116 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling rayon-core v1.8.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling syn v1.0.42 [INFO] [stderr] Compiling serde_json v1.0.58 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling rayon v1.4.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.116 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking instant v0.1.7 [INFO] [stderr] Checking smallvec v1.4.2 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Compiling cc v1.0.60 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking parking_lot_core v0.8.0 [INFO] [stderr] Checking lock_api v0.4.1 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking parking_lot v0.11.0 [INFO] [stderr] Compiling sys-info v0.5.10 [INFO] [stderr] Checking rayoff v0.1.0 (https://github.com/aeyakovenko/rayoff#a01d3f33) [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking tinytemplate v1.1.0 [INFO] [stderr] Checking criterion v0.3.3 [INFO] [stderr] Checking threadpooler v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion_bencher_compat v0.3.3 [INFO] [stdout] warning: unused import: `Steal` [INFO] [stdout] --> src/newJob.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use crossbeam_deque::{Steal, Worker}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::spawn` [INFO] [stdout] --> src/pool.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::thread::spawn; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::spawn` [INFO] [stdout] --> src/pool.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::thread::spawn; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `COMPLETE` is never used [INFO] [stdout] --> src/lockedBatch.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const COMPLETE: u8 = 0b000_0010; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `lockedBatch` should have a snake case name [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | mod lockedBatch; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `locked_batch` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `newJob` should have a snake case name [INFO] [stdout] --> src/lib.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod newJob; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `new_job` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 37 | pub unsafe fn new(elems: &mut [A], func: F, cores: usize) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let locked_batch = (0..cores) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | waker_lock: Arc::new((Mutex::new(false), Condvar::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 19 | let mut senders = Vec::with_capacity(num_threads); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let senders = senders; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Self { [INFO] [stdout] 34 | senders: Mutex::new(senders), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `threadpooler` (lib) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/newJob.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | for i in 0..4 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `COMPLETE` is never used [INFO] [stdout] --> src/lockedBatch.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const COMPLETE: u8 = 0b000_0010; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `lockedBatch` should have a snake case name [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | mod lockedBatch; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `locked_batch` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `newJob` should have a snake case name [INFO] [stdout] --> src/lib.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod newJob; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `new_job` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 37 | pub unsafe fn new(elems: &mut [A], func: F, cores: usize) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let locked_batch = (0..cores) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | waker_lock: Arc::new((Mutex::new(false), Condvar::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 19 | let mut senders = Vec::with_capacity(num_threads); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let senders = senders; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Self { [INFO] [stdout] 34 | senders: Mutex::new(senders), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:113:50 [INFO] [stdout] | [INFO] [stdout] 113 | let rv = RAYOFF_POOL.with(|pool| pool.borrow().map(&array, |val| val + 1)); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `threadpooler` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b3a3c1b958892f455261c3ace6f1f078dfa4a4bbc726e4c7cdd57ffbb160a48b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3a3c1b958892f455261c3ace6f1f078dfa4a4bbc726e4c7cdd57ffbb160a48b", kill_on_drop: false }` [INFO] [stdout] b3a3c1b958892f455261c3ace6f1f078dfa4a4bbc726e4c7cdd57ffbb160a48b