[INFO] cloning repository https://github.com/JKingdom/substrate-storage-example [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JKingdom/substrate-storage-example" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJKingdom%2Fsubstrate-storage-example", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJKingdom%2Fsubstrate-storage-example'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 542065b4e2416358f2a9d2011e41e75e0a24002b [INFO] checking JKingdom/substrate-storage-example/542065b4e2416358f2a9d2011e41e75e0a24002b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJKingdom%2Fsubstrate-storage-example" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JKingdom/substrate-storage-example on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JKingdom/substrate-storage-example [INFO] finished tweaking git repo https://github.com/JKingdom/substrate-storage-example [INFO] tweaked toml for git repo https://github.com/JKingdom/substrate-storage-example written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JKingdom/substrate-storage-example already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 24790cbe5e868eee7e193f885a30644a06ba23b272b1589e4b243ad62034c042 [INFO] running `Command { std: "docker" "start" "-a" "24790cbe5e868eee7e193f885a30644a06ba23b272b1589e4b243ad62034c042", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "24790cbe5e868eee7e193f885a30644a06ba23b272b1589e4b243ad62034c042", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24790cbe5e868eee7e193f885a30644a06ba23b272b1589e4b243ad62034c042", kill_on_drop: false }` [INFO] [stdout] 24790cbe5e868eee7e193f885a30644a06ba23b272b1589e4b243ad62034c042 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2696a8fadb34b2c320860664893a333b5534cf56aa8b723a56e68d79eb5b6b30 [INFO] running `Command { std: "docker" "start" "-a" "2696a8fadb34b2c320860664893a333b5534cf56aa8b723a56e68d79eb5b6b30", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Compiling cfg-if v0.1.6 [INFO] [stderr] Compiling nodrop v0.1.13 [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Compiling memoffset v0.2.1 [INFO] [stderr] Compiling lazy_static v1.2.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling arrayvec v0.4.8 [INFO] [stderr] Compiling crossbeam-utils v0.2.2 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Compiling proc-macro-hack-impl v0.4.1 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Compiling crunchy v0.2.1 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crunchy v0.1.6 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Compiling heapsize v0.4.2 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Compiling sr-std v0.1.0 (https://github.com/paritytech/substrate#74fae42c) [INFO] [stderr] Compiling proc-macro-hack v0.4.1 [INFO] [stderr] Checking rustc-hex v2.0.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling syn v0.15.22 [INFO] [stderr] Compiling hex-literal-impl v0.1.1 [INFO] [stderr] Checking parity-wasm v0.31.3 [INFO] [stderr] Checking static_assertions v0.2.5 [INFO] [stderr] Checking untrusted v0.5.1 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking memory_units v0.3.0 [INFO] [stderr] Checking constant_time_eq v0.1.3 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking blake2-rfc v0.2.18 [INFO] [stderr] Checking hex-literal v0.1.1 [INFO] [stderr] Checking hash256-std-hasher v0.9.0 (https://github.com/paritytech/trie#2616db2a) [INFO] [stderr] Checking twox-hash v1.1.1 [INFO] [stderr] Checking fixed-hash v0.3.0 [INFO] [stderr] Checking uint v0.5.0 [INFO] [stderr] Checking base58 v0.1.0 [INFO] [stderr] Checking hash-db v0.9.0 (https://github.com/paritytech/trie#2616db2a) [INFO] [stderr] Checking environmental v1.0.0 [INFO] [stderr] Checking wasmi v0.4.2 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Compiling parity-codec-derive v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking parity-codec v2.1.5 [INFO] [stderr] Checking substrate-primitives v0.1.0 (https://github.com/paritytech/substrate#74fae42c) [INFO] [stderr] Checking storage v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/storage/generator.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::marker::PhantomData` [INFO] [stdout] --> src/storage/generator.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub use std::marker::PhantomData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::marker::PhantomData` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::marker::PhantomData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:89:58 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn with_externalities R>(ext: &mut MemDBT, f: F) -> R { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 89 | pub fn with_externalities R>(ext: &mut dyn MemDBT, f: F) -> R { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/storage/generator.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::marker::PhantomData` [INFO] [stdout] --> src/storage/generator.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub use std::marker::PhantomData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::marker::PhantomData` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::marker::PhantomData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:89:58 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn with_externalities R>(ext: &mut MemDBT, f: F) -> R { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 89 | pub fn with_externalities R>(ext: &mut dyn MemDBT, f: F) -> R { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Encode` [INFO] [stdout] --> src/main.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | use self::codec::{Codec, Encode, Decode}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StorageMap` [INFO] [stdout] --> src/main.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | use self::storage::{StorageMap, StorageValue}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `init` is never used [INFO] [stdout] --> src/main.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 22 | impl MemDB { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 27 | fn init(&mut self, v: Vec<(Vec, Vec)>) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_or_default` is never used [INFO] [stdout] --> src/storage/mod.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn get_or_default(key: &[u8]) -> T { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_or` is never used [INFO] [stdout] --> src/storage/mod.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn get_or(key: &[u8], default_value: T) -> T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_or_else` is never used [INFO] [stdout] --> src/storage/mod.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn get_or_else T>(key: &[u8], default_value: F) -> T { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `take_or_default` is never used [INFO] [stdout] --> src/storage/mod.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn take_or_default(key: &[u8]) -> T { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `take_or` is never used [INFO] [stdout] --> src/storage/mod.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn take_or(key: &[u8], default_value: T) -> T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `take_or_else` is never used [INFO] [stdout] --> src/storage/mod.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn take_or_else T>(key: &[u8], default_value: F) -> T { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_raw` is never used [INFO] [stdout] --> src/storage/mod.rs:100:8 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn get_raw(key: &[u8]) -> Option> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `put_raw` is never used [INFO] [stdout] --> src/storage/mod.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn put_raw(key: &[u8], value: &[u8]) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `key`, `exists`, `mutate`, `kill`, and `take` are never used [INFO] [stdout] --> src/storage/mod.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 139 | pub trait StorageValue { [INFO] [stdout] | ------------ associated functions in this trait [INFO] [stdout] ... [INFO] [stdout] 144 | fn key() -> &'static [u8]; [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 147 | fn exists() -> bool; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 156 | fn mutate R>(f: F) -> R; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 159 | fn kill(); [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 162 | fn take() -> Self::Query; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated functions are never used [INFO] [stdout] --> src/storage/mod.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 192 | pub trait StorageMap { [INFO] [stdout] | ---------- associated functions in this trait [INFO] [stdout] ... [INFO] [stdout] 197 | fn prefix() -> &'static [u8]; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 200 | fn key_for>(key: KeyArg) -> Vec; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 203 | fn exists>(key: KeyArg) -> bool; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 206 | fn get>(key: KeyArg) -> Self::Query; [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 209 | fn insert, ValArg: Borrow>(key: KeyArg, val: ValArg); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 212 | fn remove>(key: KeyArg); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 215 | fn mutate, R, F: FnOnce(&mut Self::Query) -> R>(key: KeyArg, f: F) -> R; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 218 | fn take>(key: KeyArg) -> Self::Query; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `require`, `get_or_default`, `take_or_panic`, and `take_or_default` are never used [INFO] [stdout] --> src/storage/generator.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 55 | pub trait Storage { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 64 | fn require(&self, key: &[u8]) -> T { self.get(key).expect("Required values must be in storage") } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 68 | fn get_or_default(&self, key: &[u8]) -> T { self.get(key).unwrap_or_default() } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | fn take_or_panic(&self, key: &[u8]) -> T { self.take(key).expect("Required values must be in storage") } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | fn take_or_default(&self, key: &[u8]) -> T { self.take(key).unwrap_or_default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn get_or(key: &[u8], default_value: T) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | get(key).unwrap_or(default_value) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn get_or_else T>(key: &[u8], default_value: F) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | get(key).unwrap_or_else(default_value) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn take_or(key: &[u8], default_value: T) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | take(key).unwrap_or(default_value) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn take_or_else T>(key: &[u8], default_value: F) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | take(key).unwrap_or_else(default_value) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `storage` (bin "storage") due to 5 previous errors; 18 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `Encode` [INFO] [stdout] --> src/main.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | use self::codec::{Codec, Encode, Decode}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StorageMap` [INFO] [stdout] --> src/main.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | use self::storage::{StorageMap, StorageValue}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `init` is never used [INFO] [stdout] --> src/main.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 22 | impl MemDB { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 27 | fn init(&mut self, v: Vec<(Vec, Vec)>) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_or_default` is never used [INFO] [stdout] --> src/storage/mod.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn get_or_default(key: &[u8]) -> T { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_or` is never used [INFO] [stdout] --> src/storage/mod.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn get_or(key: &[u8], default_value: T) -> T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_or_else` is never used [INFO] [stdout] --> src/storage/mod.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn get_or_else T>(key: &[u8], default_value: F) -> T { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `take_or_default` is never used [INFO] [stdout] --> src/storage/mod.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn take_or_default(key: &[u8]) -> T { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `take_or` is never used [INFO] [stdout] --> src/storage/mod.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn take_or(key: &[u8], default_value: T) -> T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `take_or_else` is never used [INFO] [stdout] --> src/storage/mod.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn take_or_else T>(key: &[u8], default_value: F) -> T { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_raw` is never used [INFO] [stdout] --> src/storage/mod.rs:100:8 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn get_raw(key: &[u8]) -> Option> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `put_raw` is never used [INFO] [stdout] --> src/storage/mod.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn put_raw(key: &[u8], value: &[u8]) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `key`, `exists`, `mutate`, `kill`, and `take` are never used [INFO] [stdout] --> src/storage/mod.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 139 | pub trait StorageValue { [INFO] [stdout] | ------------ associated functions in this trait [INFO] [stdout] ... [INFO] [stdout] 144 | fn key() -> &'static [u8]; [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 147 | fn exists() -> bool; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 156 | fn mutate R>(f: F) -> R; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 159 | fn kill(); [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 162 | fn take() -> Self::Query; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated functions are never used [INFO] [stdout] --> src/storage/mod.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 192 | pub trait StorageMap { [INFO] [stdout] | ---------- associated functions in this trait [INFO] [stdout] ... [INFO] [stdout] 197 | fn prefix() -> &'static [u8]; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 200 | fn key_for>(key: KeyArg) -> Vec; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 203 | fn exists>(key: KeyArg) -> bool; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 206 | fn get>(key: KeyArg) -> Self::Query; [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 209 | fn insert, ValArg: Borrow>(key: KeyArg, val: ValArg); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 212 | fn remove>(key: KeyArg); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 215 | fn mutate, R, F: FnOnce(&mut Self::Query) -> R>(key: KeyArg, f: F) -> R; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 218 | fn take>(key: KeyArg) -> Self::Query; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `require`, `get_or_default`, `take_or_panic`, and `take_or_default` are never used [INFO] [stdout] --> src/storage/generator.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 55 | pub trait Storage { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 64 | fn require(&self, key: &[u8]) -> T { self.get(key).expect("Required values must be in storage") } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 68 | fn get_or_default(&self, key: &[u8]) -> T { self.get(key).unwrap_or_default() } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | fn take_or_panic(&self, key: &[u8]) -> T { self.take(key).expect("Required values must be in storage") } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | fn take_or_default(&self, key: &[u8]) -> T { self.take(key).unwrap_or_default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn get_or(key: &[u8], default_value: T) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | get(key).unwrap_or(default_value) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn get_or_else T>(key: &[u8], default_value: F) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | get(key).unwrap_or_else(default_value) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn take_or(key: &[u8], default_value: T) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | take(key).unwrap_or(default_value) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn take_or_else T>(key: &[u8], default_value: F) -> T { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | take(key).unwrap_or_else(default_value) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `storage` (bin "storage" test) due to 5 previous errors; 18 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2696a8fadb34b2c320860664893a333b5534cf56aa8b723a56e68d79eb5b6b30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2696a8fadb34b2c320860664893a333b5534cf56aa8b723a56e68d79eb5b6b30", kill_on_drop: false }` [INFO] [stdout] 2696a8fadb34b2c320860664893a333b5534cf56aa8b723a56e68d79eb5b6b30