[INFO] cloning repository https://github.com/JJendryka/chip8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JJendryka/chip8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJJendryka%2Fchip8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJJendryka%2Fchip8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 03f10d7804f68a5941daef1bef813940d75f05cd [INFO] checking JJendryka/chip8/03f10d7804f68a5941daef1bef813940d75f05cd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJJendryka%2Fchip8" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JJendryka/chip8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JJendryka/chip8 [INFO] finished tweaking git repo https://github.com/JJendryka/chip8 [INFO] tweaked toml for git repo https://github.com/JJendryka/chip8 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JJendryka/chip8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d40502805750776539f73f0d5089d4832d184ab844494588621c13ede348bfa8 [INFO] running `Command { std: "docker" "start" "-a" "d40502805750776539f73f0d5089d4832d184ab844494588621c13ede348bfa8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d40502805750776539f73f0d5089d4832d184ab844494588621c13ede348bfa8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d40502805750776539f73f0d5089d4832d184ab844494588621c13ede348bfa8", kill_on_drop: false }` [INFO] [stdout] d40502805750776539f73f0d5089d4832d184ab844494588621c13ede348bfa8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 739d6914461e1548cc3d997714c08508c6ee97c92b58ea0e1fe40a01ef66be12 [INFO] running `Command { std: "docker" "start" "-a" "739d6914461e1548cc3d997714c08508c6ee97c92b58ea0e1fe40a01ef66be12", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling cc v1.0.57 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling libloading v0.6.2 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Checking wayland-sys v0.21.13 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling syn v1.0.33 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling adler32 v1.1.0 [INFO] [stderr] Compiling gimli v0.21.0 [INFO] [stderr] Compiling miniz_oxide v0.3.7 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling object v0.20.0 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling rustc-demangle v0.1.16 [INFO] [stderr] Compiling serde_json v1.0.56 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling itoa v0.4.6 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling pulldown-cmark v0.2.0 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Checking xml-rs v0.8.3 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling bzip2-sys v0.1.9+1.0.8 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.1.0 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Compiling gfx_gl v0.6.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Compiling glutin_glx_sys v0.1.6 [INFO] [stderr] Compiling glutin_egl_sys v0.1.4 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling nix v0.15.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking gfx_core v0.9.2 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling addr2line v0.12.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling backtrace v0.3.49 [INFO] [stderr] Checking sid v0.5.2 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking wayland-commons v0.21.13 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking xi-unicode v0.2.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Compiling bytecount v0.4.0 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking alga v0.9.3 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking twox-hash v1.5.0 [INFO] [stderr] Checking glyph_brush_layout v0.1.9 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Checking ogg v0.7.0 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking mint v0.5.5 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking lewton v0.9.4 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking png v0.15.3 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking glyph_brush v0.6.3 [INFO] [stderr] Checking minimp3 v0.3.5 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking nalgebra v0.18.1 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking claxon v0.4.2 [INFO] [stderr] Checking podio v0.1.7 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Checking glyph_brush v0.5.4 [INFO] [stderr] Checking gfx v0.18.2 [INFO] [stderr] Checking zip v0.5.6 [INFO] [stderr] Checking gfx_device_gl v0.16.2 [INFO] [stderr] Compiling euclid_macros v0.1.0 [INFO] [stderr] Compiling smart-default v0.5.2 [INFO] [stderr] Checking euclid v0.19.9 [INFO] [stderr] Checking lyon_geom v0.12.7 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking gilrs-core v0.2.6 [INFO] [stderr] Checking gilrs v0.7.4 [INFO] [stderr] Checking lyon_path v0.13.2 [INFO] [stderr] Checking image v0.22.5 [INFO] [stderr] Checking lyon_algorithms v0.13.4 [INFO] [stderr] Checking lyon_tessellation v0.13.5 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking lyon v0.13.5 [INFO] [stderr] Compiling cargo_metadata v0.6.4 [INFO] [stderr] Compiling skeptic v0.13.4 [INFO] [stderr] Compiling ggez v0.5.1 [INFO] [stderr] Checking rodio v0.9.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.6 [INFO] [stderr] Checking winit v0.19.5 [INFO] [stderr] Checking glutin v0.20.1 [INFO] [stderr] Checking gfx_window_glutin v0.30.0 [INFO] [stderr] Checking chip8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `EventHandler` [INFO] [stdout] --> src/main.rs:2:25 [INFO] [stdout] | [INFO] [stdout] 2 | use ggez::event::{self, EventHandler}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::random` [INFO] [stdout] --> src/simulator.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::random; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `EventHandler` [INFO] [stdout] --> src/main.rs:2:25 [INFO] [stdout] | [INFO] [stdout] 2 | use ggez::event::{self, EventHandler}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::random` [INFO] [stdout] --> src/simulator.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::random; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/simulator.rs:48:50 [INFO] [stdout] | [INFO] [stdout] 48 | op!(OP_OOEO, "CLEAR screen", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/simulator.rs:53:60 [INFO] [stdout] | [INFO] [stdout] 53 | op!(OP_OOEE, "RETURN from subroutine", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/simulator.rs:48:50 [INFO] [stdout] | [INFO] [stdout] 48 | op!(OP_OOEO, "CLEAR screen", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/simulator.rs:53:60 [INFO] [stdout] | [INFO] [stdout] 53 | op!(OP_OOEE, "RETURN from subroutine", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/simulator.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | let output = operation.display.to_string(); //.replace("{Vb}", vb).replace({Vc}, vc) [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/simulator.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | let output = operation.display.to_string(); //.replace("{Vb}", vb).replace({Vc}, vc) [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `display` and `name` are never read [INFO] [stdout] --> src/simulator.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct Operation { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 33 | execute: Execute, [INFO] [stdout] 34 | display: &'static str, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 35 | name: &'static str, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_operation` is never used [INFO] [stdout] --> src/simulator.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 259 | impl Chip8 { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 294 | fn print_operation(&mut self, operation: &Operation, opcode: &Opcode) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `display` and `name` are never read [INFO] [stdout] --> src/simulator.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct Operation { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 33 | execute: Execute, [INFO] [stdout] 34 | display: &'static str, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 35 | name: &'static str, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_operation` is never used [INFO] [stdout] --> src/simulator.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 259 | impl Chip8 { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 294 | fn print_operation(&mut self, operation: &Operation, opcode: &Opcode) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:11 [INFO] [stdout] | [INFO] [stdout] 119 | let (mut ctx, mut event_loop) = ContextBuilder::new("Chip8", "Jakub Jendryka").build().unwrap(); [INFO] [stdout] | --- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let mut state = State::new(&mut ctx); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | [INFO] [stdout] 126 | match event::run(&mut ctx, &mut event_loop, &mut state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_1nnn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | op!(OP_1nnn, "JUMP to nnn{bcd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_1NNN` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_2nnn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | op!(OP_2nnn, "CALL abc{bcd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_2NNN` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_3xkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | op!(OP_3xkk, "SKIP if Vx{Vb} equal to kk{cd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_3XKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_4xkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | op!(OP_4xkk, "SKIP if Vx{Vb} not equal to kk{cd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_4XKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_5xy0` should have an upper case name [INFO] [stdout] --> src/simulator.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | op!(OP_5xy0, "SKIP if Vx{Vb} equal to Vy{Vc}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_5XY0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:11 [INFO] [stdout] | [INFO] [stdout] 119 | let (mut ctx, mut event_loop) = ContextBuilder::new("Chip8", "Jakub Jendryka").build().unwrap(); [INFO] [stdout] | --- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let mut state = State::new(&mut ctx); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | [INFO] [stdout] 126 | match event::run(&mut ctx, &mut event_loop, &mut state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_6xkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | op!(OP_6xkk, "SET Vx{Vb} to kk{cd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_6XKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_7xkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | op!(OP_7xkk, "ADD kk{cd} to Vx{Vb} without carry", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_7XKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_1nnn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | op!(OP_1nnn, "JUMP to nnn{bcd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_1NNN` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy0` should have an upper case name [INFO] [stdout] --> src/simulator.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | op!(OP_8xy0, "MOVE Vy{Vc} to Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy1` should have an upper case name [INFO] [stdout] --> src/simulator.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | op!(OP_8xy1, "OR Vx{Vb} with Vy{Vc} and store to Vx", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy2` should have an upper case name [INFO] [stdout] --> src/simulator.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | op!(OP_8xy2, "AND Vx{Vb} with Vy{Vc} and store to Vx", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_2nnn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | op!(OP_2nnn, "CALL abc{bcd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_2NNN` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy3` should have an upper case name [INFO] [stdout] --> src/simulator.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | op!(OP_8xy3, "XOR Vx{Vb} with Vy{Vc} and store to Vx", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_3xkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | op!(OP_3xkk, "SKIP if Vx{Vb} equal to kk{cd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_3XKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_4xkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | op!(OP_4xkk, "SKIP if Vx{Vb} not equal to kk{cd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_4XKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_5xy0` should have an upper case name [INFO] [stdout] --> src/simulator.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | op!(OP_5xy0, "SKIP if Vx{Vb} equal to Vy{Vc}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_5XY0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy4` should have an upper case name [INFO] [stdout] --> src/simulator.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | op!(OP_8xy4, "ADD Vy{Vc} to Vx{Vb} and store to Vx with carry", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY4` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_6xkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | op!(OP_6xkk, "SET Vx{Vb} to kk{cd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_6XKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_7xkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | op!(OP_7xkk, "ADD kk{cd} to Vx{Vb} without carry", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_7XKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy5` should have an upper case name [INFO] [stdout] --> src/simulator.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | op!(OP_8xy5, "SUB Vy{Vc} from Vx{Vb} and store to Vx with borrow", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY5` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy6` should have an upper case name [INFO] [stdout] --> src/simulator.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | op!(OP_8xy6, "SHIFT RIGHT Vx{Vb} and store LSB to VF", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY6` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy0` should have an upper case name [INFO] [stdout] --> src/simulator.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | op!(OP_8xy0, "MOVE Vy{Vc} to Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy1` should have an upper case name [INFO] [stdout] --> src/simulator.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | op!(OP_8xy1, "OR Vx{Vb} with Vy{Vc} and store to Vx", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy7` should have an upper case name [INFO] [stdout] --> src/simulator.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | op!(OP_8xy7, "SUB Vx{Vc} from Vy{Vb} and store to Vx with borrow", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY7` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy2` should have an upper case name [INFO] [stdout] --> src/simulator.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | op!(OP_8xy2, "AND Vx{Vb} with Vy{Vc} and store to Vx", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy3` should have an upper case name [INFO] [stdout] --> src/simulator.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | op!(OP_8xy3, "XOR Vx{Vb} with Vy{Vc} and store to Vx", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy4` should have an upper case name [INFO] [stdout] --> src/simulator.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | op!(OP_8xy4, "ADD Vy{Vc} to Vx{Vb} and store to Vx with carry", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY4` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy5` should have an upper case name [INFO] [stdout] --> src/simulator.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | op!(OP_8xy5, "SUB Vy{Vc} from Vx{Vb} and store to Vx with borrow", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY5` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy6` should have an upper case name [INFO] [stdout] --> src/simulator.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | op!(OP_8xy6, "SHIFT RIGHT Vx{Vb} and store LSB to VF", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY6` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xy7` should have an upper case name [INFO] [stdout] --> src/simulator.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | op!(OP_8xy7, "SUB Vx{Vc} from Vy{Vb} and store to Vx with borrow", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_8XY7` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xyE` should have an upper case name [INFO] [stdout] --> src/simulator.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | op!(OP_8xyE, "SHIFT LEFT Vx{Vb} and store MSB to VF", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_8XY_E` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_9xy0` should have an upper case name [INFO] [stdout] --> src/simulator.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | op!(OP_9xy0, "SKIP if Vx{Vb} != Vy{Vc}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_9XY0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Annn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | op!(OP_Annn, "SET I to nnn{bcd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_ANNN` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Bnnn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | op!(OP_Bnnn, "JUMP to nnn{bcd} + VO", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_BNNN` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Cxkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 167 | op!(OP_Cxkk, "RAND to Vx{Vb} and AND with kk{cd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_CXKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Dxyn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | op!(OP_Dxyn, "DRAW n{d} byte sprite at coordinates (Vx{Vb}, Vy{Vc})", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_DXYN` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Ex9E` should have an upper case name [INFO] [stdout] --> src/simulator.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | op!(OP_Ex9E, "SKIP if Vx{Vb} key is pressed", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_EX9_E` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_ExA1` should have an upper case name [INFO] [stdout] --> src/simulator.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | op!(OP_ExA1, "SKIP if Vx{Vb} key is NOT pressed", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_EX_A1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx07` should have an upper case name [INFO] [stdout] --> src/simulator.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | op!(OP_Fx07, "SET Vx{Vb} to delay_timer", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX07` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx0A` should have an upper case name [INFO] [stdout] --> src/simulator.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | op!(OP_Fx0A, "WAIT for keypress. Store key to Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_FX0_A` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx15` should have an upper case name [INFO] [stdout] --> src/simulator.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | op!(OP_Fx15, "SET delay_timer to Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX15` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx18` should have an upper case name [INFO] [stdout] --> src/simulator.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | op!(OP_Fx18, "SET sound_timer to Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX18` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx1E` should have an upper case name [INFO] [stdout] --> src/simulator.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 218 | op!(OP_Fx1E, "ADD Vx{Vb} to I and store in I", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_FX1_E` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_8xyE` should have an upper case name [INFO] [stdout] --> src/simulator.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | op!(OP_8xyE, "SHIFT LEFT Vx{Vb} and store MSB to VF", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_8XY_E` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx29` should have an upper case name [INFO] [stdout] --> src/simulator.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | op!(OP_Fx29, "SET I to location of sprite for digit stored in Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX29` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx33` should have an upper case name [INFO] [stdout] --> src/simulator.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | op!(OP_Fx33, "STORE BCD of Vx{Vb} in memory starting with address I", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX33` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_9xy0` should have an upper case name [INFO] [stdout] --> src/simulator.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | op!(OP_9xy0, "SKIP if Vx{Vb} != Vy{Vc}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_9XY0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Annn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | op!(OP_Annn, "SET I to nnn{bcd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_ANNN` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx55` should have an upper case name [INFO] [stdout] --> src/simulator.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | op!(OP_Fx55, "STORE registers V0-Vx{Vb} to mem[I]-mem[I+x]", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX55` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Bnnn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | op!(OP_Bnnn, "JUMP to nnn{bcd} + VO", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_BNNN` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx65` should have an upper case name [INFO] [stdout] --> src/simulator.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | op!(OP_Fx65, "LOAD mem[I]-mem[I+x] to registers V0-Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX65` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Cxkk` should have an upper case name [INFO] [stdout] --> src/simulator.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 167 | op!(OP_Cxkk, "RAND to Vx{Vb} and AND with kk{cd}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_CXKK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Dxyn` should have an upper case name [INFO] [stdout] --> src/simulator.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | op!(OP_Dxyn, "DRAW n{d} byte sprite at coordinates (Vx{Vb}, Vy{Vc})", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_DXYN` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Ex9E` should have an upper case name [INFO] [stdout] --> src/simulator.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | op!(OP_Ex9E, "SKIP if Vx{Vb} key is pressed", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_EX9_E` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_ExA1` should have an upper case name [INFO] [stdout] --> src/simulator.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | op!(OP_ExA1, "SKIP if Vx{Vb} key is NOT pressed", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_EX_A1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx07` should have an upper case name [INFO] [stdout] --> src/simulator.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | op!(OP_Fx07, "SET Vx{Vb} to delay_timer", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX07` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx0A` should have an upper case name [INFO] [stdout] --> src/simulator.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | op!(OP_Fx0A, "WAIT for keypress. Store key to Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_FX0_A` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx15` should have an upper case name [INFO] [stdout] --> src/simulator.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | op!(OP_Fx15, "SET delay_timer to Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX15` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx18` should have an upper case name [INFO] [stdout] --> src/simulator.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | op!(OP_Fx18, "SET sound_timer to Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX18` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx1E` should have an upper case name [INFO] [stdout] --> src/simulator.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 218 | op!(OP_Fx1E, "ADD Vx{Vb} to I and store in I", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `OP_FX1_E` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx29` should have an upper case name [INFO] [stdout] --> src/simulator.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | op!(OP_Fx29, "SET I to location of sprite for digit stored in Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX29` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx33` should have an upper case name [INFO] [stdout] --> src/simulator.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | op!(OP_Fx33, "STORE BCD of Vx{Vb} in memory starting with address I", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX33` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx55` should have an upper case name [INFO] [stdout] --> src/simulator.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | op!(OP_Fx55, "STORE registers V0-Vx{Vb} to mem[I]-mem[I+x]", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX55` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OP_Fx65` should have an upper case name [INFO] [stdout] --> src/simulator.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | op!(OP_Fx65, "LOAD mem[I]-mem[I+x] to registers V0-Vx{Vb}", |chip8: &mut Chip8, opcode: &Opcode| { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case (notice the capitalization): `OP_FX65` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 39 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chip8` (bin "chip8" test) due to 2 previous errors; 39 warnings emitted [INFO] [stdout] error: aborting due to 1 previous error; 39 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `chip8` (bin "chip8") due to 2 previous errors; 39 warnings emitted [INFO] running `Command { std: "docker" "inspect" "739d6914461e1548cc3d997714c08508c6ee97c92b58ea0e1fe40a01ef66be12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "739d6914461e1548cc3d997714c08508c6ee97c92b58ea0e1fe40a01ef66be12", kill_on_drop: false }` [INFO] [stdout] 739d6914461e1548cc3d997714c08508c6ee97c92b58ea0e1fe40a01ef66be12