[INFO] cloning repository https://github.com/JFielding7/BaseballStats [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JFielding7/BaseballStats" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJFielding7%2FBaseballStats", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJFielding7%2FBaseballStats'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b17451a6a798b8eb071c2a32d14c7106b02d44f8 [INFO] checking JFielding7/BaseballStats/b17451a6a798b8eb071c2a32d14c7106b02d44f8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJFielding7%2FBaseballStats" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JFielding7/BaseballStats on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JFielding7/BaseballStats [INFO] finished tweaking git repo https://github.com/JFielding7/BaseballStats [INFO] tweaked toml for git repo https://github.com/JFielding7/BaseballStats written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JFielding7/BaseballStats already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c830b36e693f72b11788907b6f3a9ece2d0509471373a6def717e57fd9006419 [INFO] running `Command { std: "docker" "start" "-a" "c830b36e693f72b11788907b6f3a9ece2d0509471373a6def717e57fd9006419", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c830b36e693f72b11788907b6f3a9ece2d0509471373a6def717e57fd9006419", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c830b36e693f72b11788907b6f3a9ece2d0509471373a6def717e57fd9006419", kill_on_drop: false }` [INFO] [stdout] c830b36e693f72b11788907b6f3a9ece2d0509471373a6def717e57fd9006419 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6cf0e06572bdb361ca8bc03fa85ac16a0a8415fa237c02a5d4149c803fdc9319 [INFO] running `Command { std: "docker" "start" "-a" "6cf0e06572bdb361ca8bc03fa85ac16a0a8415fa237c02a5d4149c803fdc9319", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking figlet-rs v0.1.5 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tokio v1.39.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking term-table v1.4.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking mlb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stats.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 59 | let mut player_file = File::open(file)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let mut buffer: Box<[u8]> = vec![0; line_len as usize].into_boxed_slice(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Err(EntryError(key.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stats.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 59 | let mut player_file = File::open(file)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let mut buffer: Box<[u8]> = vec![0; line_len as usize].into_boxed_slice(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Err(EntryError(key.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:195:8 [INFO] [stdout] | [INFO] [stdout] 193 | fn deserialize_stats<'de, T, D>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | where T: serde::Deserialize<'de>, D: serde::Deserializer<'de> { [INFO] [stdout] 195 | Ok(Option::::deserialize(deserializer).unwrap_or(None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:195:8 [INFO] [stdout] | [INFO] [stdout] 193 | fn deserialize_stats<'de, T, D>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | where T: serde::Deserialize<'de>, D: serde::Deserializer<'de> { [INFO] [stdout] 195 | Ok(Option::::deserialize(deserializer).unwrap_or(None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:632:9 [INFO] [stdout] | [INFO] [stdout] 632 | Err(QueryError::GameError(error_message)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:632:9 [INFO] [stdout] | [INFO] [stdout] 632 | Err(QueryError::GameError(error_message)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mlb` (bin "mlb" test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `mlb` (bin "mlb") due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "6cf0e06572bdb361ca8bc03fa85ac16a0a8415fa237c02a5d4149c803fdc9319", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cf0e06572bdb361ca8bc03fa85ac16a0a8415fa237c02a5d4149c803fdc9319", kill_on_drop: false }` [INFO] [stdout] 6cf0e06572bdb361ca8bc03fa85ac16a0a8415fa237c02a5d4149c803fdc9319