[INFO] cloning repository https://github.com/IvayloDankolov/advent-2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IvayloDankolov/advent-2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIvayloDankolov%2Fadvent-2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIvayloDankolov%2Fadvent-2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ec06cc4972996a5858aec5f95c87adc052c9dfc9 [INFO] checking IvayloDankolov/advent-2023/ec06cc4972996a5858aec5f95c87adc052c9dfc9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIvayloDankolov%2Fadvent-2023" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/IvayloDankolov/advent-2023 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/IvayloDankolov/advent-2023 [INFO] finished tweaking git repo https://github.com/IvayloDankolov/advent-2023 [INFO] tweaked toml for git repo https://github.com/IvayloDankolov/advent-2023 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/IvayloDankolov/advent-2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6fef48ee7ad7336a1ae85542ac6f0ecfe85da2506f3137735f3315e387172f31 [INFO] running `Command { std: "docker" "start" "-a" "6fef48ee7ad7336a1ae85542ac6f0ecfe85da2506f3137735f3315e387172f31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6fef48ee7ad7336a1ae85542ac6f0ecfe85da2506f3137735f3315e387172f31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fef48ee7ad7336a1ae85542ac6f0ecfe85da2506f3137735f3315e387172f31", kill_on_drop: false }` [INFO] [stdout] 6fef48ee7ad7336a1ae85542ac6f0ecfe85da2506f3137735f3315e387172f31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df0459707c56d458362014286802e387f89828c3dd2b3e5c564b2a9a319bf88d [INFO] running `Command { std: "docker" "start" "-a" "df0459707c56d458362014286802e387f89828c3dd2b3e5c564b2a9a319bf88d", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling priority-queue v1.3.2 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking advent-2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `points` is never read [INFO] [stdout] --> src/helpers/polygon.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Polygon { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 4 | points: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `iter_segments` are never used [INFO] [stdout] --> src/helpers/polygon.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl Polygon { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] 8 | fn new(points: Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | fn iter_segments(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day15p2.rs:72:30 [INFO] [stdout] | [INFO] [stdout] 72 | input.split(",").map(|s| s.parse().unwrap()).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day16p1.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 21 | fn parse_mirror_grid(input: BufReader) -> MirrorGrid { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Vec2d::from_strings(input.lines().map(|line| line.unwrap()), |c| match c { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day16p2.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 21 | fn parse_mirror_grid(input: BufReader) -> MirrorGrid { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Vec2d::from_strings(input.lines().map(|line| line.unwrap()), |c| match c { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day17p1.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 103 | fn parse_grid(input: impl BufRead) -> CityGrid { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Vec2d::from_strings( [INFO] [stdout] 105 | input.lines().map(|line| line.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day17p2.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 104 | fn parse_grid(input: impl BufRead) -> CityGrid { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Vec2d::from_strings( [INFO] [stdout] 106 | input.lines().map(|line| line.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/vec2d.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn from_strings>(strings: It, mapper: impl Fn(char) -> T) -> Option> { [INFO] [stdout] | ----------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut data = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Some(Vec2d { [INFO] [stdout] | ______________^ [INFO] [stdout] 91 | | width, [INFO] [stdout] 92 | | height, [INFO] [stdout] 93 | | data [INFO] [stdout] 94 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `points` is never read [INFO] [stdout] --> src/helpers/polygon.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Polygon { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 4 | points: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `iter_segments` are never used [INFO] [stdout] --> src/helpers/polygon.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl Polygon { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] 8 | fn new(points: Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | fn iter_segments(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day15p2.rs:72:30 [INFO] [stdout] | [INFO] [stdout] 72 | input.split(",").map(|s| s.parse().unwrap()).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day16p1.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 21 | fn parse_mirror_grid(input: BufReader) -> MirrorGrid { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Vec2d::from_strings(input.lines().map(|line| line.unwrap()), |c| match c { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day16p2.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 21 | fn parse_mirror_grid(input: BufReader) -> MirrorGrid { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Vec2d::from_strings(input.lines().map(|line| line.unwrap()), |c| match c { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day17p1.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 103 | fn parse_grid(input: impl BufRead) -> CityGrid { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Vec2d::from_strings( [INFO] [stdout] 105 | input.lines().map(|line| line.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers/day17p2.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 104 | fn parse_grid(input: impl BufRead) -> CityGrid { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Vec2d::from_strings( [INFO] [stdout] 106 | input.lines().map(|line| line.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-2023` (bin "advent-2023" test) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/vec2d.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn from_strings>(strings: It, mapper: impl Fn(char) -> T) -> Option> { [INFO] [stdout] | ----------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut data = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Some(Vec2d { [INFO] [stdout] | ______________^ [INFO] [stdout] 91 | | width, [INFO] [stdout] 92 | | height, [INFO] [stdout] 93 | | data [INFO] [stdout] 94 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-2023` (bin "advent-2023") due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "df0459707c56d458362014286802e387f89828c3dd2b3e5c564b2a9a319bf88d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df0459707c56d458362014286802e387f89828c3dd2b3e5c564b2a9a319bf88d", kill_on_drop: false }` [INFO] [stdout] df0459707c56d458362014286802e387f89828c3dd2b3e5c564b2a9a319bf88d