[INFO] cloning repository https://github.com/Iuliean/rust-minecraft-proxy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Iuliean/rust-minecraft-proxy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIuliean%2Frust-minecraft-proxy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIuliean%2Frust-minecraft-proxy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6bf64287359fcc84e0ab1ec8f2602400b729ff51 [INFO] checking Iuliean/rust-minecraft-proxy/6bf64287359fcc84e0ab1ec8f2602400b729ff51 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIuliean%2Frust-minecraft-proxy" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Iuliean/rust-minecraft-proxy on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Iuliean/rust-minecraft-proxy [INFO] finished tweaking git repo https://github.com/Iuliean/rust-minecraft-proxy [INFO] tweaked toml for git repo https://github.com/Iuliean/rust-minecraft-proxy written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Iuliean/rust-minecraft-proxy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 11a8a6bf0423dd7146a72f24def0ee5183a8ab7b90029133a16121539e392ffb [INFO] running `Command { std: "docker" "start" "-a" "11a8a6bf0423dd7146a72f24def0ee5183a8ab7b90029133a16121539e392ffb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "11a8a6bf0423dd7146a72f24def0ee5183a8ab7b90029133a16121539e392ffb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11a8a6bf0423dd7146a72f24def0ee5183a8ab7b90029133a16121539e392ffb", kill_on_drop: false }` [INFO] [stdout] 11a8a6bf0423dd7146a72f24def0ee5183a8ab7b90029133a16121539e392ffb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d27ec64b603500dba5792f971b401c180264db7d30add821297feb65855b89e [INFO] running `Command { std: "docker" "start" "-a" "4d27ec64b603500dba5792f971b401c180264db7d30add821297feb65855b89e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Checking uuid v1.2.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking rust-minecraft-proxy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `packet` [INFO] [stdout] --> src/proxy.rs:204:17 [INFO] [stdout] | [INFO] [stdout] 204 | let packet = &packet[1..]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_packet` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `packet` [INFO] [stdout] --> src/proxy.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | let packet = &packet[1..]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_packet` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/utils.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | for i in 0..size as usize{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `packet` [INFO] [stdout] --> src/proxy.rs:204:17 [INFO] [stdout] | [INFO] [stdout] 204 | let packet = &packet[1..]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_packet` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `packet` [INFO] [stdout] --> src/proxy.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | let packet = &packet[1..]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_packet` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/utils.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | for i in 0..size as usize{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_var_int_long` is never used [INFO] [stdout] --> src/utils.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn read_var_int_long(buff: &[u8]) -> Option<(i64, &[u8])>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/packets.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 112 | pub struct LoginStart{ [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 113 | player_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 114 | sig_data: bool, //if false the next 5 fields are not sent [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 115 | timestamp: Option, //true 8 bytes value [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 116 | pub_key_len: Option, //varint [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 117 | pub_key: Option>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 118 | sig_len: Option, //varint [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 119 | sig: Option>, [INFO] [stdout] | ^^^ [INFO] [stdout] 120 | has_uuid: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 121 | uuid: Option //only if has_uuid [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LoginStart` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 233 | let mc_listener = TcpListener::bind("0.0.0.0:25567") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | .expect("Cannot bind to default address: 0.0.0.0:25565"); [INFO] [stdout] 235 | let mc = mc_listener.accept().unwrap().0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let server = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | TcpStream::connect("localhost:25566").expect("Failed to connect to: localhost:25566"); [INFO] [stdout] 238 | let mc_clone = mc.try_clone().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | let server_clone = server.try_clone().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | let state = Arc::from(Mutex::from(State::Status)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let state_clone = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Proxy { [INFO] [stdout] 243 | m2p: Arc::from(Mutex::from(M2P { [INFO] [stdout] | __________________^ [INFO] [stdout] 244 | | input: mc, [INFO] [stdout] 245 | | output: server, [INFO] [stdout] 246 | | state: state, [INFO] [stdout] 247 | | login_packet_sent: RefCell::new(false) [INFO] [stdout] 248 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:249:18 [INFO] [stdout] | [INFO] [stdout] 233 | let mc_listener = TcpListener::bind("0.0.0.0:25567") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | .expect("Cannot bind to default address: 0.0.0.0:25565"); [INFO] [stdout] 235 | let mc = mc_listener.accept().unwrap().0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let server = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | TcpStream::connect("localhost:25566").expect("Failed to connect to: localhost:25566"); [INFO] [stdout] 238 | let mc_clone = mc.try_clone().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | let server_clone = server.try_clone().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | let state = Arc::from(Mutex::from(State::Status)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let state_clone = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | s2p: Arc::from(Mutex::from(S2P { [INFO] [stdout] | __________________^ [INFO] [stdout] 250 | | input: server_clone, [INFO] [stdout] 251 | | output: mc_clone, [INFO] [stdout] 252 | | state: state_clone [INFO] [stdout] 253 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-minecraft-proxy` (bin "rust-minecraft-proxy") due to 3 previous errors; 5 warnings emitted [INFO] [stdout] warning: function `read_var_int_long` is never used [INFO] [stdout] --> src/utils.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn read_var_int_long(buff: &[u8]) -> Option<(i64, &[u8])>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/packets.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 112 | pub struct LoginStart{ [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 113 | player_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 114 | sig_data: bool, //if false the next 5 fields are not sent [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 115 | timestamp: Option, //true 8 bytes value [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 116 | pub_key_len: Option, //varint [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 117 | pub_key: Option>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 118 | sig_len: Option, //varint [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 119 | sig: Option>, [INFO] [stdout] | ^^^ [INFO] [stdout] 120 | has_uuid: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 121 | uuid: Option //only if has_uuid [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LoginStart` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 233 | let mc_listener = TcpListener::bind("0.0.0.0:25567") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | .expect("Cannot bind to default address: 0.0.0.0:25565"); [INFO] [stdout] 235 | let mc = mc_listener.accept().unwrap().0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let server = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | TcpStream::connect("localhost:25566").expect("Failed to connect to: localhost:25566"); [INFO] [stdout] 238 | let mc_clone = mc.try_clone().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | let server_clone = server.try_clone().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | let state = Arc::from(Mutex::from(State::Status)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let state_clone = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Proxy { [INFO] [stdout] 243 | m2p: Arc::from(Mutex::from(M2P { [INFO] [stdout] | __________________^ [INFO] [stdout] 244 | | input: mc, [INFO] [stdout] 245 | | output: server, [INFO] [stdout] 246 | | state: state, [INFO] [stdout] 247 | | login_packet_sent: RefCell::new(false) [INFO] [stdout] 248 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:249:18 [INFO] [stdout] | [INFO] [stdout] 233 | let mc_listener = TcpListener::bind("0.0.0.0:25567") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | .expect("Cannot bind to default address: 0.0.0.0:25565"); [INFO] [stdout] 235 | let mc = mc_listener.accept().unwrap().0; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let server = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | TcpStream::connect("localhost:25566").expect("Failed to connect to: localhost:25566"); [INFO] [stdout] 238 | let mc_clone = mc.try_clone().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | let server_clone = server.try_clone().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | let state = Arc::from(Mutex::from(State::Status)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let state_clone = state.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | s2p: Arc::from(Mutex::from(S2P { [INFO] [stdout] | __________________^ [INFO] [stdout] 250 | | input: server_clone, [INFO] [stdout] 251 | | output: mc_clone, [INFO] [stdout] 252 | | state: state_clone [INFO] [stdout] 253 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-minecraft-proxy` (bin "rust-minecraft-proxy" test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4d27ec64b603500dba5792f971b401c180264db7d30add821297feb65855b89e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d27ec64b603500dba5792f971b401c180264db7d30add821297feb65855b89e", kill_on_drop: false }` [INFO] [stdout] 4d27ec64b603500dba5792f971b401c180264db7d30add821297feb65855b89e