[INFO] cloning repository https://github.com/IrvingWash/karakuri [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IrvingWash/karakuri" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIrvingWash%2Fkarakuri", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIrvingWash%2Fkarakuri'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5ec87ba904db9dd13cc1a136965789da0119d8c8 [INFO] checking IrvingWash/karakuri/5ec87ba904db9dd13cc1a136965789da0119d8c8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIrvingWash%2Fkarakuri" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/IrvingWash/karakuri on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/IrvingWash/karakuri [INFO] finished tweaking git repo https://github.com/IrvingWash/karakuri [INFO] tweaked toml for git repo https://github.com/IrvingWash/karakuri written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/IrvingWash/karakuri already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c0538099d6f5ed599d06ef16baf61b1a52768785dedb0e8ebd21a12b21855680 [INFO] running `Command { std: "docker" "start" "-a" "c0538099d6f5ed599d06ef16baf61b1a52768785dedb0e8ebd21a12b21855680", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c0538099d6f5ed599d06ef16baf61b1a52768785dedb0e8ebd21a12b21855680", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0538099d6f5ed599d06ef16baf61b1a52768785dedb0e8ebd21a12b21855680", kill_on_drop: false }` [INFO] [stdout] c0538099d6f5ed599d06ef16baf61b1a52768785dedb0e8ebd21a12b21855680 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0c5963f3f645e2d5742482740fc917d6033e018680d2fd5db8632bb990d2443c [INFO] running `Command { std: "docker" "start" "-a" "0c5963f3f645e2d5742482740fc917d6033e018680d2fd5db8632bb990d2443c", kill_on_drop: false }` [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Checking c_vec v2.0.0 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Checking karakuri v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine_impl.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 25 | let sdl = Engine::init_sdl(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | scene: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine_impl.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 25 | let sdl = Engine::init_sdl(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | renderer: Renderer::new(&sdl, &title, resolution, clear_color), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine_impl.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 25 | let sdl = Engine::init_sdl(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | fps_controller: FpsController::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 31 | | sdl.timer() [INFO] [stdout] 32 | | .unwrap_or_else(|e| panic!("Failed to get SDL2 timer: {}", e)), [INFO] [stdout] 33 | | target_fps, [INFO] [stdout] 34 | | min_update_fps, [INFO] [stdout] 35 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine_impl.rs:36:31 [INFO] [stdout] | [INFO] [stdout] 25 | let sdl = Engine::init_sdl(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | input_controller: InputController::new( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 37 | | sdl.event_pump() [INFO] [stdout] 38 | | .unwrap_or_else(|e| panic!("Failed to get SDL2 event pump: {}", e)), [INFO] [stdout] 39 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/renderer.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 18 | let window = Self::open_window(sdl, title, resolution); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | canvas: Self::create_canvas(window), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/renderer.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 203 | let video_subsystem = sdl.video().unwrap_or_else(|e| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | / video_subsystem [INFO] [stdout] 208 | | .window(title, resolution.width, resolution.height) [INFO] [stdout] 209 | | .position_centered() [INFO] [stdout] 210 | | .borderless() [INFO] [stdout] 211 | | .fullscreen_desktop() // TODO: Chang to fullscreen [INFO] [stdout] 212 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/renderer.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 218 | fn create_canvas(window: Window) -> Canvas { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | / window [INFO] [stdout] 220 | | .into_canvas() [INFO] [stdout] 221 | | .accelerated() [INFO] [stdout] 222 | | .present_vsync() [INFO] [stdout] 223 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `karakuri` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine_impl.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 25 | let sdl = Engine::init_sdl(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | scene: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine_impl.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 25 | let sdl = Engine::init_sdl(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | renderer: Renderer::new(&sdl, &title, resolution, clear_color), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine_impl.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 25 | let sdl = Engine::init_sdl(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | fps_controller: FpsController::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 31 | | sdl.timer() [INFO] [stdout] 32 | | .unwrap_or_else(|e| panic!("Failed to get SDL2 timer: {}", e)), [INFO] [stdout] 33 | | target_fps, [INFO] [stdout] 34 | | min_update_fps, [INFO] [stdout] 35 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine_impl.rs:36:31 [INFO] [stdout] | [INFO] [stdout] 25 | let sdl = Engine::init_sdl(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | input_controller: InputController::new( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 37 | | sdl.event_pump() [INFO] [stdout] 38 | | .unwrap_or_else(|e| panic!("Failed to get SDL2 event pump: {}", e)), [INFO] [stdout] 39 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/renderer.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 18 | let window = Self::open_window(sdl, title, resolution); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | canvas: Self::create_canvas(window), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/renderer.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 203 | let video_subsystem = sdl.video().unwrap_or_else(|e| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | / video_subsystem [INFO] [stdout] 208 | | .window(title, resolution.width, resolution.height) [INFO] [stdout] 209 | | .position_centered() [INFO] [stdout] 210 | | .borderless() [INFO] [stdout] 211 | | .fullscreen_desktop() // TODO: Chang to fullscreen [INFO] [stdout] 212 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/renderer.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 218 | fn create_canvas(window: Window) -> Canvas { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | / window [INFO] [stdout] 220 | | .into_canvas() [INFO] [stdout] 221 | | .accelerated() [INFO] [stdout] 222 | | .present_vsync() [INFO] [stdout] 223 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `karakuri` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "0c5963f3f645e2d5742482740fc917d6033e018680d2fd5db8632bb990d2443c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c5963f3f645e2d5742482740fc917d6033e018680d2fd5db8632bb990d2443c", kill_on_drop: false }` [INFO] [stdout] 0c5963f3f645e2d5742482740fc917d6033e018680d2fd5db8632bb990d2443c