[INFO] cloning repository https://github.com/Inityx/tetroids [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Inityx/tetroids" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FInityx%2Ftetroids", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FInityx%2Ftetroids'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 13a81c31fdbeec94d2adf43f08f6970982cf2dbe [INFO] checking Inityx/tetroids/13a81c31fdbeec94d2adf43f08f6970982cf2dbe against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FInityx%2Ftetroids" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Inityx/tetroids on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Inityx/tetroids [INFO] finished tweaking git repo https://github.com/Inityx/tetroids [INFO] tweaked toml for git repo https://github.com/Inityx/tetroids written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Inityx/tetroids already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d7dd8776567551311a734cf7d22a84c36abee6ed9ad94cafce4df5c981cfab1a [INFO] running `Command { std: "docker" "start" "-a" "d7dd8776567551311a734cf7d22a84c36abee6ed9ad94cafce4df5c981cfab1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d7dd8776567551311a734cf7d22a84c36abee6ed9ad94cafce4df5c981cfab1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7dd8776567551311a734cf7d22a84c36abee6ed9ad94cafce4df5c981cfab1a", kill_on_drop: false }` [INFO] [stdout] d7dd8776567551311a734cf7d22a84c36abee6ed9ad94cafce4df5c981cfab1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7947ca8e78db136df85fa7b550c326eaa281a4b3a5d32c77249f010212f7cdba [INFO] running `Command { std: "docker" "start" "-a" "7947ca8e78db136df85fa7b550c326eaa281a4b3a5d32c77249f010212f7cdba", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling toml v0.2.1 [INFO] [stderr] Compiling error-chain v0.10.0 [INFO] [stderr] Compiling pkg-config v0.3.9 [INFO] [stderr] Checking libc v0.2.23 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Compiling metadeps v1.1.2 [INFO] [stderr] Compiling x11 v2.14.0 [INFO] [stderr] Checking tetroids v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/gui/mod.rs:210:67 [INFO] [stdout] | [INFO] [stdout] 210 | let mut event: xlib::XKeyPressedEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/gui/mod.rs:230:53 [INFO] [stdout] | [INFO] [stdout] 230 | let mut event: xlib::XEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/gui/mod.rs:210:67 [INFO] [stdout] | [INFO] [stdout] 210 | let mut event: xlib::XKeyPressedEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/gui/mod.rs:230:53 [INFO] [stdout] | [INFO] [stdout] 230 | let mut event: xlib::XEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/game/board.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | let mut board = &mut self.data; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/game/board.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | let mut board = &mut self.data; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/gui/mod.rs:175:21 [INFO] [stdout] | [INFO] [stdout] 175 | let result = match key { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `square` [INFO] [stdout] --> src/gui/mod.rs:283:25 [INFO] [stdout] | [INFO] [stdout] 283 | if let Some(square) = square { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_square` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/gui/mod.rs:66:54 [INFO] [stdout] | [INFO] [stdout] 66 | ffi::CString::new(WINDOW_TITLE).unwrap().as_ptr(), [INFO] [stdout] | ---------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/gui/mod.rs:87:64 [INFO] [stdout] | [INFO] [stdout] 87 | ffi::CString::new("WM_DELETE_WINDOW").unwrap().as_ptr(), [INFO] [stdout] | ---------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/gui/mod.rs:94:60 [INFO] [stdout] | [INFO] [stdout] 94 | ffi::CString::new("WM_PROTOCOLS").unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------ ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/mod.rs:209:23 [INFO] [stdout] | [INFO] [stdout] 204 | &self, tick: sync::Arc> [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 210 | | let mut event: xlib::XKeyPressedEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] 211 | | // configure event [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `XKeyEvent` does not permit being left uninitialized [INFO] [stdout] --> src/gui/mod.rs:210:62 [INFO] [stdout] | [INFO] [stdout] 210 | let mut event: xlib::XKeyPressedEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `XEvent` does not permit being left uninitialized [INFO] [stdout] --> src/gui/mod.rs:230:48 [INFO] [stdout] | [INFO] [stdout] 230 | let mut event: xlib::XEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetroids` (bin "tetroids" test) due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/gui/mod.rs:175:21 [INFO] [stdout] | [INFO] [stdout] 175 | let result = match key { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `square` [INFO] [stdout] --> src/gui/mod.rs:283:25 [INFO] [stdout] | [INFO] [stdout] 283 | if let Some(square) = square { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_square` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/gui/mod.rs:66:54 [INFO] [stdout] | [INFO] [stdout] 66 | ffi::CString::new(WINDOW_TITLE).unwrap().as_ptr(), [INFO] [stdout] | ---------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/gui/mod.rs:87:64 [INFO] [stdout] | [INFO] [stdout] 87 | ffi::CString::new("WM_DELETE_WINDOW").unwrap().as_ptr(), [INFO] [stdout] | ---------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/gui/mod.rs:94:60 [INFO] [stdout] | [INFO] [stdout] 94 | ffi::CString::new("WM_PROTOCOLS").unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------ ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/mod.rs:209:23 [INFO] [stdout] | [INFO] [stdout] 204 | &self, tick: sync::Arc> [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 210 | | let mut event: xlib::XKeyPressedEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] 211 | | // configure event [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `XKeyEvent` does not permit being left uninitialized [INFO] [stdout] --> src/gui/mod.rs:210:62 [INFO] [stdout] | [INFO] [stdout] 210 | let mut event: xlib::XKeyPressedEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `XEvent` does not permit being left uninitialized [INFO] [stdout] --> src/gui/mod.rs:230:48 [INFO] [stdout] | [INFO] [stdout] 230 | let mut event: xlib::XEvent = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetroids` (bin "tetroids") due to 2 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7947ca8e78db136df85fa7b550c326eaa281a4b3a5d32c77249f010212f7cdba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7947ca8e78db136df85fa7b550c326eaa281a4b3a5d32c77249f010212f7cdba", kill_on_drop: false }` [INFO] [stdout] 7947ca8e78db136df85fa7b550c326eaa281a4b3a5d32c77249f010212f7cdba