[INFO] cloning repository https://github.com/ImageOptim/gifski [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ImageOptim/gifski" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FImageOptim%2Fgifski", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FImageOptim%2Fgifski'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f7d5638c9d322b0fa5ef6d077df27363f4e3ef72 [INFO] checking ImageOptim/gifski/f7d5638c9d322b0fa5ef6d077df27363f4e3ef72 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FImageOptim%2Fgifski" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ImageOptim/gifski on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ImageOptim/gifski [INFO] finished tweaking git repo https://github.com/ImageOptim/gifski [INFO] tweaked toml for git repo https://github.com/ImageOptim/gifski written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ImageOptim/gifski already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97ce9c09abe5bdfae6f02d822952a16a1b772bd11518f651844eb1dbe1da0965 [INFO] running `Command { std: "docker" "start" "-a" "97ce9c09abe5bdfae6f02d822952a16a1b772bd11518f651844eb1dbe1da0965", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97ce9c09abe5bdfae6f02d822952a16a1b772bd11518f651844eb1dbe1da0965", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97ce9c09abe5bdfae6f02d822952a16a1b772bd11518f651844eb1dbe1da0965", kill_on_drop: false }` [INFO] [stdout] 97ce9c09abe5bdfae6f02d822952a16a1b772bd11518f651844eb1dbe1da0965 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bbf39b689cd680404da28bc4bef42d2cbad14372d8fe40ef8a6f6033fe1deb6a [INFO] running `Command { std: "docker" "start" "-a" "bbf39b689cd680404da28bc4bef42d2cbad14372d8fe40ef8a6f6033fe1deb6a", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking natord v1.0.9 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking wild v2.2.1 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking gif-dispose v5.0.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking lodepng v3.10.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking ordered-channel v1.1.0 [INFO] [stderr] Checking pbr v1.1.1 [INFO] [stderr] Checking yuv v0.1.8 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking imagequant v4.3.3 [INFO] [stderr] Checking resize v0.8.7 [INFO] [stderr] Checking gifski v1.32.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:8 [INFO] [stdout] | [INFO] [stdout] 254 | let (queue, queue_iter) = crossbeam_channel::bounded(5.min(max_threads.into())); // should be sufficient for denoiser lookahead [INFO] [stdout] | ----- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 256 | | Collector { [INFO] [stdout] 257 | | queue, [INFO] [stdout] 258 | | }, [INFO] [stdout] ... | [INFO] [stdout] 270 | | }, [INFO] [stdout] 271 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:504:12 [INFO] [stdout] | [INFO] [stdout] 452 | let mut liq = Attributes::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 469 | let mut img = liq.new_image(buf, width, height, 0.)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | let mut res = liq.quantize(&mut img)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | Ok((liq, res, img, out)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:521:137 [INFO] [stdout] | [INFO] [stdout] 519 | fn write_frames(&self, write_queue: Receiver, writer: &mut dyn Write, reporter: &mut dyn ProgressReporter) -> CatResult<()... [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | let (lzw_queue, lzw_recv) = ordqueue_new(2); [INFO] [stdout] | --------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 521 | minipool::new_scope((if self.settings.s.fast || self.settings.gifsicle_loss() > 0 { 3 } else { 1 }).try_into().unwrap(), "lzw", move... [INFO] [stdout] | _________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 522 | | let mut pts_in_delay_units = 0_u64; [INFO] [stdout] 523 | | [INFO] [stdout] 524 | | let written = Rc::new(Cell::new(0)); [INFO] [stdout] ... | [INFO] [stdout] 552 | | } [INFO] [stdout] 553 | | }, move |abort| { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 519 | fn write_frames(&self, write_queue: Receiver, writer: &mut dyn Write, reporter: &mut dyn ProgressReporter) -> CatResult... [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | let (lzw_queue, lzw_recv) = ordqueue_new(2); [INFO] [stdout] | --------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | }, move |abort| { [INFO] [stdout] | ____________^ [INFO] [stdout] 554 | | for FrameMessage {frame, frame_index, ordinal_frame_number, end_pts, screen_width, screen_height } in write_queue { [INFO] [stdout] 555 | | if abort.load(Relaxed) { [INFO] [stdout] 556 | | return Err(Error::Aborted); [INFO] [stdout] ... | [INFO] [stdout] 562 | | Ok(()) [INFO] [stdout] 563 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:579:23 [INFO] [stdout] | [INFO] [stdout] 578 | fn write_inner(&self, decode_queue_recv: Receiver, writer: &mut dyn Write, reporter: &mut dyn ProgressReporter) -> CatRes... [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | thread::scope(|s| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 580 | | let (diff_queue, diff_queue_recv) = ordqueue_new(0); [INFO] [stdout] 581 | | let resize_thread = thread::Builder::new().name("resize".into()).spawn_scoped(s, move || { [INFO] [stdout] 582 | | self.make_resize(decode_queue_recv, diff_queue) [INFO] [stdout] ... | [INFO] [stdout] 601 | | combine_res(combine_res(combine_res(res0, res1), combine_res(res2, res3)), res4) [INFO] [stdout] 602 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:601:25 [INFO] [stdout] | [INFO] [stdout] 578 | fn write_inner(&self, decode_queue_recv: Receiver, writer: &mut dyn Write, reporter: &mut dyn ProgressReporter) -> CatRes... [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | thread::scope(|s| { [INFO] [stdout] 580 | let (diff_queue, diff_queue_recv) = ordqueue_new(0); [INFO] [stdout] | ---------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 581 | let resize_thread = thread::Builder::new().name("resize".into()).spawn_scoped(s, move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 584 | let (quant_queue, quant_queue_recv) = crossbeam_channel::bounded(0); [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 585 | let diff_thread = thread::Builder::new().name("diff".into()).spawn_scoped(s, move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | let (remap_queue, remap_queue_recv) = ordqueue_new(0); [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | let quant_thread = thread::Builder::new().name("quant".into()).spawn_scoped(s, move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 592 | let (write_queue, write_queue_recv) = crossbeam_channel::bounded(0); [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 593 | let remap_thread = thread::Builder::new().name("remap".into()).spawn_scoped(s, move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 596 | let res0 = self.write_frames(write_queue_recv, writer, reporter); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 597 | let res1 = resize_thread.join().map_err(handle_join_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 598 | let res2 = diff_thread.join().map_err(handle_join_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 599 | let res3 = quant_thread.join().map_err(handle_join_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 600 | let res4 = remap_thread.join().map_err(handle_join_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 601 | combine_res(combine_res(combine_res(res0, res1), combine_res(res2, res3)), res4) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:609:12 [INFO] [stdout] | [INFO] [stdout] 606 | fn make_resize(&self, inputs: Receiver, diff_queue: OrdQueue) -> CatResult<()> { [INFO] [stdout] | ---------------------------- --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 609 | }, move |abort| { [INFO] [stdout] | ____________^ [INFO] [stdout] 610 | | for frame in inputs { [INFO] [stdout] 611 | | if abort.load(Relaxed) { [INFO] [stdout] 612 | | return Err(Error::Aborted); [INFO] [stdout] ... | [INFO] [stdout] 637 | | Ok(()) [INFO] [stdout] 638 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:709:86 [INFO] [stdout] | [INFO] [stdout] 708 | fn quantize_frames(&self, inputs: Receiver, remap_queue: OrdQueue) -> CatResult<()> { [INFO] [stdout] | ----------------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 709 | minipool::new_channel(self.settings.max_threads.min(4.try_into()?), "quant", move |quant_queue| { [INFO] [stdout] | ______________________________________________________________________________________^ [INFO] [stdout] 710 | | let mut inputs = inputs.into_iter(); [INFO] [stdout] 711 | | let next_frame = inputs.next().ok_or(Error::NoFrames)?; [INFO] [stdout] ... | [INFO] [stdout] 771 | | Ok(()) [INFO] [stdout] 772 | | }, move |QuantizeMessage { end_pts, mut image, importance_map, ordinal_frame_number, frame_index, dispose, first_frame_has_transp... [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:772:12 [INFO] [stdout] | [INFO] [stdout] 708 | fn quantize_frames(&self, inputs: Receiver, remap_queue: OrdQueue) -> CatResult<()> { [INFO] [stdout] | ----------------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 772 | }, move |QuantizeMessage { end_pts, mut image, importance_map, ordinal_frame_number, frame_index, dispose, first_frame_has_transp... [INFO] [stdout] | ____________^ [INFO] [stdout] 773 | | if prev_frame_keeps { [INFO] [stdout] 774 | | // if denoiser says the background didn't change, then believe it [INFO] [stdout] 775 | | // (except higher quality settings, which try to improve it every time) [INFO] [stdout] ... | [INFO] [stdout] 793 | | })?) [INFO] [stdout] 794 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:889:11 [INFO] [stdout] | [INFO] [stdout] 887 | fn combine_res(res1: Result<(), Error>, res2: Result<(), Error>) -> Result<(), Error> { [INFO] [stdout] | ----------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 888 | use Error::*; [INFO] [stdout] 889 | match (res1, res2) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/c_api.rs:452:11 [INFO] [stdout] | [INFO] [stdout] 447 | let t = g.write_thread.lock().map_err(|_| GifskiError::THREAD_LOST)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | match File::create(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/c_api.rs:561:5 [INFO] [stdout] | [INFO] [stdout] 560 | let g = Arc::from_raw(g.cast::()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 561 | / catch_unwind(|| { [INFO] [stdout] 562 | | match g.collector.lock() { [INFO] [stdout] 563 | | // dropping of the collector (if any) completes writing [INFO] [stdout] 564 | | Ok(mut lock) => *lock = None, [INFO] [stdout] ... | [INFO] [stdout] 580 | | } [INFO] [stdout] 581 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/c_api.rs:582:14 [INFO] [stdout] | [INFO] [stdout] 560 | let g = Arc::from_raw(g.cast::()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 582 | .map_err(move |e| g.print_panic(e)).unwrap_or(GifskiError::THREAD_LOST) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoderust.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(writer: W, written: Rc>) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | writer: Some(writer), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoderust.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(writer: W, written: Rc>) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | gif_enc: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minipool.rs:14:34 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new_channel(num_threads: NonZeroU8, name: &str, producer: P, mut consumer: C) -> Result where [INFO] [stdout] | ----------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | let (s, r) = crossbeam_channel::bounded(2); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | new_scope(num_threads, name, move || producer(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minipool.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new_channel(num_threads: NonZeroU8, name: &str, producer: P, mut consumer: C) -> Result where [INFO] [stdout] | ----------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | let (s, r) = crossbeam_channel::bounded(2); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | new_scope(num_threads, name, move || producer(s), [INFO] [stdout] 15 | / move |should_abort| { [INFO] [stdout] 16 | | for m in r { [INFO] [stdout] 17 | | if should_abort.load(Relaxed) { [INFO] [stdout] 18 | | break; [INFO] [stdout] ... | [INFO] [stdout] 22 | | Ok(()) [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minipool.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new_scope(num_threads: NonZeroU8, name: &str, waiter: P, consumer: C) -> Result where [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | std::thread::scope(move |scope| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 32 | | let thread = move || { [INFO] [stdout] 33 | | catch_unwind(move || consumer(failed)) [INFO] [stdout] 34 | | .map_err(|_| Error::ThreadSend).and_then(|x| x) [INFO] [stdout] ... | [INFO] [stdout] 56 | | res [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minipool.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new_scope(num_threads: NonZeroU8, name: &str, waiter: P, consumer: C) -> Result where [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | / catch_unwind(move || consumer(failed)) [INFO] [stdout] 34 | | .map_err(|_| Error::ThreadSend).and_then(|x| x) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gifski` (lib) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:8 [INFO] [stdout] | [INFO] [stdout] 254 | let (queue, queue_iter) = crossbeam_channel::bounded(5.min(max_threads.into())); // should be sufficient for denoiser lookahead [INFO] [stdout] | ----- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 256 | | Collector { [INFO] [stdout] 257 | | queue, [INFO] [stdout] 258 | | }, [INFO] [stdout] ... | [INFO] [stdout] 270 | | }, [INFO] [stdout] 271 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:504:12 [INFO] [stdout] | [INFO] [stdout] 452 | let mut liq = Attributes::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 469 | let mut img = liq.new_image(buf, width, height, 0.)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | let mut res = liq.quantize(&mut img)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | Ok((liq, res, img, out)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:521:137 [INFO] [stdout] | [INFO] [stdout] 519 | fn write_frames(&self, write_queue: Receiver, writer: &mut dyn Write, reporter: &mut dyn ProgressReporter) -> CatResult<()... [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | let (lzw_queue, lzw_recv) = ordqueue_new(2); [INFO] [stdout] | --------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 521 | minipool::new_scope((if self.settings.s.fast || self.settings.gifsicle_loss() > 0 { 3 } else { 1 }).try_into().unwrap(), "lzw", move... [INFO] [stdout] | _________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 522 | | let mut pts_in_delay_units = 0_u64; [INFO] [stdout] 523 | | [INFO] [stdout] 524 | | let written = Rc::new(Cell::new(0)); [INFO] [stdout] ... | [INFO] [stdout] 552 | | } [INFO] [stdout] 553 | | }, move |abort| { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 519 | fn write_frames(&self, write_queue: Receiver, writer: &mut dyn Write, reporter: &mut dyn ProgressReporter) -> CatResult... [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | let (lzw_queue, lzw_recv) = ordqueue_new(2); [INFO] [stdout] | --------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | }, move |abort| { [INFO] [stdout] | ____________^ [INFO] [stdout] 554 | | for FrameMessage {frame, frame_index, ordinal_frame_number, end_pts, screen_width, screen_height } in write_queue { [INFO] [stdout] 555 | | if abort.load(Relaxed) { [INFO] [stdout] 556 | | return Err(Error::Aborted); [INFO] [stdout] ... | [INFO] [stdout] 562 | | Ok(()) [INFO] [stdout] 563 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:579:23 [INFO] [stdout] | [INFO] [stdout] 578 | fn write_inner(&self, decode_queue_recv: Receiver, writer: &mut dyn Write, reporter: &mut dyn ProgressReporter) -> CatRes... [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | thread::scope(|s| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 580 | | let (diff_queue, diff_queue_recv) = ordqueue_new(0); [INFO] [stdout] 581 | | let resize_thread = thread::Builder::new().name("resize".into()).spawn_scoped(s, move || { [INFO] [stdout] 582 | | self.make_resize(decode_queue_recv, diff_queue) [INFO] [stdout] ... | [INFO] [stdout] 601 | | combine_res(combine_res(combine_res(res0, res1), combine_res(res2, res3)), res4) [INFO] [stdout] 602 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:601:25 [INFO] [stdout] | [INFO] [stdout] 578 | fn write_inner(&self, decode_queue_recv: Receiver, writer: &mut dyn Write, reporter: &mut dyn ProgressReporter) -> CatRes... [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | thread::scope(|s| { [INFO] [stdout] 580 | let (diff_queue, diff_queue_recv) = ordqueue_new(0); [INFO] [stdout] | ---------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 581 | let resize_thread = thread::Builder::new().name("resize".into()).spawn_scoped(s, move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 584 | let (quant_queue, quant_queue_recv) = crossbeam_channel::bounded(0); [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 585 | let diff_thread = thread::Builder::new().name("diff".into()).spawn_scoped(s, move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | let (remap_queue, remap_queue_recv) = ordqueue_new(0); [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | let quant_thread = thread::Builder::new().name("quant".into()).spawn_scoped(s, move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 592 | let (write_queue, write_queue_recv) = crossbeam_channel::bounded(0); [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 593 | let remap_thread = thread::Builder::new().name("remap".into()).spawn_scoped(s, move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 596 | let res0 = self.write_frames(write_queue_recv, writer, reporter); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 597 | let res1 = resize_thread.join().map_err(handle_join_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 598 | let res2 = diff_thread.join().map_err(handle_join_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 599 | let res3 = quant_thread.join().map_err(handle_join_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 600 | let res4 = remap_thread.join().map_err(handle_join_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 601 | combine_res(combine_res(combine_res(res0, res1), combine_res(res2, res3)), res4) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:609:12 [INFO] [stdout] | [INFO] [stdout] 606 | fn make_resize(&self, inputs: Receiver, diff_queue: OrdQueue) -> CatResult<()> { [INFO] [stdout] | ---------------------------- --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 609 | }, move |abort| { [INFO] [stdout] | ____________^ [INFO] [stdout] 610 | | for frame in inputs { [INFO] [stdout] 611 | | if abort.load(Relaxed) { [INFO] [stdout] 612 | | return Err(Error::Aborted); [INFO] [stdout] ... | [INFO] [stdout] 637 | | Ok(()) [INFO] [stdout] 638 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:709:86 [INFO] [stdout] | [INFO] [stdout] 708 | fn quantize_frames(&self, inputs: Receiver, remap_queue: OrdQueue) -> CatResult<()> { [INFO] [stdout] | ----------------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 709 | minipool::new_channel(self.settings.max_threads.min(4.try_into()?), "quant", move |quant_queue| { [INFO] [stdout] | ______________________________________________________________________________________^ [INFO] [stdout] 710 | | let mut inputs = inputs.into_iter(); [INFO] [stdout] 711 | | let next_frame = inputs.next().ok_or(Error::NoFrames)?; [INFO] [stdout] ... | [INFO] [stdout] 771 | | Ok(()) [INFO] [stdout] 772 | | }, move |QuantizeMessage { end_pts, mut image, importance_map, ordinal_frame_number, frame_index, dispose, first_frame_has_transp... [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:772:12 [INFO] [stdout] | [INFO] [stdout] 708 | fn quantize_frames(&self, inputs: Receiver, remap_queue: OrdQueue) -> CatResult<()> { [INFO] [stdout] | ----------------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 772 | }, move |QuantizeMessage { end_pts, mut image, importance_map, ordinal_frame_number, frame_index, dispose, first_frame_has_transp... [INFO] [stdout] | ____________^ [INFO] [stdout] 773 | | if prev_frame_keeps { [INFO] [stdout] 774 | | // if denoiser says the background didn't change, then believe it [INFO] [stdout] 775 | | // (except higher quality settings, which try to improve it every time) [INFO] [stdout] ... | [INFO] [stdout] 793 | | })?) [INFO] [stdout] 794 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:889:11 [INFO] [stdout] | [INFO] [stdout] 887 | fn combine_res(res1: Result<(), Error>, res2: Result<(), Error>) -> Result<(), Error> { [INFO] [stdout] | ----------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 888 | use Error::*; [INFO] [stdout] 889 | match (res1, res2) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/c_api.rs:452:11 [INFO] [stdout] | [INFO] [stdout] 447 | let t = g.write_thread.lock().map_err(|_| GifskiError::THREAD_LOST)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | match File::create(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/c_api.rs:561:5 [INFO] [stdout] | [INFO] [stdout] 560 | let g = Arc::from_raw(g.cast::()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 561 | / catch_unwind(|| { [INFO] [stdout] 562 | | match g.collector.lock() { [INFO] [stdout] 563 | | // dropping of the collector (if any) completes writing [INFO] [stdout] 564 | | Ok(mut lock) => *lock = None, [INFO] [stdout] ... | [INFO] [stdout] 580 | | } [INFO] [stdout] 581 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/c_api.rs:582:14 [INFO] [stdout] | [INFO] [stdout] 560 | let g = Arc::from_raw(g.cast::()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 582 | .map_err(move |e| g.print_panic(e)).unwrap_or(GifskiError::THREAD_LOST) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoderust.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(writer: W, written: Rc>) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | writer: Some(writer), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoderust.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(writer: W, written: Rc>) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | gif_enc: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minipool.rs:14:34 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new_channel(num_threads: NonZeroU8, name: &str, producer: P, mut consumer: C) -> Result where [INFO] [stdout] | ----------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | let (s, r) = crossbeam_channel::bounded(2); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | new_scope(num_threads, name, move || producer(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minipool.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new_channel(num_threads: NonZeroU8, name: &str, producer: P, mut consumer: C) -> Result where [INFO] [stdout] | ----------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | let (s, r) = crossbeam_channel::bounded(2); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | new_scope(num_threads, name, move || producer(s), [INFO] [stdout] 15 | / move |should_abort| { [INFO] [stdout] 16 | | for m in r { [INFO] [stdout] 17 | | if should_abort.load(Relaxed) { [INFO] [stdout] 18 | | break; [INFO] [stdout] ... | [INFO] [stdout] 22 | | Ok(()) [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minipool.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new_scope(num_threads: NonZeroU8, name: &str, waiter: P, consumer: C) -> Result where [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | std::thread::scope(move |scope| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 32 | | let thread = move || { [INFO] [stdout] 33 | | catch_unwind(move || consumer(failed)) [INFO] [stdout] 34 | | .map_err(|_| Error::ThreadSend).and_then(|x| x) [INFO] [stdout] ... | [INFO] [stdout] 56 | | res [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minipool.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new_scope(num_threads: NonZeroU8, name: &str, waiter: P, consumer: C) -> Result where [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | / catch_unwind(move || consumer(failed)) [INFO] [stdout] 34 | | .map_err(|_| Error::ThreadSend).and_then(|x| x) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gifski` (lib test) due to 20 previous errors [INFO] running `Command { std: "docker" "inspect" "bbf39b689cd680404da28bc4bef42d2cbad14372d8fe40ef8a6f6033fe1deb6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbf39b689cd680404da28bc4bef42d2cbad14372d8fe40ef8a6f6033fe1deb6a", kill_on_drop: false }` [INFO] [stdout] bbf39b689cd680404da28bc4bef42d2cbad14372d8fe40ef8a6f6033fe1deb6a