[INFO] cloning repository https://github.com/IanS5/rush [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IanS5/rush" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIanS5%2Frush", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIanS5%2Frush'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6a97536f28040d30cb896d74b5a7ab84bb1117dc [INFO] checking IanS5/rush/6a97536f28040d30cb896d74b5a7ab84bb1117dc against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIanS5%2Frush" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/IanS5/rush on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/IanS5/rush [INFO] finished tweaking git repo https://github.com/IanS5/rush [INFO] tweaked toml for git repo https://github.com/IanS5/rush written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/IanS5/rush already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd5ff3cb2a9ff14ab70f4626e53300f46cf4e7dc234451f68cbd4b20986d14c1 [INFO] running `Command { std: "docker" "start" "-a" "dd5ff3cb2a9ff14ab70f4626e53300f46cf4e7dc234451f68cbd4b20986d14c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd5ff3cb2a9ff14ab70f4626e53300f46cf4e7dc234451f68cbd4b20986d14c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd5ff3cb2a9ff14ab70f4626e53300f46cf4e7dc234451f68cbd4b20986d14c1", kill_on_drop: false }` [INFO] [stdout] dd5ff3cb2a9ff14ab70f4626e53300f46cf4e7dc234451f68cbd4b20986d14c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d5dbd7e4fd3ce79607ec4a75569a1a68b0c2b143c75512f4fe122a9a730f1e69 [INFO] running `Command { std: "docker" "start" "-a" "d5dbd7e4fd3ce79607ec4a75569a1a68b0c2b143c75512f4fe122a9a730f1e69", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Compiling cc v1.0.18 [INFO] [stderr] Checking cfg-if v0.1.5 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Compiling nix v0.11.0 [INFO] [stderr] Checking rustc-demangle v0.1.8 [INFO] [stderr] Checking bitflags v1.0.3 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking nixterm v0.1.2 [INFO] [stderr] Checking rush v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/env/traps.rs:10:46 [INFO] [stdout] | [INFO] [stdout] 10 | static ref GLOBAL_TRAPS: RwLock = { RwLock::new(Traps::with_capacity(31)) }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 10 - static ref GLOBAL_TRAPS: RwLock = { RwLock::new(Traps::with_capacity(31)) }; [INFO] [stdout] 10 + static ref GLOBAL_TRAPS: RwLock = RwLock::new(Traps::with_capacity(31)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | / /// eat any string of valid non-newline whitespace characters [INFO] [stdout] 11 | | /// Characters Recognized as Whitespace: [INFO] [stdout] 12 | | /// - \t (tab) [INFO] [stdout] 13 | | /// - \ (space) [INFO] [stdout] | |_---------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | /// Line endings are whitespace that move the cursor to the next line [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / /// A conditional can join two commands, depending on the result of the prior command the second may not be executed [INFO] [stdout] 33 | | /// [INFO] [stdout] 34 | | /// Supported conditional operators [INFO] [stdout] 35 | | /// - && - proceed only if the last command was successful [INFO] [stdout] 36 | | /// - || - proceed only if the last command failed [INFO] [stdout] | |_-------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:45:1 [INFO] [stdout] | [INFO] [stdout] 45 | / /// IO Operators can modify the modify the file descriptor table, close, open, read, and write to files. [INFO] [stdout] 46 | | /// [INFO] [stdout] 47 | | /// IO operations appear after a command, they are optionally proceeded by a file descriptor, and may be followed by several different ty... [INFO] [stdout] 48 | | /// [INFO] [stdout] ... | [INFO] [stdout] 57 | | /// - <& - Duplicate an input file descriptor (basically just the dup2 systemcall) [INFO] [stdout] 58 | | /// - <> - Open a file for reading an writing [INFO] [stdout] | |_--------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:74:1 [INFO] [stdout] | [INFO] [stdout] 74 | /// Pipes connect a command's standard out to another command's standard in [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:80:1 [INFO] [stdout] | [INFO] [stdout] 80 | / /// A separator splits WORDS into commands when they are on the same line [INFO] [stdout] 81 | | /// [INFO] [stdout] 82 | | /// For example `echo hello; echo hi` prints "hellohi" [INFO] [stdout] 83 | | /// while `echo hello echo hi` prints "hello echo hi" [INFO] [stdout] 84 | | /// Supported Separators [INFO] [stdout] 85 | | /// - ; Acts a newline [INFO] [stdout] 86 | | /// - & same as `;`, but asynchronously calls the previous command [INFO] [stdout] | |_-----------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:95:1 [INFO] [stdout] | [INFO] [stdout] 95 | /// An io number is the file descriptor that comes before the an IO operator [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lang::parser` [INFO] [stdout] --> src/shell/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use lang::parser; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/shell/mod.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/env/traps.rs:10:46 [INFO] [stdout] | [INFO] [stdout] 10 | static ref GLOBAL_TRAPS: RwLock = { RwLock::new(Traps::with_capacity(31)) }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 10 - static ref GLOBAL_TRAPS: RwLock = { RwLock::new(Traps::with_capacity(31)) }; [INFO] [stdout] 10 + static ref GLOBAL_TRAPS: RwLock = RwLock::new(Traps::with_capacity(31)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | / /// eat any string of valid non-newline whitespace characters [INFO] [stdout] 11 | | /// Characters Recognized as Whitespace: [INFO] [stdout] 12 | | /// - \t (tab) [INFO] [stdout] 13 | | /// - \ (space) [INFO] [stdout] | |_---------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | /// Line endings are whitespace that move the cursor to the next line [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / /// A conditional can join two commands, depending on the result of the prior command the second may not be executed [INFO] [stdout] 33 | | /// [INFO] [stdout] 34 | | /// Supported conditional operators [INFO] [stdout] 35 | | /// - && - proceed only if the last command was successful [INFO] [stdout] 36 | | /// - || - proceed only if the last command failed [INFO] [stdout] | |_-------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:45:1 [INFO] [stdout] | [INFO] [stdout] 45 | / /// IO Operators can modify the modify the file descriptor table, close, open, read, and write to files. [INFO] [stdout] 46 | | /// [INFO] [stdout] 47 | | /// IO operations appear after a command, they are optionally proceeded by a file descriptor, and may be followed by several different ty... [INFO] [stdout] 48 | | /// [INFO] [stdout] ... | [INFO] [stdout] 57 | | /// - <& - Duplicate an input file descriptor (basically just the dup2 systemcall) [INFO] [stdout] 58 | | /// - <> - Open a file for reading an writing [INFO] [stdout] | |_--------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:74:1 [INFO] [stdout] | [INFO] [stdout] 74 | /// Pipes connect a command's standard out to another command's standard in [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:80:1 [INFO] [stdout] | [INFO] [stdout] 80 | / /// A separator splits WORDS into commands when they are on the same line [INFO] [stdout] 81 | | /// [INFO] [stdout] 82 | | /// For example `echo hello; echo hi` prints "hellohi" [INFO] [stdout] 83 | | /// while `echo hello echo hi` prints "hello echo hi" [INFO] [stdout] 84 | | /// Supported Separators [INFO] [stdout] 85 | | /// - ; Acts a newline [INFO] [stdout] 86 | | /// - & same as `;`, but asynchronously calls the previous command [INFO] [stdout] | |_-----------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lang/parser.rs:95:1 [INFO] [stdout] | [INFO] [stdout] 95 | /// An io number is the file descriptor that comes before the an IO operator [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lang::parser` [INFO] [stdout] --> src/shell/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use lang::parser; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/shell/mod.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `failure::core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/env/traps.rs:101:14 [INFO] [stdout] | [INFO] [stdout] 101 | .trim_left_matches("SIG") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 101 | .trim_start_matches("SIG") [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `failure::core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/env/traps.rs:101:14 [INFO] [stdout] | [INFO] [stdout] 101 | .trim_left_matches("SIG") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 101 | .trim_start_matches("SIG") [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `environ` [INFO] [stdout] --> src/shell/mod.rs:89:32 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn readline(&mut self, environ: &mut lang::ExecutionContext) -> nixterm::Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_environ` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env/functions.rs:95:27 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn insert>(mut self, value: T) -> Value { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | self.entry.insert(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env/functions.rs:109:27 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn insert>(self, value: T) -> &'a mut Value { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | self.entry.insert(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr/mod.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn eval>(s: T, vars: &mut Variables) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Ok(parse(s.as_ref())?.evaluate(vars).to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr/parser.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 100 | let mut left = match self.next_token()? { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let new_left = self.must_parse_precedence(Precedence::Parentheses)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(Some(left)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jobs/spawn.rs:327:29 [INFO] [stdout] | [INFO] [stdout] 322 | FdOp::Open(path, mode) => open_and_dup(path, *mode, *fd).map_err(|source| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | source: Box::new(source), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 143 | fn from(s: T) -> Command { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | commandline(CompleteStr(s.as_ref())).unwrap().1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:156:27 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn pipeline(bang: bool, source: Command, dest: Command) -> Command { [INFO] [stdout] | --------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Command::Pipeline(Box::new(Pipeline { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 157 | | bang: bang, [INFO] [stdout] 158 | | from: source, [INFO] [stdout] 159 | | to: dest, [INFO] [stdout] 160 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:164:34 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn conditional(left: Command, infix: ConditionOperator, right: Command) -> Command { [INFO] [stdout] | ------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | Command::ConditionalPair(Box::new(ConditionalPair { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 165 | | left: left, [INFO] [stdout] 166 | | operator: infix, [INFO] [stdout] 167 | | right: right, [INFO] [stdout] 168 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:172:31 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn redirect(source: Command, redir: Vec) -> Command { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Command::FileRedirect(Box::new(FileRedirect { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 173 | | left: source, [INFO] [stdout] 174 | | redirects: redir, [INFO] [stdout] 175 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:179:24 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn group(source: Vec) -> Command { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | Command::Group(Box::new(CommandGroup { commands: source })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/exec.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 300 | pub fn find_executable>(&self, prog: S) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | Err(Error::from(ErrorKind::MissingExecutable(owned_prog))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/word.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 143 | fn from(v: T) -> Word { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | Word { [INFO] [stdout] 145 | parts: v.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/mod.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | let t = nixterm::Term::new()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(Shell { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | command_buffer: String::new(), [INFO] [stdout] 25 | | history: Vec::new(), [INFO] [stdout] 26 | | exit: false, [INFO] [stdout] 27 | | old_settings: t.settings(), [INFO] [stdout] 28 | | term: t, [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/shell/mod.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | / self.term [INFO] [stdout] 99 | | .writer() [INFO] [stdout] 100 | | .shift_cursor(xoffset - backtrack, 0) [INFO] [stdout] 101 | | .done(); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 98 | let _ = self.term [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/shell/mod.rs:106:25 [INFO] [stdout] | [INFO] [stdout] 106 | / self.term [INFO] [stdout] 107 | | .writer() [INFO] [stdout] 108 | | .print(&self.command_buffer) [INFO] [stdout] 109 | | .print("exit") [INFO] [stdout] 110 | | .done(); [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 106 | let _ = self.term [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/shell/mod.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | / self.term [INFO] [stdout] 116 | | .writer() [INFO] [stdout] 117 | | .print(&self.command_buffer) [INFO] [stdout] 118 | | .print("^C") [INFO] [stdout] 119 | | .done(); [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = self.term [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/shell/mod.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | self.term.update(self.old_settings.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 170 | let _ = self.term.update(self.old_settings.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rush` (bin "rush") due to 14 previous errors; 16 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `environ` [INFO] [stdout] --> src/shell/mod.rs:89:32 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn readline(&mut self, environ: &mut lang::ExecutionContext) -> nixterm::Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_environ` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env/functions.rs:95:27 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn insert>(mut self, value: T) -> Value { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | self.entry.insert(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env/functions.rs:109:27 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn insert>(self, value: T) -> &'a mut Value { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | self.entry.insert(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr/mod.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn eval>(s: T, vars: &mut Variables) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Ok(parse(s.as_ref())?.evaluate(vars).to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr/parser.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 100 | let mut left = match self.next_token()? { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let new_left = self.must_parse_precedence(Precedence::Parentheses)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(Some(left)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jobs/spawn.rs:327:29 [INFO] [stdout] | [INFO] [stdout] 322 | FdOp::Open(path, mode) => open_and_dup(path, *mode, *fd).map_err(|source| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | source: Box::new(source), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 143 | fn from(s: T) -> Command { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | commandline(CompleteStr(s.as_ref())).unwrap().1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:156:27 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn pipeline(bang: bool, source: Command, dest: Command) -> Command { [INFO] [stdout] | --------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Command::Pipeline(Box::new(Pipeline { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 157 | | bang: bang, [INFO] [stdout] 158 | | from: source, [INFO] [stdout] 159 | | to: dest, [INFO] [stdout] 160 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:164:34 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn conditional(left: Command, infix: ConditionOperator, right: Command) -> Command { [INFO] [stdout] | ------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | Command::ConditionalPair(Box::new(ConditionalPair { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 165 | | left: left, [INFO] [stdout] 166 | | operator: infix, [INFO] [stdout] 167 | | right: right, [INFO] [stdout] 168 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:172:31 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn redirect(source: Command, redir: Vec) -> Command { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Command::FileRedirect(Box::new(FileRedirect { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 173 | | left: source, [INFO] [stdout] 174 | | redirects: redir, [INFO] [stdout] 175 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/ast.rs:179:24 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn group(source: Vec) -> Command { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | Command::Group(Box::new(CommandGroup { commands: source })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/exec.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 300 | pub fn find_executable>(&self, prog: S) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | Err(Error::from(ErrorKind::MissingExecutable(owned_prog))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/word.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 143 | fn from(v: T) -> Word { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | Word { [INFO] [stdout] 145 | parts: v.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/mod.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | let t = nixterm::Term::new()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(Shell { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | command_buffer: String::new(), [INFO] [stdout] 25 | | history: Vec::new(), [INFO] [stdout] 26 | | exit: false, [INFO] [stdout] 27 | | old_settings: t.settings(), [INFO] [stdout] 28 | | term: t, [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/shell/mod.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | / self.term [INFO] [stdout] 99 | | .writer() [INFO] [stdout] 100 | | .shift_cursor(xoffset - backtrack, 0) [INFO] [stdout] 101 | | .done(); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 98 | let _ = self.term [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/shell/mod.rs:106:25 [INFO] [stdout] | [INFO] [stdout] 106 | / self.term [INFO] [stdout] 107 | | .writer() [INFO] [stdout] 108 | | .print(&self.command_buffer) [INFO] [stdout] 109 | | .print("exit") [INFO] [stdout] 110 | | .done(); [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 106 | let _ = self.term [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/shell/mod.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | / self.term [INFO] [stdout] 116 | | .writer() [INFO] [stdout] 117 | | .print(&self.command_buffer) [INFO] [stdout] 118 | | .print("^C") [INFO] [stdout] 119 | | .done(); [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = self.term [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/shell/mod.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | self.term.update(self.old_settings.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 170 | let _ = self.term.update(self.old_settings.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rush` (bin "rush" test) due to 14 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d5dbd7e4fd3ce79607ec4a75569a1a68b0c2b143c75512f4fe122a9a730f1e69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5dbd7e4fd3ce79607ec4a75569a1a68b0c2b143c75512f4fe122a9a730f1e69", kill_on_drop: false }` [INFO] [stdout] d5dbd7e4fd3ce79607ec4a75569a1a68b0c2b143c75512f4fe122a9a730f1e69