[INFO] cloning repository https://github.com/IamfromSpace/rust-cycle [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IamfromSpace/rust-cycle" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIamfromSpace%2Frust-cycle", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIamfromSpace%2Frust-cycle'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a352b6551fa3fd339e4db19dfbdab347d86adc5f [INFO] checking IamfromSpace/rust-cycle/a352b6551fa3fd339e4db19dfbdab347d86adc5f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIamfromSpace%2Frust-cycle" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/IamfromSpace/rust-cycle on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/IamfromSpace/rust-cycle [INFO] finished tweaking git repo https://github.com/IamfromSpace/rust-cycle [INFO] tweaked toml for git repo https://github.com/IamfromSpace/rust-cycle written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/IamfromSpace/rust-cycle already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e913047e49ab110425a44b3644108ad2c7046114a3821b9f55fb644d35c695f2 [INFO] running `Command { std: "docker" "start" "-a" "e913047e49ab110425a44b3644108ad2c7046114a3821b9f55fb644d35c695f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e913047e49ab110425a44b3644108ad2c7046114a3821b9f55fb644d35c695f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e913047e49ab110425a44b3644108ad2c7046114a3821b9f55fb644d35c695f2", kill_on_drop: false }` [INFO] [stdout] e913047e49ab110425a44b3644108ad2c7046114a3821b9f55fb644d35c695f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 010f510eca23732c349f0219a298b8a14c4aa63111ed3e47d9ba7323c07f6cad [INFO] running `Command { std: "docker" "start" "-a" "010f510eca23732c349f0219a298b8a14c4aa63111ed3e47d9ba7323c07f6cad", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling libdbus-sys v0.2.5 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling async-trait v0.1.79 [INFO] [stderr] Compiling syn v2.0.57 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling sdl2-sys v0.32.6 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Checking xml-rs v0.8.19 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling sdl2 v0.32.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking ascii v0.8.7 [INFO] [stderr] Checking chunked_transfer v0.3.1 [INFO] [stderr] Checking embedded-graphics v0.6.2 [INFO] [stderr] Checking xi-unicode v0.2.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking parking_lot_core v0.7.3 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rppal v0.11.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking sled v0.31.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking tiny_http v0.6.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.58 [INFO] [stderr] Checking serde v1.0.197 [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Checking serde_bytes v0.11.14 [INFO] [stderr] Checking nmea0183 v0.2.2 (https://github.com/IamfromSpace/nmea0183.git?rev=66e205d97438bf07#66e205d9) [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking bluez-generated v0.3.0 [INFO] [stderr] Checking dbus-tokio v0.7.6 [INFO] [stderr] Checking bluez-async v0.7.2 [INFO] [stderr] Checking btleplug v0.11.5 [INFO] [stderr] Checking rust-cycle v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/telemetry_db.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | serial_config: bincode::Config, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `bincode::config`: please use `options()` instead [INFO] [stdout] --> src/telemetry_db.rs:33:34 [INFO] [stdout] | [INFO] [stdout] 33 | let serial_config = bincode::config().big_endian().clone(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `bincode::Config`: please use the `DefaultOptions`/`Options` system instead [INFO] [stdout] --> src/telemetry_db.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | serial_config: bincode::Config, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `bincode::config`: please use `options()` instead [INFO] [stdout] --> src/telemetry_db.rs:33:34 [INFO] [stdout] | [INFO] [stdout] 33 | let serial_config = bincode::config().big_endian().clone(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `checked_wheel_rpm_and_new_count` is never used [INFO] [stdout] --> src/ble/cycling_power_measurement.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn checked_wheel_rpm_and_new_count( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `on_release`, `on_repeat`, and `clear_handlers` are never used [INFO] [stdout] --> src/buttons.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 49 | impl Buttons { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 159 | pub fn on_release(&self, b: Button, f: Box) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | pub fn on_repeat(&self, b: Button, d: Duration, f: Box) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 180 | pub fn clear_handlers(&self, b: Button) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:479:20 [INFO] [stdout] | [INFO] [stdout] 479 | for gps in &mut o_gps { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 479 | while let Some(gps) = &mut o_gps { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 479 | if let Some(gps) = &mut o_gps { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:502:30 [INFO] [stdout] | [INFO] [stdout] 502 | for speed_measure in &mut o_speed { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 502 | while let Some(speed_measure) = &mut o_speed { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 502 | if let Some(speed_measure) = &mut o_speed { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:535:20 [INFO] [stdout] | [INFO] [stdout] 535 | for hrm in &mut o_hrm { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 535 | while let Some(hrm) = &mut o_hrm { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 535 | if let Some(hrm) = &mut o_hrm { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:560:27 [INFO] [stdout] | [INFO] [stdout] 560 | for (kickr, _) in &mut o_kickr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 560 | while let Some((kickr, _)) = &mut o_kickr { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 560 | if let Some((kickr, _)) = &mut o_kickr { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:612:24 [INFO] [stdout] | [INFO] [stdout] 612 | for assioma in &mut o_assioma { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 612 | while let Some(assioma) = &mut o_assioma { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 612 | if let Some(assioma) = &mut o_assioma { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:656:32 [INFO] [stdout] | [INFO] [stdout] 656 | for cadence_measure in &mut o_cadence { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 656 | while let Some(cadence_measure) = &mut o_cadence { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 656 | if let Some(cadence_measure) = &mut o_cadence { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gps.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut uart = Uart::new(9600, Parity::None, 8, 1)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | uart.send_start()?; [INFO] [stdout] 21 | let handler: Arc>>> = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let handler_for_thread = handler.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let running_for_thread = Arc::new(()); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let running = Some(running_for_thread.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let join_handle = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Gps { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | running, [INFO] [stdout] 57 | | join_handle, [INFO] [stdout] 58 | | handler, [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory_lcd.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 44 | let mut spi = Spi::new( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let gpio = Gpio::new().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut cs_pin = gpio.get(CS_PIN).unwrap().into_output(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let buffer = Arc::new(Mutex::new(vec![ [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let buffer_for_thread = buffer.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | let running_for_thread = Arc::new(()); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let running = Some(running_for_thread.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let join_handle = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(MemoryLcd { [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | buffer, [INFO] [stdout] 93 | | running, [INFO] [stdout] 94 | | join_handle, [INFO] [stdout] 95 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/telemetry_db.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 32 | let db = sled::open(path)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let serial_config = bincode::config().big_endian().clone(); [INFO] [stdout] 34 | Ok(TelemetryDb { db, serial_config }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/telemetry_db.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 72 | fn decode_value(&self, v: sled::IVec) -> Notification { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let z: Vec = (*v).try_into().unwrap(); [INFO] [stdout] 74 | self.serial_config.deserialize(&z).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn lift_a2_option C>(a: Option, b: Option, f: F) -> Option { [INFO] [stdout] | ------------ ------------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2 | match (a, b) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `checked_wheel_rpm_and_new_count` is never used [INFO] [stdout] --> src/ble/cycling_power_measurement.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn checked_wheel_rpm_and_new_count( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `on_release`, `on_repeat`, and `clear_handlers` are never used [INFO] [stdout] --> src/buttons.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 49 | impl Buttons { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 159 | pub fn on_release(&self, b: Button, f: Box) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | pub fn on_repeat(&self, b: Button, d: Duration, f: Box) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 180 | pub fn clear_handlers(&self, b: Button) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:479:20 [INFO] [stdout] | [INFO] [stdout] 479 | for gps in &mut o_gps { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 479 | while let Some(gps) = &mut o_gps { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 479 | if let Some(gps) = &mut o_gps { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:502:30 [INFO] [stdout] | [INFO] [stdout] 502 | for speed_measure in &mut o_speed { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 502 | while let Some(speed_measure) = &mut o_speed { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 502 | if let Some(speed_measure) = &mut o_speed { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:535:20 [INFO] [stdout] | [INFO] [stdout] 535 | for hrm in &mut o_hrm { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 535 | while let Some(hrm) = &mut o_hrm { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 535 | if let Some(hrm) = &mut o_hrm { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:560:27 [INFO] [stdout] | [INFO] [stdout] 560 | for (kickr, _) in &mut o_kickr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 560 | while let Some((kickr, _)) = &mut o_kickr { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 560 | if let Some((kickr, _)) = &mut o_kickr { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:612:24 [INFO] [stdout] | [INFO] [stdout] 612 | for assioma in &mut o_assioma { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 612 | while let Some(assioma) = &mut o_assioma { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 612 | if let Some(assioma) = &mut o_assioma { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:656:32 [INFO] [stdout] | [INFO] [stdout] 656 | for cadence_measure in &mut o_cadence { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 656 | while let Some(cadence_measure) = &mut o_cadence { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 656 | if let Some(cadence_measure) = &mut o_cadence { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gps.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut uart = Uart::new(9600, Parity::None, 8, 1)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | uart.send_start()?; [INFO] [stdout] 21 | let handler: Arc>>> = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let handler_for_thread = handler.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let running_for_thread = Arc::new(()); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let running = Some(running_for_thread.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let join_handle = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Gps { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | running, [INFO] [stdout] 57 | | join_handle, [INFO] [stdout] 58 | | handler, [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory_lcd.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 44 | let mut spi = Spi::new( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let gpio = Gpio::new().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut cs_pin = gpio.get(CS_PIN).unwrap().into_output(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let buffer = Arc::new(Mutex::new(vec![ [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let buffer_for_thread = buffer.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | let running_for_thread = Arc::new(()); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let running = Some(running_for_thread.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let join_handle = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(MemoryLcd { [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | buffer, [INFO] [stdout] 93 | | running, [INFO] [stdout] 94 | | join_handle, [INFO] [stdout] 95 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/telemetry_db.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 32 | let db = sled::open(path)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let serial_config = bincode::config().big_endian().clone(); [INFO] [stdout] 34 | Ok(TelemetryDb { db, serial_config }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/telemetry_db.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 72 | fn decode_value(&self, v: sled::IVec) -> Notification { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let z: Vec = (*v).try_into().unwrap(); [INFO] [stdout] 74 | self.serial_config.deserialize(&z).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn lift_a2_option C>(a: Option, b: Option, f: F) -> Option { [INFO] [stdout] | ------------ ------------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2 | match (a, b) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-cycle` (bin "rust-cycle") due to 6 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-cycle` (bin "rust-cycle" test) due to 6 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "010f510eca23732c349f0219a298b8a14c4aa63111ed3e47d9ba7323c07f6cad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "010f510eca23732c349f0219a298b8a14c4aa63111ed3e47d9ba7323c07f6cad", kill_on_drop: false }` [INFO] [stdout] 010f510eca23732c349f0219a298b8a14c4aa63111ed3e47d9ba7323c07f6cad