[INFO] cloning repository https://github.com/IGI-111/xit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IGI-111/xit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIGI-111%2Fxit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIGI-111%2Fxit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4fe077f01c63f192246a4a9364ee165c572c4edd [INFO] checking IGI-111/xit/4fe077f01c63f192246a4a9364ee165c572c4edd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIGI-111%2Fxit" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/IGI-111/xit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/IGI-111/xit [INFO] finished tweaking git repo https://github.com/IGI-111/xit [INFO] tweaked toml for git repo https://github.com/IGI-111/xit written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/IGI-111/xit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b176204f8273ba548a6194759d82a9198a1aedf792075a08435533e8cf227305 [INFO] running `Command { std: "docker" "start" "-a" "b176204f8273ba548a6194759d82a9198a1aedf792075a08435533e8cf227305", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b176204f8273ba548a6194759d82a9198a1aedf792075a08435533e8cf227305", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b176204f8273ba548a6194759d82a9198a1aedf792075a08435533e8cf227305", kill_on_drop: false }` [INFO] [stdout] b176204f8273ba548a6194759d82a9198a1aedf792075a08435533e8cf227305 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bf36a5288d680a96c1c87e9bd0f1db5518061a184cd664bd3a5a21adbbadf29 [INFO] running `Command { std: "docker" "start" "-a" "8bf36a5288d680a96c1c87e9bd0f1db5518061a184cd664bd3a5a21adbbadf29", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking dtoa v0.4.1 [INFO] [stderr] Checking itoa v0.3.1 [INFO] [stderr] Checking serde v0.9.14 [INFO] [stderr] Checking libc v0.2.21 [INFO] [stderr] Checking num-traits v0.1.37 [INFO] [stderr] Checking termion v1.3.0 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking xit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Duration` and `Instant` [INFO] [stdout] --> src/main.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | use std::time::{Instant, Duration}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/main.rs:15:23 [INFO] [stdout] | [INFO] [stdout] 15 | use std::sync::mpsc::{self, Receiver}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:16:37 [INFO] [stdout] | [INFO] [stdout] 16 | use std::io::{stdin, stdout, Write, Read, BufWriter}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Duration` and `Instant` [INFO] [stdout] --> src/main.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | use std::time::{Instant, Duration}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/main.rs:15:23 [INFO] [stdout] | [INFO] [stdout] 15 | use std::sync::mpsc::{self, Receiver}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:16:37 [INFO] [stdout] | [INFO] [stdout] 16 | use std::io::{stdin, stdout, Write, Read, BufWriter}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:45:10 [INFO] [stdout] | [INFO] [stdout] 22 | let process = Command::new("xi-core") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let (update_tx, update_rx) = mpsc::channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let rpc_tx_map = Arc::new(Mutex::new(HashMap::new())); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let rpc_tx_map_clone = rpc_tx_map.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | let stdout = process.stdout.unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let stderr = process.stderr.unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | (Core { [INFO] [stdout] | __________^ [INFO] [stdout] 46 | | rpc_tx_map: rpc_tx_map, [INFO] [stdout] 47 | | rpc_index: 0, [INFO] [stdout] 48 | | stdin: process.stdin.unwrap(), [INFO] [stdout] 49 | | }, [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xit` (bin "xit" test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:45:10 [INFO] [stdout] | [INFO] [stdout] 22 | let process = Command::new("xi-core") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let (update_tx, update_rx) = mpsc::channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let rpc_tx_map = Arc::new(Mutex::new(HashMap::new())); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let rpc_tx_map_clone = rpc_tx_map.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | let stdout = process.stdout.unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let stderr = process.stderr.unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | (Core { [INFO] [stdout] | __________^ [INFO] [stdout] 46 | | rpc_tx_map: rpc_tx_map, [INFO] [stdout] 47 | | rpc_index: 0, [INFO] [stdout] 48 | | stdin: process.stdin.unwrap(), [INFO] [stdout] 49 | | }, [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xit` (bin "xit") due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8bf36a5288d680a96c1c87e9bd0f1db5518061a184cd664bd3a5a21adbbadf29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bf36a5288d680a96c1c87e9bd0f1db5518061a184cd664bd3a5a21adbbadf29", kill_on_drop: false }` [INFO] [stdout] 8bf36a5288d680a96c1c87e9bd0f1db5518061a184cd664bd3a5a21adbbadf29