[INFO] cloning repository https://github.com/HrithikSampson/FirstAssignmentRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HrithikSampson/FirstAssignmentRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHrithikSampson%2FFirstAssignmentRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHrithikSampson%2FFirstAssignmentRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fa5a1902457237ce390568229cb0e1a49b595817 [INFO] checking HrithikSampson/FirstAssignmentRust/fa5a1902457237ce390568229cb0e1a49b595817 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHrithikSampson%2FFirstAssignmentRust" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/HrithikSampson/FirstAssignmentRust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/HrithikSampson/FirstAssignmentRust [INFO] finished tweaking git repo https://github.com/HrithikSampson/FirstAssignmentRust [INFO] tweaked toml for git repo https://github.com/HrithikSampson/FirstAssignmentRust written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/HrithikSampson/FirstAssignmentRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 00d1e4ecf00589f0e6066096dbc76bea988c592ba526b0d2124130c36b0fa73d [INFO] running `Command { std: "docker" "start" "-a" "00d1e4ecf00589f0e6066096dbc76bea988c592ba526b0d2124130c36b0fa73d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00d1e4ecf00589f0e6066096dbc76bea988c592ba526b0d2124130c36b0fa73d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00d1e4ecf00589f0e6066096dbc76bea988c592ba526b0d2124130c36b0fa73d", kill_on_drop: false }` [INFO] [stdout] 00d1e4ecf00589f0e6066096dbc76bea988c592ba526b0d2124130c36b0fa73d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f609ad8cb162294f364f42ae7e7afdb457c2113b2ebf93321081001bc6f8c452 [INFO] running `Command { std: "docker" "start" "-a" "f609ad8cb162294f364f42ae7e7afdb457c2113b2ebf93321081001bc6f8c452", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling serde v1.0.173 [INFO] [stderr] Compiling serde_derive v1.0.173 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.43 [INFO] [stderr] Compiling either v1.8.1 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling cpufeatures v0.2.9 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling typed-arena v2.0.2 [INFO] [stderr] Compiling data-encoding v2.4.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling unicode-width v0.1.10 [INFO] [stderr] Compiling arrayvec v0.5.2 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling leb128 v0.2.5 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling pretty v0.12.3 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Compiling slotmap v1.0.6 [INFO] [stderr] Checking ic0 v0.21.1 [INFO] [stderr] Compiling quote v1.0.31 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking ic-stable-structures v0.6.0 [INFO] [stderr] Compiling syn v2.0.27 [INFO] [stderr] Compiling psm v0.1.21 [INFO] [stderr] Compiling stacker v0.1.15 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Checking serde_bytes v0.11.12 [INFO] [stderr] Compiling thiserror-impl v1.0.43 [INFO] [stderr] Compiling candid_derive v0.6.5 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling serde_tokenstream v0.1.7 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Compiling ic_principal v0.1.0 [INFO] [stderr] Compiling binread v2.2.0 [INFO] [stderr] Checking candid v0.10.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Compiling ic-cdk-macros v0.8.2 [INFO] [stderr] Checking ic-cdk v0.12.0 [INFO] [stderr] Checking ic-cdk-timers v0.6.0 [INFO] [stderr] Checking final_project_backend v0.1.0 (/opt/rustwide/workdir/src/final_project_backend) [INFO] [stdout] warning: unused variable: `proposal` [INFO] [stdout] --> src/final_project_backend/src/lib.rs:93:28 [INFO] [stdout] | [INFO] [stdout] 93 | fn edit_proposal(key: u64, proposal: CreateProposal) -> Result<(), VoteError> { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_proposal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `proposal` [INFO] [stdout] --> src/final_project_backend/src/lib.rs:93:28 [INFO] [stdout] | [INFO] [stdout] 93 | fn edit_proposal(key: u64, proposal: CreateProposal) -> Result<(), VoteError> { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_proposal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:9:27 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Debug,CandidType,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:9:27 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Debug,CandidType,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:15:27 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug,CandidType,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:15:27 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug,CandidType,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:64:63 [INFO] [stdout] | [INFO] [stdout] 64 | RefCell::new(StableBTreeMap::init(MEMORY_MANAGER.with(|m| m.borrow().get(MemoryId::new(0))))); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:64:63 [INFO] [stdout] | [INFO] [stdout] 64 | RefCell::new(StableBTreeMap::init(MEMORY_MANAGER.with(|m| m.borrow().get(MemoryId::new(0))))); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 69 | PROPOSAL_MAP.with(|p|p.borrow().get(&key)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 69 | PROPOSAL_MAP.with(|p|p.borrow().get(&key)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | PROPOSAL_MAP.with(|p|p.borrow().len()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | PROPOSAL_MAP.with(|p|p.borrow().len()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:88:27 [INFO] [stdout] | [INFO] [stdout] 88 | PROPOSAL_MAP.with(|p| p.borrow_mut().insert(key,value)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:88:27 [INFO] [stdout] | [INFO] [stdout] 88 | PROPOSAL_MAP.with(|p| p.borrow_mut().insert(key,value)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:105:41 [INFO] [stdout] | [INFO] [stdout] 105 | let res = PROPOSAL_MAP.with(|p| p.borrow_mut().insert(key,old_proposal)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:105:41 [INFO] [stdout] | [INFO] [stdout] 105 | let res = PROPOSAL_MAP.with(|p| p.borrow_mut().insert(key,old_proposal)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:126:41 [INFO] [stdout] | [INFO] [stdout] 126 | let res = PROPOSAL_MAP.with(|p| p.borrow_mut().insert(key,old_proposal)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/final_project_backend/src/lib.rs:126:41 [INFO] [stdout] | [INFO] [stdout] 126 | let res = PROPOSAL_MAP.with(|p| p.borrow_mut().insert(key,old_proposal)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `final_project_backend` (lib test) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `final_project_backend` (lib) due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f609ad8cb162294f364f42ae7e7afdb457c2113b2ebf93321081001bc6f8c452", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f609ad8cb162294f364f42ae7e7afdb457c2113b2ebf93321081001bc6f8c452", kill_on_drop: false }` [INFO] [stdout] f609ad8cb162294f364f42ae7e7afdb457c2113b2ebf93321081001bc6f8c452