[INFO] cloning repository https://github.com/Hoverbear/fun_with_futures [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hoverbear/fun_with_futures" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHoverbear%2Ffun_with_futures", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHoverbear%2Ffun_with_futures'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f38c3217ee90ed003259aa2d331372bf5e80608e [INFO] checking Hoverbear/fun_with_futures/f38c3217ee90ed003259aa2d331372bf5e80608e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHoverbear%2Ffun_with_futures" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Hoverbear/fun_with_futures on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Hoverbear/fun_with_futures [INFO] finished tweaking git repo https://github.com/Hoverbear/fun_with_futures [INFO] tweaked toml for git repo https://github.com/Hoverbear/fun_with_futures written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Hoverbear/fun_with_futures already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61f6f02878a5724f1ecf7dc5d1ccede5ca245efb58381a0f55076e6a6dbef1f6 [INFO] running `Command { std: "docker" "start" "-a" "61f6f02878a5724f1ecf7dc5d1ccede5ca245efb58381a0f55076e6a6dbef1f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61f6f02878a5724f1ecf7dc5d1ccede5ca245efb58381a0f55076e6a6dbef1f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61f6f02878a5724f1ecf7dc5d1ccede5ca245efb58381a0f55076e6a6dbef1f6", kill_on_drop: false }` [INFO] [stdout] 61f6f02878a5724f1ecf7dc5d1ccede5ca245efb58381a0f55076e6a6dbef1f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 47a8499a7575c0afa0eb95f7fe648068a7bf29f7ec5052ce23784e2186a53b34 [INFO] running `Command { std: "docker" "start" "-a" "47a8499a7575c0afa0eb95f7fe648068a7bf29f7ec5052ce23784e2186a53b34", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.20 [INFO] [stderr] Checking log v0.3.6 [INFO] [stderr] Checking cfg-if v0.1.0 [INFO] [stderr] Checking lazycell v0.4.0 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Checking scoped-tls v0.1.0 [INFO] [stderr] Checking take v0.1.0 [INFO] [stderr] Checking crossbeam v0.2.10 [INFO] [stderr] Checking smallvec v0.2.1 [INFO] [stderr] Checking futures v0.1.10 [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking num_cpus v1.2.1 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking mio v0.6.4 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking tokio-core v0.1.4 [INFO] [stderr] Checking futures-cpupool v0.1.3 [INFO] [stderr] Checking tokio-proto v0.1.0 [INFO] [stderr] Checking fun_with_futures v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/7-tokio-server.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 27 | let server = listener.incoming().for_each(|(stream, _client_addr)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | / read_to_end(stream, Vec::new()) [INFO] [stdout] 32 | | .and_then(|(socket, data)| { [INFO] [stdout] 33 | | // Write the recieved data. [INFO] [stdout] 34 | | write_all(socket, data) [INFO] [stdout] 35 | | }) [INFO] [stdout] 36 | | // Errors have to be handled internally. [INFO] [stdout] 37 | | .map(|_| ()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fun_with_futures` (example "7-tokio-server") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/9-tokio-codec-lines.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 66 | let server = listener.incoming().for_each(|(stream, _client_addr)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let (writer, reader) = stream.framed(EchoCodec).split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | // Here we just sink any data recieved directly back into the socket. [INFO] [stdout] 72 | / reader.forward(writer) [INFO] [stdout] 73 | | // We need to handle errors internally. [INFO] [stdout] 74 | | .map(|_| ()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `url` [INFO] [stdout] --> examples/10-tokio-codec-http.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | ExampleRequest::Get { url: url } => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_url` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `url` [INFO] [stdout] --> examples/10-tokio-codec-http.rs:106:37 [INFO] [stdout] | [INFO] [stdout] 106 | ExampleRequest::Post { url: url, content: content } => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_url` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fun_with_futures` (example "9-tokio-codec-lines") due to 2 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/10-tokio-codec-http.rs:52:32 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|len| headers.drain(..len).collect::()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/10-tokio-codec-http.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | .map(|len| headers.drain(..len).collect::()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `url:` in this pattern is redundant [INFO] [stdout] --> examples/10-tokio-codec-http.rs:103:31 [INFO] [stdout] | [INFO] [stdout] 103 | ExampleRequest::Get { url: url } => { [INFO] [stdout] | ^^^^^^^^ help: use shorthand field pattern: `url` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_shorthand_field_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `url:` in this pattern is redundant [INFO] [stdout] --> examples/10-tokio-codec-http.rs:106:32 [INFO] [stdout] | [INFO] [stdout] 106 | ExampleRequest::Post { url: url, content: content } => { [INFO] [stdout] | ^^^^^^^^ help: use shorthand field pattern: `url` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `content:` in this pattern is redundant [INFO] [stdout] --> examples/10-tokio-codec-http.rs:106:42 [INFO] [stdout] | [INFO] [stdout] 106 | ExampleRequest::Post { url: url, content: content } => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use shorthand field pattern: `content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/10-tokio-codec-http.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 126 | let server = listener.incoming().for_each(|(stream, _client_addr)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let (writer, reader) = stream.framed(ExampleCodec).split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | // Here we just sink any data recieved directly back into the socket. [INFO] [stdout] 132 | / reader.map(mapper).forward(writer) [INFO] [stdout] 133 | | // We need to handle errors internally. [INFO] [stdout] 134 | | .map(|_| ()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fun_with_futures` (example "10-tokio-codec-http") due to 4 previous errors; 5 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/8-tokio-codec-buffer.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 50 | let server = listener.incoming().for_each(|(stream, _client_addr)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let (writer, reader) = stream.framed(EchoCodec).split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | // Here we just sink any data recieved directly back into the socket. [INFO] [stdout] 56 | / reader.forward(writer) [INFO] [stdout] 57 | | // We need to handle errors internally. [INFO] [stdout] 58 | | .map(|_| ()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fun_with_futures` (example "8-tokio-codec-buffer") due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "47a8499a7575c0afa0eb95f7fe648068a7bf29f7ec5052ce23784e2186a53b34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47a8499a7575c0afa0eb95f7fe648068a7bf29f7ec5052ce23784e2186a53b34", kill_on_drop: false }` [INFO] [stdout] 47a8499a7575c0afa0eb95f7fe648068a7bf29f7ec5052ce23784e2186a53b34