[INFO] cloning repository https://github.com/Horusiath/storyteller [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Horusiath/storyteller" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHorusiath%2Fstoryteller", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHorusiath%2Fstoryteller'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 69584d96dc5e11a12a1739ee4ed35540a039f2ba [INFO] checking Horusiath/storyteller/69584d96dc5e11a12a1739ee4ed35540a039f2ba against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHorusiath%2Fstoryteller" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Horusiath/storyteller on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Horusiath/storyteller [INFO] finished tweaking git repo https://github.com/Horusiath/storyteller [INFO] tweaked toml for git repo https://github.com/Horusiath/storyteller written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Horusiath/storyteller already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c4955bcc44c021afb0c6633ab84d95c14a274364b4e05fb0a01a222e8332a58 [INFO] running `Command { std: "docker" "start" "-a" "2c4955bcc44c021afb0c6633ab84d95c14a274364b4e05fb0a01a222e8332a58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c4955bcc44c021afb0c6633ab84d95c14a274364b4e05fb0a01a222e8332a58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c4955bcc44c021afb0c6633ab84d95c14a274364b4e05fb0a01a222e8332a58", kill_on_drop: false }` [INFO] [stdout] 2c4955bcc44c021afb0c6633ab84d95c14a274364b4e05fb0a01a222e8332a58 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3367f95d59aec453876b7c0e7cd662ce917792e66479fe80ca20e9c2c20aeff [INFO] running `Command { std: "docker" "start" "-a" "e3367f95d59aec453876b7c0e7cd662ce917792e66479fe80ca20e9c2c20aeff", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling platforms v3.4.0 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking varint-rs v2.2.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling curve25519-dalek v4.1.2 [INFO] [stderr] Compiling blake3 v1.5.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking hashlink v0.9.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking serde_bytes v0.11.14 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking storyteller v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `options` [INFO] [stdout] --> src/store/sqlite.rs:16:53 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn with_options(conn: rusqlite::Connection, options: Options) -> Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_options` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 120 | let deps = row.get_ref(4); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let deps: Deps = match deps { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | Ok(Patch { [INFO] [stdout] | ____________^ [INFO] [stdout] 136 | | id, [INFO] [stdout] 137 | | author, [INFO] [stdout] 138 | | sign: Signature::from_bytes(&signature), [INFO] [stdout] 139 | | deps, [INFO] [stdout] 140 | | data: Bytes::copy_from_slice(data.as_blob()?), [INFO] [stdout] 141 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(signing_key: SigningKey, store: S) -> Result { [INFO] [stdout] | ----------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let heads = store.heads()?; [INFO] [stdout] 18 | Ok(Peer { [INFO] [stdout] | ____________^ [INFO] [stdout] 19 | | signing_key, [INFO] [stdout] 20 | | store, [INFO] [stdout] 21 | | heads, [INFO] [stdout] 22 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/sqlite.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn with_options(conn: rusqlite::Connection, options: Options) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Self::init_schema(&conn)?; [INFO] [stdout] 18 | Ok(SqliteStore { conn }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/sqlite.rs:181:40 [INFO] [stdout] | [INFO] [stdout] 181 | .query_map((), |row| match Patch::from_sql_row(row) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `options` [INFO] [stdout] --> src/store/sqlite.rs:16:53 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn with_options(conn: rusqlite::Connection, options: Options) -> Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_options` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `storyteller` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 120 | let deps = row.get_ref(4); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let deps: Deps = match deps { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | Ok(Patch { [INFO] [stdout] | ____________^ [INFO] [stdout] 136 | | id, [INFO] [stdout] 137 | | author, [INFO] [stdout] 138 | | sign: Signature::from_bytes(&signature), [INFO] [stdout] 139 | | deps, [INFO] [stdout] 140 | | data: Bytes::copy_from_slice(data.as_blob()?), [INFO] [stdout] 141 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(signing_key: SigningKey, store: S) -> Result { [INFO] [stdout] | ----------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let heads = store.heads()?; [INFO] [stdout] 18 | Ok(Peer { [INFO] [stdout] | ____________^ [INFO] [stdout] 19 | | signing_key, [INFO] [stdout] 20 | | store, [INFO] [stdout] 21 | | heads, [INFO] [stdout] 22 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 112 | let conn = rusqlite::Connection::open_in_memory().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let store = SqliteStore::new(conn).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let key_pair = SigningKey::generate(&mut rand::rngs::OsRng); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Peer::new(key_pair, store).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:193:22 [INFO] [stdout] | [INFO] [stdout] 193 | .map(|p| serde_json::from_slice::(p.data()).unwrap()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/sqlite.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn with_options(conn: rusqlite::Connection, options: Options) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Self::init_schema(&conn)?; [INFO] [stdout] 18 | Ok(SqliteStore { conn }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/sqlite.rs:181:40 [INFO] [stdout] | [INFO] [stdout] 181 | .query_map((), |row| match Patch::from_sql_row(row) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `storyteller` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e3367f95d59aec453876b7c0e7cd662ce917792e66479fe80ca20e9c2c20aeff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3367f95d59aec453876b7c0e7cd662ce917792e66479fe80ca20e9c2c20aeff", kill_on_drop: false }` [INFO] [stdout] e3367f95d59aec453876b7c0e7cd662ce917792e66479fe80ca20e9c2c20aeff