[INFO] cloning repository https://github.com/HiddenToad/raytracer-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HiddenToad/raytracer-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHiddenToad%2Fraytracer-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHiddenToad%2Fraytracer-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1ef8b51e729ff36e616bd674b2a5eb4c436d149d [INFO] checking HiddenToad/raytracer-rs/1ef8b51e729ff36e616bd674b2a5eb4c436d149d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHiddenToad%2Fraytracer-rs" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/HiddenToad/raytracer-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/HiddenToad/raytracer-rs [INFO] finished tweaking git repo https://github.com/HiddenToad/raytracer-rs [INFO] tweaked toml for git repo https://github.com/HiddenToad/raytracer-rs written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/HiddenToad/raytracer-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7bba52b0d83c1fcab94e1e7d70a29819b14a0789ed52274d2ec5af3849ac30c [INFO] running `Command { std: "docker" "start" "-a" "c7bba52b0d83c1fcab94e1e7d70a29819b14a0789ed52274d2ec5af3849ac30c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7bba52b0d83c1fcab94e1e7d70a29819b14a0789ed52274d2ec5af3849ac30c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7bba52b0d83c1fcab94e1e7d70a29819b14a0789ed52274d2ec5af3849ac30c", kill_on_drop: false }` [INFO] [stdout] c7bba52b0d83c1fcab94e1e7d70a29819b14a0789ed52274d2ec5af3849ac30c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b9073b25589678b93b29513f37e8d0b85f43f07063ce8b73f0096fea713b1e1 [INFO] running `Command { std: "docker" "start" "-a" "2b9073b25589678b93b29513f37e8d0b85f43f07063ce8b73f0096fea713b1e1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking once_cell v1.16.0 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ray-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `material_solid` [INFO] [stdout] --> src/main.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | let material_solid = Lambertian::new_arc(Color::new(0.7, 0.3, 0.3)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_material_solid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `material_metal` [INFO] [stdout] --> src/main.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let material_metal = Metal::new_arc(Color::new(0.6, 0.6, 0.6), 0.15); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_material_metal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `material_dielectric` [INFO] [stdout] --> src/main.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | let material_dielectric = Dielectric::new_arc(1.5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_material_dielectric` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `view_w`, `w`, and `focus_dist` are never read [INFO] [stdout] --> src/camera.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | view_w: f64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] 19 | focus_dist: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Camera` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | Lazy::new(|| Arc::new(RwLock::new(CollidableVec::new()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 126 | let mut n = fs::File::open("rayout/.n.txt").unwrap_or_else(|_|{ [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | fs::File::open("rayout/.n.txt").unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collidable.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn boxed(center: Point, radius: f64, material: Arc) -> Box { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Box::new(Self::new(center, radius, material)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ray.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 78 | let world_guard = WORLD.read().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | match world_guard.collide(self, 0.001, f64::INFINITY) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `material_solid` [INFO] [stdout] --> src/main.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | let material_solid = Lambertian::new_arc(Color::new(0.7, 0.3, 0.3)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_material_solid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `material_metal` [INFO] [stdout] --> src/main.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let material_metal = Metal::new_arc(Color::new(0.6, 0.6, 0.6), 0.15); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_material_metal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `material_dielectric` [INFO] [stdout] --> src/main.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | let material_dielectric = Dielectric::new_arc(1.5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_material_dielectric` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `view_w`, `w`, and `focus_dist` are never read [INFO] [stdout] --> src/camera.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | view_w: f64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] 19 | focus_dist: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Camera` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | Lazy::new(|| Arc::new(RwLock::new(CollidableVec::new()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 126 | let mut n = fs::File::open("rayout/.n.txt").unwrap_or_else(|_|{ [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | fs::File::open("rayout/.n.txt").unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collidable.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn boxed(center: Point, radius: f64, material: Arc) -> Box { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Box::new(Self::new(center, radius, material)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ray.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 78 | let world_guard = WORLD.read().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | match world_guard.collide(self, 0.001, f64::INFINITY) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ray-tracer` (bin "ray-tracer") due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ray-tracer` (bin "ray-tracer" test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2b9073b25589678b93b29513f37e8d0b85f43f07063ce8b73f0096fea713b1e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b9073b25589678b93b29513f37e8d0b85f43f07063ce8b73f0096fea713b1e1", kill_on_drop: false }` [INFO] [stdout] 2b9073b25589678b93b29513f37e8d0b85f43f07063ce8b73f0096fea713b1e1