[INFO] cloning repository https://github.com/Henkhogan/magicjson-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Henkhogan/magicjson-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHenkhogan%2Fmagicjson-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHenkhogan%2Fmagicjson-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a00d8d03dac4a6741735c15bd9e80f227c7255cf [INFO] checking Henkhogan/magicjson-rust/a00d8d03dac4a6741735c15bd9e80f227c7255cf against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHenkhogan%2Fmagicjson-rust" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Henkhogan/magicjson-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Henkhogan/magicjson-rust [INFO] finished tweaking git repo https://github.com/Henkhogan/magicjson-rust [INFO] tweaked toml for git repo https://github.com/Henkhogan/magicjson-rust written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Henkhogan/magicjson-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c57436627d255f2e0ae964380611ef5b71ec48547b9d3cc813cca2eb0e5d2e10 [INFO] running `Command { std: "docker" "start" "-a" "c57436627d255f2e0ae964380611ef5b71ec48547b9d3cc813cca2eb0e5d2e10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c57436627d255f2e0ae964380611ef5b71ec48547b9d3cc813cca2eb0e5d2e10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c57436627d255f2e0ae964380611ef5b71ec48547b9d3cc813cca2eb0e5d2e10", kill_on_drop: false }` [INFO] [stdout] c57436627d255f2e0ae964380611ef5b71ec48547b9d3cc813cca2eb0e5d2e10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6465e5ba5058e0bb5f1bb997eb011cc66051eefb4f18d900e1d5f9b091706b18 [INFO] running `Command { std: "docker" "start" "-a" "6465e5ba5058e0bb5f1bb997eb011cc66051eefb4f18d900e1d5f9b091706b18", kill_on_drop: false }` [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Compiling regex-automata v0.4.3 [INFO] [stderr] Compiling regex v1.10.2 [INFO] [stderr] Compiling parse-zoneinfo v0.3.0 [INFO] [stderr] Compiling chrono-tz-build v0.2.1 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Compiling chrono-tz v0.8.5 [INFO] [stderr] Checking magicjson v0.0.1-alpha.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/serialize.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::PrimInt` [INFO] [stdout] --> src/serialize.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use num_traits::PrimInt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/serialize.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::PrimInt` [INFO] [stdout] --> src/serialize.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use num_traits::PrimInt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `any::Any` and `fmt::Display` [INFO] [stdout] --> src/lib.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 57 | use std::{any::Any, collections::{BTreeMap, HashMap}, fmt::Display}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `to_json_string` is never used [INFO] [stdout] --> src/serialize.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 51 | pub trait ToJsonString { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 52 | fn to_json(&self) -> JsonSerializable; [INFO] [stdout] 53 | fn to_json_string(self) -> String; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:355:31 [INFO] [stdout] | [INFO] [stdout] 354 | fn from(value: Vec) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | JsonSerializable::Vec(value.into_iter().map(|v| v.into()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:362:35 [INFO] [stdout] | [INFO] [stdout] 361 | fn from(value: HashMap) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | JsonSerializable::HashMap(value.into_iter().map(|(k,v)| (k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:369:36 [INFO] [stdout] | [INFO] [stdout] 368 | fn from(value: BTreeMap) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | JsonSerializable::BTreeMap(value.into_iter().map(|(k,v)| (k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `magicjson` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `to_json_string` is never used [INFO] [stdout] --> src/serialize.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 51 | pub trait ToJsonString { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 52 | fn to_json(&self) -> JsonSerializable; [INFO] [stdout] 53 | fn to_json_string(self) -> String; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:355:31 [INFO] [stdout] | [INFO] [stdout] 354 | fn from(value: Vec) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | JsonSerializable::Vec(value.into_iter().map(|v| v.into()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:362:35 [INFO] [stdout] | [INFO] [stdout] 361 | fn from(value: HashMap) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | JsonSerializable::HashMap(value.into_iter().map(|(k,v)| (k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:369:36 [INFO] [stdout] | [INFO] [stdout] 368 | fn from(value: BTreeMap) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | JsonSerializable::BTreeMap(value.into_iter().map(|(k,v)| (k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `magicjson` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6465e5ba5058e0bb5f1bb997eb011cc66051eefb4f18d900e1d5f9b091706b18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6465e5ba5058e0bb5f1bb997eb011cc66051eefb4f18d900e1d5f9b091706b18", kill_on_drop: false }` [INFO] [stdout] 6465e5ba5058e0bb5f1bb997eb011cc66051eefb4f18d900e1d5f9b091706b18