[INFO] updating cached repository https://github.com/HansBlackCat/ritcoin [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8d3d12c1ff9f9d1c06b47236f3b1fcece41bad1d [INFO] checking HansBlackCat/ritcoin/8d3d12c1ff9f9d1c06b47236f3b1fcece41bad1d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHansBlackCat%2Fritcoin" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/HansBlackCat/ritcoin on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/HansBlackCat/ritcoin [INFO] finished tweaking git repo https://github.com/HansBlackCat/ritcoin [INFO] tweaked toml for git repo https://github.com/HansBlackCat/ritcoin written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/HansBlackCat/ritcoin already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 407b498fca287d40e6df93b7f52306dba55c05270cbb47952b54aa936cdc9242 [INFO] running `Command { std: "docker" "start" "-a" "407b498fca287d40e6df93b7f52306dba55c05270cbb47952b54aa936cdc9242", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "407b498fca287d40e6df93b7f52306dba55c05270cbb47952b54aa936cdc9242", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "407b498fca287d40e6df93b7f52306dba55c05270cbb47952b54aa936cdc9242", kill_on_drop: false }` [INFO] [stdout] 407b498fca287d40e6df93b7f52306dba55c05270cbb47952b54aa936cdc9242 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3626740e971b1edcfda6c162ad71e7b6d104fbb41a03805d8eb2e9590b187340 [INFO] running `Command { std: "docker" "start" "-a" "3626740e971b1edcfda6c162ad71e7b6d104fbb41a03805d8eb2e9590b187340", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling io-lifetimes v1.0.4 [INFO] [stderr] Compiling rustix v0.36.7 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Compiling libm v0.2.6 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling num-bigint-dig v0.8.2 [INFO] [stderr] Compiling anyhow v1.0.68 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking cpufeatures v0.2.5 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking digest v0.10.6 [INFO] [stderr] Checking sha2 v0.10.6 [INFO] [stderr] Checking ripemd v0.1.3 [INFO] [stderr] Checking is-terminal v0.4.2 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking ritcoin v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::libs::ecc::Ecc` [INFO] [stdout] --> src/libs/key.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::libs::ecc::Ecc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `base58_encode` [INFO] [stdout] --> src/libs/ecc.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | signature::{base58_encode, base58_encode_with_checksum, Signature}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::libs::ecc::Ecc` [INFO] [stdout] --> src/libs/key.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::libs::ecc::Ecc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `base58_encode` [INFO] [stdout] --> src/libs/ecc.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | signature::{base58_encode, base58_encode_with_checksum, Signature}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/libs/ecc.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ecc` [INFO] [stdout] --> src/libs/ecc.rs:376:17 [INFO] [stdout] | [INFO] [stdout] 376 | use super::{Ecc, EccPoint, SECP256K1GENS_ORDER, SECP256K1GENS_X, SECP256K1GENS_Y}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ModInverse` [INFO] [stdout] --> src/libs/finite_field.rs:97:34 [INFO] [stdout] | [INFO] [stdout] 97 | use num_bigint_dig::{BigInt, ModInverse}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `One` [INFO] [stdout] --> src/libs/finite_field.rs:98:22 [INFO] [stdout] | [INFO] [stdout] 98 | use num_traits::{One, Pow}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToBigUint` [INFO] [stdout] --> src/libs/ecc.rs:4:61 [INFO] [stdout] | [INFO] [stdout] 4 | use num_bigint_dig::{BigInt, BigUint, ModInverse, ToBigInt, ToBigUint}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/libs/transaction.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/libs/transaction.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let array = Self::parse_nbytes::<4>(&mut stream); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/libs/transaction.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/libs/key.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToBigUint` [INFO] [stdout] --> src/libs/ecc.rs:4:61 [INFO] [stdout] | [INFO] [stdout] 4 | use num_bigint_dig::{BigInt, BigUint, ModInverse, ToBigInt, ToBigUint}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/libs/transaction.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `array` [INFO] [stdout] --> src/libs/transaction.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let array = Self::parse_nbytes::<4>(&mut stream); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_array` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/libs/transaction.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | let mut n: i64 = -1; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `locktime_type` is never read [INFO] [stdout] --> src/libs/transaction.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct TransactionLocktime { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] 49 | locktime: [u8; 4], [INFO] [stdout] 50 | locktime_type: TransactionLocktimeType, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionLocktime` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `previous_tx_id`, `previous_tx_idx`, `script_signature`, and `sequence` are never read [INFO] [stdout] --> src/libs/transaction.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 77 | pub struct TransactionInput { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 78 | previous_tx_id: [u8; 32], [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 79 | previous_tx_idx: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 80 | script_signature: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 81 | sequence: [u8; 4], [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionInput` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `amount` and `script_pubkey` are never read [INFO] [stdout] --> src/libs/transaction.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub struct TransactionOutput { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 102 | amount: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 103 | script_pubkey: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionOutput` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `version`, `transaction_inputs_varint`, `transaction_inputs`, `transaction_outputs_varint`, `transaction_outputs`, and `locktime` are never read [INFO] [stdout] --> src/libs/transaction.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 107 | pub struct Transaction { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 108 | version: TransactionVersion, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 109 | transaction_inputs_varint: Varint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 110 | transaction_inputs: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 111 | transaction_outputs_varint: Varint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 112 | transaction_outputs: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 113 | locktime: TransactionLocktime, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Transaction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/libs/transaction.rs:146:19 [INFO] [stdout] | [INFO] [stdout] 146 | pub struct Varint(Vec); [INFO] [stdout] | ------ ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Varint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `magic` is never read [INFO] [stdout] --> src/libs/network.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct NetworkMagic { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 17 | magic: [u8; 4], [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `command` is never read [INFO] [stdout] --> src/libs/network.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct NetworkCommand { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 21 | command: [u8; 12], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `payload_length`, `payload_checksum`, and `payload` are never read [INFO] [stdout] --> src/libs/network.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct NetworkPayload { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 25 | payload_length: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 26 | payload_checksum: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 27 | payload: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `rfc6979` is never used [INFO] [stdout] --> src/libs/key.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 19 | impl Key { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `verify` is never used [INFO] [stdout] --> src/libs/ecc.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 107 | impl EccPoint { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 128 | fn verify() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:83:34 [INFO] [stdout] | [INFO] [stdout] 82 | fn new(a: BigInt, b: BigInt, x: FiniteField, y: FiniteField) -> Self { [INFO] [stdout] | --------- --------- -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Ecc::raw_new(a, b, x, y, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/libs/key.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | BigInt::zero(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | 7.to_bigint().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | FiniteField::new(x, prime.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | FiniteField::new(y, prime.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Some((*SECP256K1GENS_ORDER).clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn new(a: BigInt, b: BigInt, x: FiniteField, y: FiniteField) -> Self { [INFO] [stdout] | --------- --------- -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | EccPoint::Point(Box::new(Ecc::new(a, b, x, y))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | EccPoint::Point(Box::new(Ecc::new_secp256k1(x, y))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ritcoin` (bin "ritcoin") due to 9 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `locktime_type` is never read [INFO] [stdout] --> src/libs/transaction.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct TransactionLocktime { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] 49 | locktime: [u8; 4], [INFO] [stdout] 50 | locktime_type: TransactionLocktimeType, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionLocktime` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `previous_tx_id`, `previous_tx_idx`, `script_signature`, and `sequence` are never read [INFO] [stdout] --> src/libs/transaction.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 77 | pub struct TransactionInput { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 78 | previous_tx_id: [u8; 32], [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 79 | previous_tx_idx: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 80 | script_signature: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 81 | sequence: [u8; 4], [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionInput` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `amount` and `script_pubkey` are never read [INFO] [stdout] --> src/libs/transaction.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub struct TransactionOutput { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 102 | amount: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 103 | script_pubkey: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransactionOutput` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `version`, `transaction_inputs_varint`, `transaction_inputs`, `transaction_outputs_varint`, `transaction_outputs`, and `locktime` are never read [INFO] [stdout] --> src/libs/transaction.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 107 | pub struct Transaction { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 108 | version: TransactionVersion, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 109 | transaction_inputs_varint: Varint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 110 | transaction_inputs: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 111 | transaction_outputs_varint: Varint, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 112 | transaction_outputs: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 113 | locktime: TransactionLocktime, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Transaction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/libs/transaction.rs:146:19 [INFO] [stdout] | [INFO] [stdout] 146 | pub struct Varint(Vec); [INFO] [stdout] | ------ ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Varint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `magic` is never read [INFO] [stdout] --> src/libs/network.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct NetworkMagic { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 17 | magic: [u8; 4], [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `command` is never read [INFO] [stdout] --> src/libs/network.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct NetworkCommand { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 21 | command: [u8; 12], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `payload_length`, `payload_checksum`, and `payload` are never read [INFO] [stdout] --> src/libs/network.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct NetworkPayload { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 25 | payload_length: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 26 | payload_checksum: [u8; 4], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 27 | payload: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `rfc6979` is never used [INFO] [stdout] --> src/libs/key.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 19 | impl Key { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 25 | fn rfc6979(&self, z: BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `verify` is never used [INFO] [stdout] --> src/libs/ecc.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 107 | impl EccPoint { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 128 | fn verify() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:83:34 [INFO] [stdout] | [INFO] [stdout] 82 | fn new(a: BigInt, b: BigInt, x: FiniteField, y: FiniteField) -> Self { [INFO] [stdout] | --------- --------- -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Ecc::raw_new(a, b, x, y, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | BigInt::zero(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | 7.to_bigint().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | FiniteField::new(x, prime.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | FiniteField::new(y, prime.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 86 | fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let prime = 2.to_bigint().unwrap().pow(256u64) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Some((*SECP256K1GENS_ORDER).clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn new(a: BigInt, b: BigInt, x: FiniteField, y: FiniteField) -> Self { [INFO] [stdout] | --------- --------- -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | EccPoint::Point(Box::new(Ecc::new(a, b, x, y))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libs/ecc.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn new_secp256k1(x: BigInt, y: BigInt) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | EccPoint::Point(Box::new(Ecc::new_secp256k1(x, y))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ritcoin` (bin "ritcoin" test) due to 9 previous errors; 21 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3626740e971b1edcfda6c162ad71e7b6d104fbb41a03805d8eb2e9590b187340", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3626740e971b1edcfda6c162ad71e7b6d104fbb41a03805d8eb2e9590b187340", kill_on_drop: false }` [INFO] [stdout] 3626740e971b1edcfda6c162ad71e7b6d104fbb41a03805d8eb2e9590b187340