[INFO] cloning repository https://github.com/Grimpy101/raybow-2 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Grimpy101/raybow-2" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGrimpy101%2Fraybow-2", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGrimpy101%2Fraybow-2'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 862763c970ef62bc1f67bf08f011d1762739423d [INFO] checking Grimpy101/raybow-2/862763c970ef62bc1f67bf08f011d1762739423d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGrimpy101%2Fraybow-2" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Grimpy101/raybow-2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Grimpy101/raybow-2 [INFO] finished tweaking git repo https://github.com/Grimpy101/raybow-2 [INFO] tweaked toml for git repo https://github.com/Grimpy101/raybow-2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Grimpy101/raybow-2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e6722d981a51ad6ef54053acc0dc51066e0d30a4164bb129d6172e5794c07a6 [INFO] running `Command { std: "docker" "start" "-a" "2e6722d981a51ad6ef54053acc0dc51066e0d30a4164bb129d6172e5794c07a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e6722d981a51ad6ef54053acc0dc51066e0d30a4164bb129d6172e5794c07a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e6722d981a51ad6ef54053acc0dc51066e0d30a4164bb129d6172e5794c07a6", kill_on_drop: false }` [INFO] [stdout] 2e6722d981a51ad6ef54053acc0dc51066e0d30a4164bb129d6172e5794c07a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0a6db07b746b9abf256c3648eb4ec432836264538e3810cc9ae7996b7fd506e1 [INFO] running `Command { std: "docker" "start" "-a" "0a6db07b746b9abf256c3648eb4ec432836264538e3810cc9ae7996b7fd506e1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling rustix v0.38.13 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking linux-raw-sys v0.4.7 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Checking aho-corasick v1.0.5 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking argh_shared v0.1.12 [INFO] [stderr] Compiling argh_derive v0.1.12 [INFO] [stderr] Checking argh v0.1.12 [INFO] [stderr] Checking raybow-2 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated items `new`, `set_up_direction`, and `transform` are never used [INFO] [stdout] --> src/camera.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 61 | impl Camera { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 70 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | pub fn set_up_direction(&mut self, up: Vec3A) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 159 | pub fn transform(&mut self, matrix: Mat4) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_vec3_in_range` is never used [INFO] [stdout] --> src/math/mod.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn random_vec3_in_range(min: f32, max: f32, rng: &mut ThreadRng) -> Vec3A { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `uniform_random_vec3` is never used [INFO] [stdout] --> src/math/mod.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn uniform_random_vec3(rng: &mut Xoshiro256Plus) -> Vec3A { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_vec3_near_zero` is never used [INFO] [stdout] --> src/math/mod.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn is_vec3_near_zero(vector: Vec3A) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rgb_to_ascii_ppm` is never used [INFO] [stdout] --> src/output_formats/ppm.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn rgb_to_ascii_ppm( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/mod.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 115 | fn from(value: Sphere) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Self::new(AnyHittable::Sphere(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/mod.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 121 | fn from(value: Parallelogram) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | Self::new(AnyHittable::Paralellogram(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/parallelogram.rs:40:23 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(bottom_left_point: Vec3A, up: Vec3A, right: Vec3A, material: M) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | material: material.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/sphere.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(center: Vec3A, radius: f32, material: M) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | material: material.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preparation.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 46 | let mut renderables = Renderables::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let sphere_left = Sphere::new((-r, 0.0, -1.0).into(), r, material_left); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let sphere_right = Sphere::new((r, 0.0, -1.0).into(), r, material_right); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let plane = Parallelogram::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | background: Box::new(sky_background), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raybow-2` (bin "raybow-2" test) due to 6 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated items `new`, `set_up_direction`, and `transform` are never used [INFO] [stdout] --> src/camera.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 61 | impl Camera { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 70 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | pub fn set_up_direction(&mut self, up: Vec3A) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 159 | pub fn transform(&mut self, matrix: Mat4) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_vec3_in_range` is never used [INFO] [stdout] --> src/math/mod.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn random_vec3_in_range(min: f32, max: f32, rng: &mut ThreadRng) -> Vec3A { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `uniform_random_vec3` is never used [INFO] [stdout] --> src/math/mod.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn uniform_random_vec3(rng: &mut Xoshiro256Plus) -> Vec3A { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_vec3_near_zero` is never used [INFO] [stdout] --> src/math/mod.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn is_vec3_near_zero(vector: Vec3A) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rgb_to_ascii_ppm` is never used [INFO] [stdout] --> src/output_formats/ppm.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn rgb_to_ascii_ppm( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/mod.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 115 | fn from(value: Sphere) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Self::new(AnyHittable::Sphere(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/mod.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 121 | fn from(value: Parallelogram) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | Self::new(AnyHittable::Paralellogram(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/parallelogram.rs:40:23 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(bottom_left_point: Vec3A, up: Vec3A, right: Vec3A, material: M) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | material: material.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/sphere.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(center: Vec3A, radius: f32, material: M) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | material: material.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preparation.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 46 | let mut renderables = Renderables::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let sphere_left = Sphere::new((-r, 0.0, -1.0).into(), r, material_left); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let sphere_right = Sphere::new((r, 0.0, -1.0).into(), r, material_right); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let plane = Parallelogram::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | background: Box::new(sky_background), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raybow-2` (bin "raybow-2") due to 6 previous errors; 5 warnings emitted [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "0a6db07b746b9abf256c3648eb4ec432836264538e3810cc9ae7996b7fd506e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a6db07b746b9abf256c3648eb4ec432836264538e3810cc9ae7996b7fd506e1", kill_on_drop: false }` [INFO] [stdout] 0a6db07b746b9abf256c3648eb4ec432836264538e3810cc9ae7996b7fd506e1