[INFO] cloning repository https://github.com/Gregory-Meyer/crudis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Gregory-Meyer/crudis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGregory-Meyer%2Fcrudis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGregory-Meyer%2Fcrudis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9ab13f33da1ecc9204cb53eda8ec5371abe0431c [INFO] checking Gregory-Meyer/crudis/9ab13f33da1ecc9204cb53eda8ec5371abe0431c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGregory-Meyer%2Fcrudis" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Gregory-Meyer/crudis on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Gregory-Meyer/crudis [INFO] finished tweaking git repo https://github.com/Gregory-Meyer/crudis [INFO] tweaked toml for git repo https://github.com/Gregory-Meyer/crudis written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Gregory-Meyer/crudis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f63ce944640c45cf2bc5554adfb7ebbe02785877f8561d0ba99723f6c6dc6c7 [INFO] running `Command { std: "docker" "start" "-a" "1f63ce944640c45cf2bc5554adfb7ebbe02785877f8561d0ba99723f6c6dc6c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f63ce944640c45cf2bc5554adfb7ebbe02785877f8561d0ba99723f6c6dc6c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f63ce944640c45cf2bc5554adfb7ebbe02785877f8561d0ba99723f6c6dc6c7", kill_on_drop: false }` [INFO] [stdout] 1f63ce944640c45cf2bc5554adfb7ebbe02785877f8561d0ba99723f6c6dc6c7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f118980a8b614d5fadd2fd7feb5fb5ade5bc41b7091aa1ee1058ab11a18850f8 [INFO] running `Command { std: "docker" "start" "-a" "f118980a8b614d5fadd2fd7feb5fb5ade5bc41b7091aa1ee1058ab11a18850f8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.53 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking futures v0.1.26 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking smallvec v0.6.9 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling cc v1.0.36 [INFO] [stderr] Compiling fs_extra v1.1.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.3 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking tokio-trace-core v0.1.0 [INFO] [stderr] Checking hashbrown v0.3.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling jemalloc-sys v0.3.0 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-executor v0.1.7 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking tokio-sync v0.1.5 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking tokio-timer v0.2.10 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-threadpool v0.1.14 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking tokio-reactor v0.1.9 [INFO] [stderr] Checking tokio-fs v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio v0.1.19 [INFO] [stderr] Checking jemallocator v0.3.0 [INFO] [stderr] Checking crudis v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variants `Set` and `Hash` are never constructed [INFO] [stdout] --> src/database.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub enum Value { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 36 | Set(HashSet), [INFO] [stdout] | ^^^ [INFO] [stdout] 37 | Hash(HashMap), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 67 | let db = Database::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | .for_each(move |sock| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let (writer, reader) = Framed::new(sock, RespCodec::new()).split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | [INFO] [stdout] 75 | let db = db.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | tokio::spawn( [INFO] [stdout] 77 | / reader [INFO] [stdout] 78 | | .map(move |msg| make_response(&db, &msg)) [INFO] [stdout] 79 | | .forward(writer) [INFO] [stdout] 80 | | .map(|_| ()) [INFO] [stdout] 81 | | .map_err(|e| eprintln!("couldn't write response: {}", e)), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 43 | fn new(value: Value) -> Arc> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Arc::new(RwLock::new((value, None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:556:26 [INFO] [stdout] | [INFO] [stdout] 556 | .map(|k| map.remove(k.as_ref()).is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Set` and `Hash` are never constructed [INFO] [stdout] --> src/database.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub enum Value { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 36 | Set(HashSet), [INFO] [stdout] | ^^^ [INFO] [stdout] 37 | Hash(HashMap), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 67 | let db = Database::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | .for_each(move |sock| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let (writer, reader) = Framed::new(sock, RespCodec::new()).split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | [INFO] [stdout] 75 | let db = db.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | tokio::spawn( [INFO] [stdout] 77 | / reader [INFO] [stdout] 78 | | .map(move |msg| make_response(&db, &msg)) [INFO] [stdout] 79 | | .forward(writer) [INFO] [stdout] 80 | | .map(|_| ()) [INFO] [stdout] 81 | | .map_err(|e| eprintln!("couldn't write response: {}", e)), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 43 | fn new(value: Value) -> Arc> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Arc::new(RwLock::new((value, None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:556:26 [INFO] [stdout] | [INFO] [stdout] 556 | .map(|k| map.remove(k.as_ref()).is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crudis` (bin "crudis") due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crudis` (bin "crudis" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f118980a8b614d5fadd2fd7feb5fb5ade5bc41b7091aa1ee1058ab11a18850f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f118980a8b614d5fadd2fd7feb5fb5ade5bc41b7091aa1ee1058ab11a18850f8", kill_on_drop: false }` [INFO] [stdout] f118980a8b614d5fadd2fd7feb5fb5ade5bc41b7091aa1ee1058ab11a18850f8