[INFO] cloning repository https://github.com/GreatKet/tri-buffer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GreatKet/tri-buffer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGreatKet%2Ftri-buffer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGreatKet%2Ftri-buffer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b0db5c587921244e1989e02f9c746796b9805b1e [INFO] checking GreatKet/tri-buffer/b0db5c587921244e1989e02f9c746796b9805b1e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGreatKet%2Ftri-buffer" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/GreatKet/tri-buffer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/GreatKet/tri-buffer [INFO] finished tweaking git repo https://github.com/GreatKet/tri-buffer [INFO] tweaked toml for git repo https://github.com/GreatKet/tri-buffer written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/GreatKet/tri-buffer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0e04533dc856dc97da6eba286e661f56ef107680a0e05aa91f308c12dbc79e3 [INFO] running `Command { std: "docker" "start" "-a" "f0e04533dc856dc97da6eba286e661f56ef107680a0e05aa91f308c12dbc79e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0e04533dc856dc97da6eba286e661f56ef107680a0e05aa91f308c12dbc79e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0e04533dc856dc97da6eba286e661f56ef107680a0e05aa91f308c12dbc79e3", kill_on_drop: false }` [INFO] [stdout] f0e04533dc856dc97da6eba286e661f56ef107680a0e05aa91f308c12dbc79e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10724cbf98a84c4c2c322501fc6cc481f2dae6aff3a66834765c24dbb2929ba8 [INFO] running `Command { std: "docker" "start" "-a" "10724cbf98a84c4c2c322501fc6cc481f2dae6aff3a66834765c24dbb2929ba8", kill_on_drop: false }` [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking tri-buffer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ptr::addr_of` [INFO] [stdout] --> src/lib.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | use std::ptr::addr_of; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::Thread` [INFO] [stdout] --> src/lib.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | use std::thread::Thread; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(generator: impl Fn() -> T) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::new_const(generator(), generator(), generator()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:38 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(generator: impl Fn() -> T) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::new_const(generator(), generator(), generator()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:51 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(generator: impl Fn() -> T) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::new_const(generator(), generator(), generator()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:22 [INFO] [stdout] | [INFO] [stdout] 114 | pub const fn new_const(s1: T, s2: T, s3: T) -> Self { [INFO] [stdout] | ----- ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Self { [INFO] [stdout] 116 | buffers: [ [INFO] [stdout] | ______________________^ [INFO] [stdout] 117 | | UnsafeCell::new(s1), [INFO] [stdout] 118 | | UnsafeCell::new(s2), [INFO] [stdout] 119 | | UnsafeCell::new(s3), [INFO] [stdout] 120 | | ], [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tri-buffer` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `evil_goose_1` [INFO] [stdout] --> src/lib.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | let evil_goose_1 = goose_reader.read(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_evil_goose_1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `evil_goose_2` [INFO] [stdout] --> src/lib.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 196 | let evil_goose_2 = goose_reader.read(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_evil_goose_2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `goose_reader` [INFO] [stdout] --> src/lib.rs:238:17 [INFO] [stdout] | [INFO] [stdout] 238 | let mut goose_reader = goose_buffer.get_reader(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_goose_reader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `evil_reader` [INFO] [stdout] --> src/lib.rs:239:17 [INFO] [stdout] | [INFO] [stdout] 239 | let mut evil_reader = goose_buffer.get_reader(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_evil_reader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:238:13 [INFO] [stdout] | [INFO] [stdout] 238 | let mut goose_reader = goose_buffer.get_reader(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:239:13 [INFO] [stdout] | [INFO] [stdout] 239 | let mut evil_reader = goose_buffer.get_reader(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `goose_reader` [INFO] [stdout] --> src/lib.rs:250:21 [INFO] [stdout] | [INFO] [stdout] 250 | let mut goose_reader = goose_buffer.get_reader(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_goose_reader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `evil_reader` [INFO] [stdout] --> src/lib.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | let mut evil_reader = goose_buffer.get_reader(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_evil_reader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:250:17 [INFO] [stdout] | [INFO] [stdout] 250 | let mut goose_reader = goose_buffer.get_reader(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | let mut evil_reader = goose_buffer.get_reader(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `evil_goose_1` [INFO] [stdout] --> src/lib.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 308 | let evil_goose_1 = goose_reader.read(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_evil_goose_1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `evil_goose_2` [INFO] [stdout] --> src/lib.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 309 | let evil_goose_2 = goose_reader.read(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_evil_goose_2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(generator: impl Fn() -> T) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::new_const(generator(), generator(), generator()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:38 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(generator: impl Fn() -> T) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::new_const(generator(), generator(), generator()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:51 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(generator: impl Fn() -> T) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::new_const(generator(), generator(), generator()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:22 [INFO] [stdout] | [INFO] [stdout] 114 | pub const fn new_const(s1: T, s2: T, s3: T) -> Self { [INFO] [stdout] | ----- ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Self { [INFO] [stdout] 116 | buffers: [ [INFO] [stdout] | ______________________^ [INFO] [stdout] 117 | | UnsafeCell::new(s1), [INFO] [stdout] 118 | | UnsafeCell::new(s2), [INFO] [stdout] 119 | | UnsafeCell::new(s3), [INFO] [stdout] 120 | | ], [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `goose_buffer` should have an upper case name [INFO] [stdout] --> src/lib.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | static goose_buffer: TripleBuffer = TripleBuffer::::new_const( [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `GOOSE_BUFFER` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `goose_buffer` should have an upper case name [INFO] [stdout] --> src/lib.rs:207:16 [INFO] [stdout] | [INFO] [stdout] 207 | static goose_buffer: TripleBuffer = TripleBuffer::::new_const( [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `GOOSE_BUFFER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `goose_buffer` should have an upper case name [INFO] [stdout] --> src/lib.rs:233:16 [INFO] [stdout] | [INFO] [stdout] 233 | static goose_buffer: TripleBuffer = TripleBuffer::::new_const( [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `GOOSE_BUFFER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `goose_buffer` should have an upper case name [INFO] [stdout] --> src/lib.rs:244:16 [INFO] [stdout] | [INFO] [stdout] 244 | static goose_buffer: TripleBuffer = TripleBuffer::::new_const( [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `GOOSE_BUFFER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `goose_buffer` should have an upper case name [INFO] [stdout] --> src/lib.rs:273:16 [INFO] [stdout] | [INFO] [stdout] 273 | static goose_buffer: TripleBuffer = [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `GOOSE_BUFFER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tri-buffer` (lib test) due to 5 previous errors; 19 warnings emitted [INFO] running `Command { std: "docker" "inspect" "10724cbf98a84c4c2c322501fc6cc481f2dae6aff3a66834765c24dbb2929ba8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10724cbf98a84c4c2c322501fc6cc481f2dae6aff3a66834765c24dbb2929ba8", kill_on_drop: false }` [INFO] [stdout] 10724cbf98a84c4c2c322501fc6cc481f2dae6aff3a66834765c24dbb2929ba8