[INFO] cloning repository https://github.com/Greast/Saver [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Greast/Saver" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGreast%2FSaver", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGreast%2FSaver'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 987e14e83988018f95ca4523b6e2b6da491f827b [INFO] checking Greast/Saver/987e14e83988018f95ca4523b6e2b6da491f827b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGreast%2FSaver" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Greast/Saver on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Greast/Saver [INFO] finished tweaking git repo https://github.com/Greast/Saver [INFO] tweaked toml for git repo https://github.com/Greast/Saver written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Greast/Saver already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: target.x86_64-pc-windows-gnu.ar [INFO] [stderr] warning: unused manifest key: target.x86_64-pc-windows-gnu.linker [INFO] [stderr] warning: unused manifest key: toolchain [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f6a3aca58001d0de096fffc5ce9f5be1a2699679b023aa9f2022590a7ccd007 [INFO] running `Command { std: "docker" "start" "-a" "6f6a3aca58001d0de096fffc5ce9f5be1a2699679b023aa9f2022590a7ccd007", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f6a3aca58001d0de096fffc5ce9f5be1a2699679b023aa9f2022590a7ccd007", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f6a3aca58001d0de096fffc5ce9f5be1a2699679b023aa9f2022590a7ccd007", kill_on_drop: false }` [INFO] [stdout] 6f6a3aca58001d0de096fffc5ce9f5be1a2699679b023aa9f2022590a7ccd007 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 096655a64bb3166871be33236092f7abba3024383ce23cca1062a6ae83b2405c [INFO] running `Command { std: "docker" "start" "-a" "096655a64bb3166871be33236092f7abba3024383ce23cca1062a6ae83b2405c", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: target.x86_64-pc-windows-gnu.ar [INFO] [stderr] warning: unused manifest key: target.x86_64-pc-windows-gnu.linker [INFO] [stderr] warning: unused manifest key: toolchain [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking Saver v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 8 | fn save_files, I:Iterator, T:AsRef>(list:I, to:T){ [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let mut list:Box> = Box::new(list); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | list.for_each(move |file|{ [INFO] [stdout] | ___________________^ [INFO] [stdout] 30 | | let file = file.as_ref(); [INFO] [stdout] 31 | | let date = file.metadata().unwrap().modified().unwrap(); [INFO] [stdout] 32 | | let date_string = format!("{}", humantime::Timestamp::from(date)).replace(":","#"); [INFO] [stdout] ... | [INFO] [stdout] 44 | | ); [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | let max = to.as_ref().read_dir().ok().map(|x| [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | / x.flat_map(Result::ok) [INFO] [stdout] 12 | | .map(|x| x.path()) [INFO] [stdout] 13 | | .filter(|x| x.is_dir()) [INFO] [stdout] 14 | | .flat_map( [INFO] [stdout] ... | [INFO] [stdout] 20 | | .map(|x| humantime::parse_rfc3339(&x.as_str().replace("#",":"))) [INFO] [stdout] 21 | | .flat_map(Result::ok) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:26:54 [INFO] [stdout] | [INFO] [stdout] 26 | list = Box::new(list.filter(move |x| value < x.as_ref().metadata().unwrap().modified().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `Saver` (bin "Saver" test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 8 | fn save_files, I:Iterator, T:AsRef>(list:I, to:T){ [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let mut list:Box> = Box::new(list); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | list.for_each(move |file|{ [INFO] [stdout] | ___________________^ [INFO] [stdout] 30 | | let file = file.as_ref(); [INFO] [stdout] 31 | | let date = file.metadata().unwrap().modified().unwrap(); [INFO] [stdout] 32 | | let date_string = format!("{}", humantime::Timestamp::from(date)).replace(":","#"); [INFO] [stdout] ... | [INFO] [stdout] 44 | | ); [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | let max = to.as_ref().read_dir().ok().map(|x| [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | / x.flat_map(Result::ok) [INFO] [stdout] 12 | | .map(|x| x.path()) [INFO] [stdout] 13 | | .filter(|x| x.is_dir()) [INFO] [stdout] 14 | | .flat_map( [INFO] [stdout] ... | [INFO] [stdout] 20 | | .map(|x| humantime::parse_rfc3339(&x.as_str().replace("#",":"))) [INFO] [stdout] 21 | | .flat_map(Result::ok) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:26:54 [INFO] [stdout] | [INFO] [stdout] 26 | list = Box::new(list.filter(move |x| value < x.as_ref().metadata().unwrap().modified().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `Saver` (bin "Saver") due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "096655a64bb3166871be33236092f7abba3024383ce23cca1062a6ae83b2405c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "096655a64bb3166871be33236092f7abba3024383ce23cca1062a6ae83b2405c", kill_on_drop: false }` [INFO] [stdout] 096655a64bb3166871be33236092f7abba3024383ce23cca1062a6ae83b2405c