[INFO] cloning repository https://github.com/Gohla/pie [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Gohla/pie" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGohla%2Fpie", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGohla%2Fpie'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3fcfcc047fb719824c173b07f9a30692ee79a555 [INFO] checking Gohla/pie/3fcfcc047fb719824c173b07f9a30692ee79a555 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGohla%2Fpie" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Gohla/pie on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Gohla/pie [INFO] finished tweaking git repo https://github.com/Gohla/pie [INFO] tweaked toml for git repo https://github.com/Gohla/pie written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Gohla/pie already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: /workspace/builds/worker-5-tc2/source/Cargo.toml: the cargo feature `named-profiles` has been stabilized in the 1.57 release and is no longer necessary to be listed in the manifest [INFO] [stderr] See https://doc.rust-lang.org/nightly/cargo/reference/profiles.html#custom-profiles for more information about using this feature. [INFO] [stderr] warning: /workspace/builds/worker-5-tc2/source/Cargo.toml: the cargo feature `profile-overrides` has been stabilized in the 1.41 release and is no longer necessary to be listed in the manifest [INFO] [stderr] See https://doc.rust-lang.org/nightly/cargo/reference/profiles.html#overrides for more information about using this feature. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c30a96e74cd3fbb25dc56fc1d3f51a8a87dba63490b617633b36f529d5fb1607 [INFO] running `Command { std: "docker" "start" "-a" "c30a96e74cd3fbb25dc56fc1d3f51a8a87dba63490b617633b36f529d5fb1607", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c30a96e74cd3fbb25dc56fc1d3f51a8a87dba63490b617633b36f529d5fb1607", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c30a96e74cd3fbb25dc56fc1d3f51a8a87dba63490b617633b36f529d5fb1607", kill_on_drop: false }` [INFO] [stdout] c30a96e74cd3fbb25dc56fc1d3f51a8a87dba63490b617633b36f529d5fb1607 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f59356e0c8b102652bed38ac58f5401282dfa39bd6546e9dbdf9912daa710520 [INFO] running `Command { std: "docker" "start" "-a" "f59356e0c8b102652bed38ac58f5401282dfa39bd6546e9dbdf9912daa710520", kill_on_drop: false }` [INFO] [stderr] warning: /opt/rustwide/workdir/Cargo.toml: the cargo feature `named-profiles` has been stabilized in the 1.57 release and is no longer necessary to be listed in the manifest [INFO] [stderr] See https://doc.rust-lang.org/nightly/cargo/reference/profiles.html#custom-profiles for more information about using this feature. [INFO] [stderr] warning: /opt/rustwide/workdir/Cargo.toml: the cargo feature `profile-overrides` has been stabilized in the 1.41 release and is no longer necessary to be listed in the manifest [INFO] [stderr] See https://doc.rust-lang.org/nightly/cargo/reference/profiles.html#overrides for more information about using this feature. [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking dyn-clone v1.0.16 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking testresult v0.3.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking dev_util v0.1.0 (/opt/rustwide/workdir/dev_util) [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking pie_graph v0.0.1 (/opt/rustwide/workdir/graph) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 153 | fn new(topo_order: TopoOrder, data: N) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | parents: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 153 | fn new(topo_order: TopoOrder, data: N) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | children: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:825:8 [INFO] [stdout] | [INFO] [stdout] 813 | node: impl Borrow, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 823 | let visited = HashSet::<_, H>::default(); // OPTO: reuse allocation [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 824 | [INFO] [stdout] 825 | Ok(DescendantsUnsorted { [INFO] [stdout] | ________^ [INFO] [stdout] 826 | | dag: self, [INFO] [stdout] 827 | | stack, [INFO] [stdout] 828 | | visited, [INFO] [stdout] 829 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:880:8 [INFO] [stdout] | [INFO] [stdout] 860 | pub fn descendants(&self, node: impl Borrow) -> Result, Error> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 878 | let visited = HashSet::<_, H>::default(); // OPTO: reuse allocation [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 879 | [INFO] [stdout] 880 | Ok(Descendants { [INFO] [stdout] | ________^ [INFO] [stdout] 881 | | dag: self, [INFO] [stdout] 882 | | queue, [INFO] [stdout] 883 | | visited, [INFO] [stdout] 884 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pie_graph` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 153 | fn new(topo_order: TopoOrder, data: N) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | parents: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 153 | fn new(topo_order: TopoOrder, data: N) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | children: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:825:8 [INFO] [stdout] | [INFO] [stdout] 813 | node: impl Borrow, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 823 | let visited = HashSet::<_, H>::default(); // OPTO: reuse allocation [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 824 | [INFO] [stdout] 825 | Ok(DescendantsUnsorted { [INFO] [stdout] | ________^ [INFO] [stdout] 826 | | dag: self, [INFO] [stdout] 827 | | stack, [INFO] [stdout] 828 | | visited, [INFO] [stdout] 829 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:880:8 [INFO] [stdout] | [INFO] [stdout] 860 | pub fn descendants(&self, node: impl Borrow) -> Result, Error> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 878 | let visited = HashSet::<_, H>::default(); // OPTO: reuse allocation [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 879 | [INFO] [stdout] 880 | Ok(Descendants { [INFO] [stdout] | ________^ [INFO] [stdout] 881 | | dag: self, [INFO] [stdout] 882 | | queue, [INFO] [stdout] 883 | | visited, [INFO] [stdout] 884 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:1184:8 [INFO] [stdout] | [INFO] [stdout] 1159 | let mut dag = DAG::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1184 | Ok(([dog, cat, mouse, lion, human, gazelle, grass], dag)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> graph/src/lib.rs:1270:29 [INFO] [stdout] | [INFO] [stdout] 1262 | let ([.., lion, _, _, _], dag) = get_basic_dag().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1263 | [INFO] [stdout] 1264 | let topo_orders: HashSet<_> = dag [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1270 | assert_eq!(topo_orders, (2..=7).collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pie_graph` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "f59356e0c8b102652bed38ac58f5401282dfa39bd6546e9dbdf9912daa710520", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f59356e0c8b102652bed38ac58f5401282dfa39bd6546e9dbdf9912daa710520", kill_on_drop: false }` [INFO] [stdout] f59356e0c8b102652bed38ac58f5401282dfa39bd6546e9dbdf9912daa710520