[INFO] cloning repository https://github.com/GlennWSo/halfedge [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GlennWSo/halfedge" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGlennWSo%2Fhalfedge", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGlennWSo%2Fhalfedge'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9f8b699b42e0acfda458ba5fec2ce19f5c4ba644 [INFO] checking GlennWSo/halfedge/9f8b699b42e0acfda458ba5fec2ce19f5c4ba644 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGlennWSo%2Fhalfedge" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/GlennWSo/halfedge on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/GlennWSo/halfedge [INFO] finished tweaking git repo https://github.com/GlennWSo/halfedge [INFO] tweaked toml for git repo https://github.com/GlennWSo/halfedge written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/GlennWSo/halfedge already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 48c0ae7e0a52e8eac2d94da8ab0ff08314da2e0bd6fbdbbe4705ddf004b2fba5 [INFO] running `Command { std: "docker" "start" "-a" "48c0ae7e0a52e8eac2d94da8ab0ff08314da2e0bd6fbdbbe4705ddf004b2fba5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "48c0ae7e0a52e8eac2d94da8ab0ff08314da2e0bd6fbdbbe4705ddf004b2fba5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48c0ae7e0a52e8eac2d94da8ab0ff08314da2e0bd6fbdbbe4705ddf004b2fba5", kill_on_drop: false }` [INFO] [stdout] 48c0ae7e0a52e8eac2d94da8ab0ff08314da2e0bd6fbdbbe4705ddf004b2fba5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 13d4ca640f9e6ff100e6147f83473b3f32c0ef164824cf8040549f2722bfb06b [INFO] running `Command { std: "docker" "start" "-a" "13d4ca640f9e6ff100e6147f83473b3f32c0ef164824cf8040549f2722bfb06b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling xml-rs v0.8.16 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling log v0.4.19 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking libloading v0.8.0 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling libm v0.2.7 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Compiling slotmap v1.0.6 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Checking ttf-parser v0.19.1 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Compiling glutin v0.30.10 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking tiny-skia-path v0.8.4 [INFO] [stderr] Checking flate2 v1.0.26 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.0 [INFO] [stderr] Compiling wayland-sys v0.30.1 [INFO] [stderr] Checking glow v0.12.3 [INFO] [stderr] Checking png v0.17.9 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Compiling glutin_egl_sys v0.5.1 [INFO] [stderr] Compiling glutin_glx_sys v0.4.0 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Checking tiny-skia v0.8.4 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking owned_ttf_parser v0.19.0 [INFO] [stderr] Checking ab_glyph v0.2.21 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Compiling winit v0.28.6 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Compiling zerocopy-derive v0.6.3 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking tokio v1.30.0 [INFO] [stderr] Checking zerocopy v0.6.3 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking three-d-asset v0.6.0 [INFO] [stderr] Checking sctk-adwaita v0.5.4 [INFO] [stderr] Checking three-d v0.16.0 [INFO] [stderr] Checking halfedge v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plot.rs:182:20 [INFO] [stdout] | [INFO] [stdout] 128 | let event_loop = builder.build(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let mut windows = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | event_loop.run(move |event, _, control_flow| match &event { [INFO] [stdout] | ____________________^ [INFO] [stdout] 183 | | winit::event::Event::MainEventsCleared => { [INFO] [stdout] 184 | | for p in windows.values() { [INFO] [stdout] 185 | | p.window.request_redraw(); [INFO] [stdout] ... | [INFO] [stdout] 234 | | _ => (), [INFO] [stdout] 235 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plot.rs:291:20 [INFO] [stdout] | [INFO] [stdout] 253 | let event_loop = builder.build(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | [INFO] [stdout] 255 | let window_builder = winit::window::WindowBuilder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | let window = window_builder.build(&event_loop).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let context = WindowedContext::from_winit_window( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let ambient = AmbientLight::new(&context, 0.7, Color::WHITE); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | let directional0 = DirectionalLight::new(&context, 2.0, Color::WHITE, &vec3(-1.0, -1.0, -1.0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let directional1 = DirectionalLight::new(&context, 2.0, Color::WHITE, &vec3(1.0, 1.0, 1.0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | [INFO] [stdout] 287 | let wf = WireFrame::new(mesh, &context); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | event_loop.run(move |event, _, control_flow| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 292 | | match &event { [INFO] [stdout] 293 | | winit::event::Event::MainEventsCleared => window.request_redraw(), [INFO] [stdout] 294 | | winit::event::Event::RedrawRequested(_) => { [INFO] [stdout] ... | [INFO] [stdout] 335 | | } [INFO] [stdout] 336 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `halfedge` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `mesh` [INFO] [stdout] --> src/mesh/tri.rs:244:13 [INFO] [stdout] | [INFO] [stdout] 244 | let mesh = Mesh::from_verts_faces(points, faces); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mesh` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `star` is never used [INFO] [stdout] --> src/mesh/tri.rs:180:8 [INFO] [stdout] | [INFO] [stdout] 180 | fn star() -> Mesh { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plot.rs:182:20 [INFO] [stdout] | [INFO] [stdout] 128 | let event_loop = builder.build(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let mut windows = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | event_loop.run(move |event, _, control_flow| match &event { [INFO] [stdout] | ____________________^ [INFO] [stdout] 183 | | winit::event::Event::MainEventsCleared => { [INFO] [stdout] 184 | | for p in windows.values() { [INFO] [stdout] 185 | | p.window.request_redraw(); [INFO] [stdout] ... | [INFO] [stdout] 234 | | _ => (), [INFO] [stdout] 235 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plot.rs:291:20 [INFO] [stdout] | [INFO] [stdout] 253 | let event_loop = builder.build(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | [INFO] [stdout] 255 | let window_builder = winit::window::WindowBuilder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | let window = window_builder.build(&event_loop).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let context = WindowedContext::from_winit_window( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let ambient = AmbientLight::new(&context, 0.7, Color::WHITE); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | let directional0 = DirectionalLight::new(&context, 2.0, Color::WHITE, &vec3(-1.0, -1.0, -1.0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let directional1 = DirectionalLight::new(&context, 2.0, Color::WHITE, &vec3(1.0, 1.0, 1.0)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | [INFO] [stdout] 287 | let wf = WireFrame::new(mesh, &context); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | event_loop.run(move |event, _, control_flow| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 292 | | match &event { [INFO] [stdout] 293 | | winit::event::Event::MainEventsCleared => window.request_redraw(), [INFO] [stdout] 294 | | winit::event::Event::RedrawRequested(_) => { [INFO] [stdout] ... | [INFO] [stdout] 335 | | } [INFO] [stdout] 336 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `halfedge` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "13d4ca640f9e6ff100e6147f83473b3f32c0ef164824cf8040549f2722bfb06b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13d4ca640f9e6ff100e6147f83473b3f32c0ef164824cf8040549f2722bfb06b", kill_on_drop: false }` [INFO] [stdout] 13d4ca640f9e6ff100e6147f83473b3f32c0ef164824cf8040549f2722bfb06b