[INFO] cloning repository https://github.com/Gisleburt/vocab [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Gisleburt/vocab" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGisleburt%2Fvocab", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGisleburt%2Fvocab'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 50a9f872eee05918ba1babaabc839e46090c584c [INFO] checking Gisleburt/vocab/50a9f872eee05918ba1babaabc839e46090c584c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGisleburt%2Fvocab" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Gisleburt/vocab on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Gisleburt/vocab [INFO] finished tweaking git repo https://github.com/Gisleburt/vocab [INFO] tweaked toml for git repo https://github.com/Gisleburt/vocab written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Gisleburt/vocab already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f75ce56a8fba3cf909a41b62fdb6cce234bcd2b2fb10b3a251143c84599bd619 [INFO] running `Command { std: "docker" "start" "-a" "f75ce56a8fba3cf909a41b62fdb6cce234bcd2b2fb10b3a251143c84599bd619", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f75ce56a8fba3cf909a41b62fdb6cce234bcd2b2fb10b3a251143c84599bd619", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f75ce56a8fba3cf909a41b62fdb6cce234bcd2b2fb10b3a251143c84599bd619", kill_on_drop: false }` [INFO] [stdout] f75ce56a8fba3cf909a41b62fdb6cce234bcd2b2fb10b3a251143c84599bd619 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db1ef3d245abd96319f110c0209e95424e33ce1a02744c516db9e51168a318fe [INFO] running `Command { std: "docker" "start" "-a" "db1ef3d245abd96319f110c0209e95424e33ce1a02744c516db9e51168a318fe", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.11 [INFO] [stderr] Compiling proc-macro-error v0.4.11 [INFO] [stderr] Compiling libsqlite3-sys v0.16.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling diesel_derives v1.4.1 [INFO] [stderr] Compiling structopt-derive v0.4.4 [INFO] [stderr] Checking structopt v0.3.11 [INFO] [stderr] Checking diesel v1.4.6 [INFO] [stderr] Checking serde v1.0.104 [INFO] [stderr] Checking bstr v0.2.11 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking vocab v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `CsvWriter` [INFO] [stdout] --> src/vocab_store.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | pub use crate::porter::{CsvWriter, ExporterError}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `CsvWriter` [INFO] [stdout] --> src/vocab_store.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | pub use crate::porter::{CsvWriter, ExporterError}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/porter/csv_io.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new(source: R) -> CsvReader { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | CsvReader { [INFO] [stdout] 51 | reader: Reader::from_reader(source), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/porter/csv_io.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | .map(|res| res.map(|rec| rec.into()).map_err(|e| e.into())) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/porter/csv_io.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn new(destination: W) -> CsvWriter { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | CsvWriter { [INFO] [stdout] 74 | writer: Writer::from_writer(destination), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vocab_store` [INFO] [stdout] --> src/vocab_store/entires.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | let vocab_store = VocabStore::init(&TEST_FILE).unwrap(); // Init DB [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_vocab_store` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vocab_store.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 86 | let connection = SqliteConnection::establish(file)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | Ok(VocabStore(connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vocab_store.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 94 | let connection = SqliteConnection::establish(file)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | diesel::sql_query(INIT).execute(&connection)?; [INFO] [stdout] 96 | Ok(VocabStore(connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vocab` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/vocab_store/translation.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | let mut old_translation = Translation::new("no", "いいえ"); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/vocab_store/translation.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | let mut new_translation = Translation::new("japan", "日本"); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/porter/csv_io.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new(source: R) -> CsvReader { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | CsvReader { [INFO] [stdout] 51 | reader: Reader::from_reader(source), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/porter/csv_io.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | .map(|res| res.map(|rec| rec.into()).map_err(|e| e.into())) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/porter/csv_io.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn new(destination: W) -> CsvWriter { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | CsvWriter { [INFO] [stdout] 74 | writer: Writer::from_writer(destination), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vocab_store.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 86 | let connection = SqliteConnection::establish(file)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | Ok(VocabStore(connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vocab_store.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 94 | let connection = SqliteConnection::establish(file)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | diesel::sql_query(INIT).execute(&connection)?; [INFO] [stdout] 96 | Ok(VocabStore(connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vocab_store.rs:197:15 [INFO] [stdout] | [INFO] [stdout] 193 | let vocab_store = VocabStore::init(&TEST_FILE).unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | match vocab_store.add(&different_foreign) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vocab_store.rs:215:15 [INFO] [stdout] | [INFO] [stdout] 211 | let vocab_store = VocabStore::init(&TEST_FILE).unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | match vocab_store.add(&different_local) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vocab` (lib test) due to 8 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "db1ef3d245abd96319f110c0209e95424e33ce1a02744c516db9e51168a318fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db1ef3d245abd96319f110c0209e95424e33ce1a02744c516db9e51168a318fe", kill_on_drop: false }` [INFO] [stdout] db1ef3d245abd96319f110c0209e95424e33ce1a02744c516db9e51168a318fe