[INFO] updating cached repository https://github.com/Gelcorp/minecraft-launcher-core [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 50fe90ab62abda626f504618bacd2925bcf0dfd1 [INFO] checking Gelcorp/minecraft-launcher-core/50fe90ab62abda626f504618bacd2925bcf0dfd1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGelcorp%2Fminecraft-launcher-core" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Gelcorp/minecraft-launcher-core on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Gelcorp/minecraft-launcher-core [INFO] finished tweaking git repo https://github.com/Gelcorp/minecraft-launcher-core [INFO] tweaked toml for git repo https://github.com/Gelcorp/minecraft-launcher-core written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Gelcorp/minecraft-launcher-core already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e428cf177ad6876977911bac5e152ee6c6c72cfcfda87a2cda4f5e02583163f [INFO] running `Command { std: "docker" "start" "-a" "2e428cf177ad6876977911bac5e152ee6c6c72cfcfda87a2cda4f5e02583163f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e428cf177ad6876977911bac5e152ee6c6c72cfcfda87a2cda4f5e02583163f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e428cf177ad6876977911bac5e152ee6c6c72cfcfda87a2cda4f5e02583163f", kill_on_drop: false }` [INFO] [stdout] 2e428cf177ad6876977911bac5e152ee6c6c72cfcfda87a2cda4f5e02583163f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d0a45834e28335586152dd72ecdb4facda8734756ca4440d520ea98ff8265ac [INFO] running `Command { std: "docker" "start" "-a" "9d0a45834e28335586152dd72ecdb4facda8734756ca4440d520ea98ff8265ac", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling cc v1.1.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling zstd-safe v7.2.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Compiling zip v2.1.3 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking deflate64 v0.1.8 [INFO] [stderr] Checking dary_heap v0.3.6 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking libflate_lz77 v2.1.0 [INFO] [stderr] Checking libflate v2.1.0 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking simple_logger v5.0.0 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling derive_builder_core v0.20.0 [INFO] [stderr] Compiling derive_builder_macro v0.20.0 [INFO] [stderr] Checking derive_builder v0.20.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking os_info v3.8.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking minecraft-launcher-core v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/java_manager/error.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 52 | fn from(val: CompressedRuntimeFileError) -> Self { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | DownloadError::Other(Box::new(val)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/mod.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(game_dir: &Path, env_features: &EnvironmentFeatures, client: Option) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | client: client.unwrap_or(DownloadJob::create_http_client(None).unwrap_or_default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/mod.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(client: Option, reporter: ProgressReporter, parallel_downloads: Option, retries: Option) -> Self { [INFO] [stdout] | ---------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Self { [INFO] [stdout] 32 | client: client.unwrap_or(DownloadJob::create_http_client(None).unwrap_or_default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/mod.rs:54:75 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(serde_json::from_reader(file).map_err(|err| DownloadError::Other(Box::new(err)))?) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/mod.rs:69:78 [INFO] [stdout] | [INFO] [stdout] 69 | Ok(serde_json::from_slice(&bytes).map_err(|err| DownloadError::Other(Box::new(err)))?) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/progress/callback.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new(callback: T) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Self { callback: Box::new(callback) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/download_job.rs:122:65 [INFO] [stdout] | [INFO] [stdout] 117 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | .map(move |downloadable| (downloadable, job_name.clone(), client.clone(), retries)) [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/download_job.rs:191:29 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn new(reporter: ProgressReporter, files: &[DownloadableSync]) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Self { reporter, files: files.to_vec() } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/download_job.rs:226:14 [INFO] [stdout] | [INFO] [stdout] 225 | let monitor = self.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Arc::new(CallbackReporter::new(move |_| monitor.fire_update())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/downloadables/asset.rs:256:26 [INFO] [stdout] | [INFO] [stdout] 255 | fn from(val: CompressedAssetError) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | DownloadError::Other(Box::new(val)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/mod.rs:392:67 [INFO] [stdout] | [INFO] [stdout] 392 | if let Some(asset_index) = asset_index_info.and_then(|info| self.get_asset_index(info).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/process.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 15 | let mut child = Command::new(java_path).stdout(Stdio::piped()).stderr(Stdio::piped()).current_dir(game_dir).args(args).spawn().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self { [INFO] [stdout] 17 | stdout: BufReader::new(child.stdout.take().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/process.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 15 | let mut child = Command::new(java_path).stdout(Stdio::piped()).stderr(Stdio::piped()).current_dir(game_dir).args(args).spawn().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | stderr: BufReader::new(child.stderr.take().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/process.rs:103:8 [INFO] [stdout] | [INFO] [stdout] 103 | Ok(GameProcess::new(java_path, directory, args)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minecraft-launcher-core` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/java_manager/error.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 52 | fn from(val: CompressedRuntimeFileError) -> Self { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | DownloadError::Other(Box::new(val)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/mod.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(game_dir: &Path, env_features: &EnvironmentFeatures, client: Option) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | client: client.unwrap_or(DownloadJob::create_http_client(None).unwrap_or_default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/mod.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(client: Option, reporter: ProgressReporter, parallel_downloads: Option, retries: Option) -> Self { [INFO] [stdout] | ---------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Self { [INFO] [stdout] 32 | client: client.unwrap_or(DownloadJob::create_http_client(None).unwrap_or_default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/mod.rs:54:75 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(serde_json::from_reader(file).map_err(|err| DownloadError::Other(Box::new(err)))?) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/mod.rs:69:78 [INFO] [stdout] | [INFO] [stdout] 69 | Ok(serde_json::from_slice(&bytes).map_err(|err| DownloadError::Other(Box::new(err)))?) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/progress/callback.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new(callback: T) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Self { callback: Box::new(callback) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/download_job.rs:122:65 [INFO] [stdout] | [INFO] [stdout] 117 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | .map(move |downloadable| (downloadable, job_name.clone(), client.clone(), retries)) [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/download_job.rs:191:29 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn new(reporter: ProgressReporter, files: &[DownloadableSync]) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Self { reporter, files: files.to_vec() } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/download_job.rs:226:14 [INFO] [stdout] | [INFO] [stdout] 225 | let monitor = self.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Arc::new(CallbackReporter::new(move |_| monitor.fire_update())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/downloader/downloadables/asset.rs:256:26 [INFO] [stdout] | [INFO] [stdout] 255 | fn from(val: CompressedAssetError) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | DownloadError::Other(Box::new(val)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/mod.rs:392:67 [INFO] [stdout] | [INFO] [stdout] 392 | if let Some(asset_index) = asset_index_info.and_then(|info| self.get_asset_index(info).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/process.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 15 | let mut child = Command::new(java_path).stdout(Stdio::piped()).stderr(Stdio::piped()).current_dir(game_dir).args(args).spawn().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self { [INFO] [stdout] 17 | stdout: BufReader::new(child.stdout.take().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/process.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 15 | let mut child = Command::new(java_path).stdout(Stdio::piped()).stderr(Stdio::piped()).current_dir(game_dir).args(args).spawn().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | stderr: BufReader::new(child.stderr.take().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/process.rs:103:8 [INFO] [stdout] | [INFO] [stdout] 103 | Ok(GameProcess::new(java_path, directory, args)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 24 | let progress: Arc>> = Arc::default(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | / CallbackReporter::new(move |event| { [INFO] [stdout] 40 | | if let Ok(mut progress) = progress.lock() { [INFO] [stdout] 41 | | if let Event::Done = event { [INFO] [stdout] 42 | | progress.take(); [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] 75 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:211:20 [INFO] [stdout] | [INFO] [stdout] 205 | let result = remote.fetch(&Client::new()).await; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | (id.clone(), result.err()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minecraft-launcher-core` (lib test) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "9d0a45834e28335586152dd72ecdb4facda8734756ca4440d520ea98ff8265ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d0a45834e28335586152dd72ecdb4facda8734756ca4440d520ea98ff8265ac", kill_on_drop: false }` [INFO] [stdout] 9d0a45834e28335586152dd72ecdb4facda8734756ca4440d520ea98ff8265ac