[INFO] cloning repository https://github.com/Gelbpunkt/freeciv-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Gelbpunkt/freeciv-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGelbpunkt%2Ffreeciv-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGelbpunkt%2Ffreeciv-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 95c833f42e6c738019f35167a8789223fd87fc39 [INFO] checking Gelbpunkt/freeciv-rs/95c833f42e6c738019f35167a8789223fd87fc39 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGelbpunkt%2Ffreeciv-rs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Gelbpunkt/freeciv-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/Gelbpunkt/freeciv-rs [INFO] finished tweaking git repo https://github.com/Gelbpunkt/freeciv-rs [INFO] tweaked toml for git repo https://github.com/Gelbpunkt/freeciv-rs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Gelbpunkt/freeciv-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 90b09f38a319ae98a8e446107b02aed658e42362dc4164c12dad7c73a9cbbd8a [INFO] running `Command { std: "docker" "start" "-a" "90b09f38a319ae98a8e446107b02aed658e42362dc4164c12dad7c73a9cbbd8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "90b09f38a319ae98a8e446107b02aed658e42362dc4164c12dad7c73a9cbbd8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90b09f38a319ae98a8e446107b02aed658e42362dc4164c12dad7c73a9cbbd8a", kill_on_drop: false }` [INFO] [stdout] 90b09f38a319ae98a8e446107b02aed658e42362dc4164c12dad7c73a9cbbd8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55b8d5d9b0a7775da3deee7b59f12f6c1de621775aabbcee71db00c63c89424b [INFO] running `Command { std: "docker" "start" "-a" "55b8d5d9b0a7775da3deee7b59f12f6c1de621775aabbcee71db00c63c89424b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.141 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking bitflags v2.0.2 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Checking flate2 v1.0.25 [INFO] [stderr] Checking png v0.17.7 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking num-integer v0.1.45 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_xorshift v0.2.0 [INFO] [stderr] Checking num-rational v0.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking image v0.24.6 [INFO] [stderr] Checking noise v0.8.2 [INFO] [stderr] Checking freeciv-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `once_cell` has been stable since 1.70.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(once_cell)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `once_cell` has been stable since 1.70.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(once_cell)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `north_east` [INFO] [stdout] --> src/tiles/tile.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | north_east: Option, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_north_east` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `south_east` [INFO] [stdout] --> src/tiles/tile.rs:444:9 [INFO] [stdout] | [INFO] [stdout] 444 | south_east: Option, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_south_east` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `south_west` [INFO] [stdout] --> src/tiles/tile.rs:446:9 [INFO] [stdout] | [INFO] [stdout] 446 | south_west: Option, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_south_west` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `north_west` [INFO] [stdout] --> src/tiles/tile.rs:448:9 [INFO] [stdout] | [INFO] [stdout] 448 | north_west: Option, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_north_west` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_technology_by_idx` is never used [INFO] [stdout] --> src/research/technologies.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn get_technology_by_idx(idx: usize) -> &'static Technology { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `random` is never used [INFO] [stdout] --> src/tiles/tile.rs:635:19 [INFO] [stdout] | [INFO] [stdout] 238 | impl Terrain { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 635 | pub(crate) fn random() -> Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `railroad` is never used [INFO] [stdout] --> src/tiles/tile.rs:671:10 [INFO] [stdout] | [INFO] [stdout] 671 | const fn railroad() -> TransformOutcome { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `WorkerSkill` is never used [INFO] [stdout] --> src/tiles/tile.rs:931:10 [INFO] [stdout] | [INFO] [stdout] 931 | pub enum WorkerSkill { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/research/technology.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 48 | let mut techs = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.techs_required_recursive(&mut techs); [INFO] [stdout] 50 | techs.into_iter().map(|t| t.bulbs).sum::() + self.bulbs [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/research/technology.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 64 | let mut techs = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | techs.into_iter().map(|t| t.bulbs).sum::() + self.bulbs + other.bulbs [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `north_east` [INFO] [stdout] --> src/tiles/tile.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | north_east: Option, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_north_east` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `south_east` [INFO] [stdout] --> src/tiles/tile.rs:444:9 [INFO] [stdout] | [INFO] [stdout] 444 | south_east: Option, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_south_east` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `south_west` [INFO] [stdout] --> src/tiles/tile.rs:446:9 [INFO] [stdout] | [INFO] [stdout] 446 | south_west: Option, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_south_west` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `north_west` [INFO] [stdout] --> src/tiles/tile.rs:448:9 [INFO] [stdout] | [INFO] [stdout] 448 | north_west: Option, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_north_west` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `freeciv-rs` (bin "freeciv-rs") due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `get_technology_by_idx` is never used [INFO] [stdout] --> src/research/technologies.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn get_technology_by_idx(idx: usize) -> &'static Technology { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `random` is never used [INFO] [stdout] --> src/tiles/tile.rs:635:19 [INFO] [stdout] | [INFO] [stdout] 238 | impl Terrain { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 635 | pub(crate) fn random() -> Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `railroad` is never used [INFO] [stdout] --> src/tiles/tile.rs:671:10 [INFO] [stdout] | [INFO] [stdout] 671 | const fn railroad() -> TransformOutcome { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `WorkerSkill` is never used [INFO] [stdout] --> src/tiles/tile.rs:931:10 [INFO] [stdout] | [INFO] [stdout] 931 | pub enum WorkerSkill { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/research/technology.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 48 | let mut techs = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.techs_required_recursive(&mut techs); [INFO] [stdout] 50 | techs.into_iter().map(|t| t.bulbs).sum::() + self.bulbs [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/research/technology.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 64 | let mut techs = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | techs.into_iter().map(|t| t.bulbs).sum::() + self.bulbs + other.bulbs [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `freeciv-rs` (bin "freeciv-rs" test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "55b8d5d9b0a7775da3deee7b59f12f6c1de621775aabbcee71db00c63c89424b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55b8d5d9b0a7775da3deee7b59f12f6c1de621775aabbcee71db00c63c89424b", kill_on_drop: false }` [INFO] [stdout] 55b8d5d9b0a7775da3deee7b59f12f6c1de621775aabbcee71db00c63c89424b