[INFO] cloning repository https://github.com/GauravTalreja/path-tracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GauravTalreja/path-tracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGauravTalreja%2Fpath-tracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGauravTalreja%2Fpath-tracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 686d5ca8aac17e6e732033beb44ec60dff882147 [INFO] checking GauravTalreja/path-tracer/686d5ca8aac17e6e732033beb44ec60dff882147 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGauravTalreja%2Fpath-tracer" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/GauravTalreja/path-tracer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/GauravTalreja/path-tracer [INFO] finished tweaking git repo https://github.com/GauravTalreja/path-tracer [INFO] tweaked toml for git repo https://github.com/GauravTalreja/path-tracer written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/GauravTalreja/path-tracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 283b2b21725abde3265023778b9e69e4174b80ae9ba8f9ac7bce383770f35860 [INFO] running `Command { std: "docker" "start" "-a" "283b2b21725abde3265023778b9e69e4174b80ae9ba8f9ac7bce383770f35860", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "283b2b21725abde3265023778b9e69e4174b80ae9ba8f9ac7bce383770f35860", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "283b2b21725abde3265023778b9e69e4174b80ae9ba8f9ac7bce383770f35860", kill_on_drop: false }` [INFO] [stdout] 283b2b21725abde3265023778b9e69e4174b80ae9ba8f9ac7bce383770f35860 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c0e3bd51a146479608d629704d53910a82d6044c2480cb603307b4dfe170b8f [INFO] running `Command { std: "docker" "start" "-a" "5c0e3bd51a146479608d629704d53910a82d6044c2480cb603307b4dfe170b8f", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking simd-adler32 v0.3.5 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling built v0.7.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Checking lock_api v0.4.10 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking bitstream-io v2.2.0 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling portable-atomic v1.4.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking num-bigint v0.4.4 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking avif-serialize v0.8.1 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking glam v0.25.0 [INFO] [stderr] Checking zune-jpeg v0.4.11 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking flate2 v1.0.26 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking png v0.17.9 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking indicatif v0.17.5 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling pin-project-internal v1.1.1 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking pin-project v1.1.1 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking exr v1.6.4 [INFO] [stderr] Checking thiserror v1.0.58 [INFO] [stderr] Checking image-webp v0.1.1 [INFO] [stderr] Checking ravif v0.11.5 [INFO] [stderr] Checking image v0.25.0 [INFO] [stderr] Checking path-tracer v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scene.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 21 | let mut hittables: Vec<(Arc, BoundingBox)> = hittables [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | bvh: BvhNode::new(&mut hittables, time_min, time_max), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scene.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 23 | .map(|h| (h.clone(), h.as_ref().bounding_box(time_min, time_max))) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable/quad.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(min: Vec3A, max: Vec3A, material: Arc) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Box { [INFO] [stdout] 118 | sides: Quad::new_box(min, max, material), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable/medium.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 34 | let mut rec1 = self.boundary.hit(ray, f32::NEG_INFINITY, f32::INFINITY)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let mut rec2 = self.boundary.hit(ray, rec1.time + 0.0001, f32::INFINITY)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Some(HitResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 64 | | time: hit_time, [INFO] [stdout] 65 | | point: hit_point, [INFO] [stdout] 66 | | normal: Vec3A::new(1.0, 0.0, 0.0), [INFO] [stdout] ... | [INFO] [stdout] 69 | | v: 0.0, [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `path-tracer` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scene.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 21 | let mut hittables: Vec<(Arc, BoundingBox)> = hittables [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | bvh: BvhNode::new(&mut hittables, time_min, time_max), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scene.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 23 | .map(|h| (h.clone(), h.as_ref().bounding_box(time_min, time_max))) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable/quad.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(min: Vec3A, max: Vec3A, material: Arc) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Box { [INFO] [stdout] 118 | sides: Quad::new_box(min, max, material), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable/medium.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 34 | let mut rec1 = self.boundary.hit(ray, f32::NEG_INFINITY, f32::INFINITY)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let mut rec2 = self.boundary.hit(ray, rec1.time + 0.0001, f32::INFINITY)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Some(HitResult { [INFO] [stdout] | ______________^ [INFO] [stdout] 64 | | time: hit_time, [INFO] [stdout] 65 | | point: hit_point, [INFO] [stdout] 66 | | normal: Vec3A::new(1.0, 0.0, 0.0), [INFO] [stdout] ... | [INFO] [stdout] 69 | | v: 0.0, [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `path-tracer` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5c0e3bd51a146479608d629704d53910a82d6044c2480cb603307b4dfe170b8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c0e3bd51a146479608d629704d53910a82d6044c2480cb603307b4dfe170b8f", kill_on_drop: false }` [INFO] [stdout] 5c0e3bd51a146479608d629704d53910a82d6044c2480cb603307b4dfe170b8f