[INFO] cloning repository https://github.com/GLicDEV/invoices_as_nft [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GLicDEV/invoices_as_nft" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGLicDEV%2Finvoices_as_nft", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGLicDEV%2Finvoices_as_nft'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] adf856f66f37c838bf45598945f963e4d2bf5efb [INFO] checking GLicDEV/invoices_as_nft/adf856f66f37c838bf45598945f963e4d2bf5efb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGLicDEV%2Finvoices_as_nft" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/GLicDEV/invoices_as_nft on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/GLicDEV/invoices_as_nft [INFO] finished tweaking git repo https://github.com/GLicDEV/invoices_as_nft [INFO] tweaked toml for git repo https://github.com/GLicDEV/invoices_as_nft written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/GLicDEV/invoices_as_nft already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc8263781ca58970b51d84018fd3f7bea39e5e111b297b4947e5c233fe700ec4 [INFO] running `Command { std: "docker" "start" "-a" "cc8263781ca58970b51d84018fd3f7bea39e5e111b297b4947e5c233fe700ec4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc8263781ca58970b51d84018fd3f7bea39e5e111b297b4947e5c233fe700ec4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc8263781ca58970b51d84018fd3f7bea39e5e111b297b4947e5c233fe700ec4", kill_on_drop: false }` [INFO] [stdout] cc8263781ca58970b51d84018fd3f7bea39e5e111b297b4947e5c233fe700ec4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba6316c5e31a7e4d7f77abbc94877bd0dc92b2bce083fb32b7e551692646c765 [INFO] running `Command { std: "docker" "start" "-a" "ba6316c5e31a7e4d7f77abbc94877bd0dc92b2bce083fb32b7e551692646c765", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling regex-syntax v0.6.26 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling indexmap v1.9.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling smallvec v1.8.0 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling hashbrown v0.12.1 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling once_cell v1.12.0 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling rustversion v1.0.7 [INFO] [stderr] Compiling fixedbitset v0.4.1 [INFO] [stderr] Compiling bit-set v0.5.2 [INFO] [stderr] Compiling itertools v0.10.3 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling ena v0.14.0 [INFO] [stderr] Compiling diff v0.1.12 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling pico-args v0.4.2 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling paste v1.0.7 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling cpufeatures v0.2.2 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling parking_lot v0.12.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Compiling petgraph v0.6.2 [INFO] [stderr] Compiling string_cache v0.8.4 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Compiling typed-arena v2.0.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling termcolor v1.1.3 [INFO] [stderr] Checking base32 v0.4.0 [INFO] [stderr] Compiling unicode-width v0.1.9 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking pretty v0.10.0 [INFO] [stderr] Compiling byteorder v1.4.3 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking lalrpop-util v0.19.8 [INFO] [stderr] Compiling lalrpop v0.19.8 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Compiling candid_derive v0.4.5 [INFO] [stderr] Compiling thiserror v1.0.31 [INFO] [stderr] Compiling binread v2.2.0 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking serde_bytes v0.11.6 [INFO] [stderr] Checking ic-types v0.3.0 [INFO] [stderr] Compiling toml v0.5.9 [INFO] [stderr] Compiling serde_tokenstream v0.1.3 [INFO] [stderr] Compiling candid v0.7.14 [INFO] [stderr] Compiling proc-macro-crate v1.1.3 [INFO] [stderr] Compiling num_enum_derive v0.5.7 [INFO] [stderr] Checking num_enum v0.5.7 [INFO] [stderr] Checking ic-cdk v0.5.1 [INFO] [stderr] Checking ic-ledger-types v0.1.2 [INFO] [stderr] Compiling ic-cdk-macros v0.5.1 [INFO] [stderr] Checking simple_guestbook v0.1.0 (/opt/rustwide/workdir/src/simple_guestbook) [INFO] [stderr] Checking invoice_canister v0.1.0 (/opt/rustwide/workdir/src/invoice_canister) [INFO] [stdout] warning: unused imports: `Ref` and `str::FromStr` [INFO] [stdout] --> src/invoice_canister/src/lib.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | cell::{Ref, RefCell}, [INFO] [stdout] | ^^^ [INFO] [stdout] 17 | collections::HashMap, [INFO] [stdout] 18 | str::FromStr, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Ref` and `str::FromStr` [INFO] [stdout] --> src/invoice_canister/src/lib.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | cell::{Ref, RefCell}, [INFO] [stdout] | ^^^ [INFO] [stdout] 17 | collections::HashMap, [INFO] [stdout] 18 | str::FromStr, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MILLIS_TO_SECONDS` is never used [INFO] [stdout] --> src/invoice_canister/src/env.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const MILLIS_TO_SECONDS: u64 = 1_000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `now`, `caller`, `random_u32`, `cycles_balance`, and `memory_used` are never used [INFO] [stdout] --> src/invoice_canister/src/env.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Environment { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] 11 | fn now(&self) -> TimestampMillis; [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | fn caller(&self) -> Principal; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | fn canister_id(&self) -> Principal; [INFO] [stdout] 14 | fn random_u32(&mut self) -> u32; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 15 | fn cycles_balance(&self) -> Cycles; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 16 | fn memory_used(&self) -> u64; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(CandidType, Deserialize, Clone, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:70:48 [INFO] [stdout] | [INFO] [stdout] 70 | let req_state = RUNTIME_STATE.with(|state| state.borrow().data.requests.get(&acc_id).cloned()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:110:65 [INFO] [stdout] | [INFO] [stdout] 110 | RUNTIME_STATE.with(|state| verify_payment_impl(acc_id, &mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:131:69 [INFO] [stdout] | [INFO] [stdout] 131 | RUNTIME_STATE.with(|state| upgrade_premium_impl(principal, &mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:193:59 [INFO] [stdout] | [INFO] [stdout] 193 | RUNTIME_STATE.with(|state| upgrade_ultimate_impl(&mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lifetime.rs:17:32 [INFO] [stdout] | [INFO] [stdout] 17 | RUNTIME_STATE.with(|state| ic_cdk::storage::stable_save((&state.borrow().data,)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MILLIS_TO_SECONDS` is never used [INFO] [stdout] --> src/invoice_canister/src/env.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const MILLIS_TO_SECONDS: u64 = 1_000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `now`, `caller`, `random_u32`, `cycles_balance`, and `memory_used` are never used [INFO] [stdout] --> src/invoice_canister/src/env.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Environment { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] 11 | fn now(&self) -> TimestampMillis; [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | fn caller(&self) -> Principal; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | fn canister_id(&self) -> Principal; [INFO] [stdout] 14 | fn random_u32(&mut self) -> u32; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 15 | fn cycles_balance(&self) -> Cycles; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 16 | fn memory_used(&self) -> u64; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(CandidType, Deserialize, Clone, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:70:48 [INFO] [stdout] | [INFO] [stdout] 70 | let req_state = RUNTIME_STATE.with(|state| state.borrow().data.requests.get(&acc_id).cloned()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:110:65 [INFO] [stdout] | [INFO] [stdout] 110 | RUNTIME_STATE.with(|state| verify_payment_impl(acc_id, &mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:131:69 [INFO] [stdout] | [INFO] [stdout] 131 | RUNTIME_STATE.with(|state| upgrade_premium_impl(principal, &mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lib.rs:193:59 [INFO] [stdout] | [INFO] [stdout] 193 | RUNTIME_STATE.with(|state| upgrade_ultimate_impl(&mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/invoice_canister/src/lifetime.rs:17:32 [INFO] [stdout] | [INFO] [stdout] 17 | RUNTIME_STATE.with(|state| ic_cdk::storage::stable_save((&state.borrow().data,)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `runtime_state` [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:250:26 [INFO] [stdout] | [INFO] [stdout] 250 | fn upgrade_ultimate_impl(runtime_state: &mut RuntimeState) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_runtime_state` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `invoice_canister` (lib) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: constant `MILLIS_TO_SECONDS` is never used [INFO] [stdout] --> src/simple_guestbook/src/env.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const MILLIS_TO_SECONDS: u64 = 1_000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `now`, `canister_id`, `random_u32`, `cycles_balance`, and `memory_used` are never used [INFO] [stdout] --> src/simple_guestbook/src/env.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Environment { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] 11 | fn now(&self) -> TimestampMillis; [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | fn caller(&self) -> Principal; [INFO] [stdout] 13 | fn canister_id(&self) -> Principal; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 14 | fn random_u32(&mut self) -> u32; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 15 | fn cycles_balance(&self) -> Cycles; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 16 | fn memory_used(&self) -> u64; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 53 | #[derive(CandidType, Deserialize, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 66 | #[derive(CandidType, Deserialize, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:96:52 [INFO] [stdout] | [INFO] [stdout] 96 | RUNTIME_STATE.with(|state| add_impl(text, &mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:119:45 [INFO] [stdout] | [INFO] [stdout] 119 | RUNTIME_STATE.with(|state| get_all_impl(state.borrow())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:135:54 [INFO] [stdout] | [INFO] [stdout] 135 | RUNTIME_STATE.with(|state| get_user_details_impl(state.borrow())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:150:22 [INFO] [stdout] | [INFO] [stdout] 150 | #[derive(CandidType, Deserialize, Clone, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:160:45 [INFO] [stdout] | [INFO] [stdout] 160 | let caller = RUNTIME_STATE.with(|state| state.borrow().env.caller()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:213:45 [INFO] [stdout] | [INFO] [stdout] 213 | let caller = RUNTIME_STATE.with(|state| state.borrow().env.caller()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:237:40 [INFO] [stdout] | [INFO] [stdout] 237 | RUNTIME_STATE.with(|state| state.borrow_mut().data.upgrade_requests.insert(caller, x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:247:59 [INFO] [stdout] | [INFO] [stdout] 247 | RUNTIME_STATE.with(|state| upgrade_ultimate_impl(&mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lifetime.rs:17:32 [INFO] [stdout] | [INFO] [stdout] 17 | RUNTIME_STATE.with(|state| ic_cdk::storage::stable_save((&state.borrow().data,)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `invoice_canister` (lib test) due to 7 previous errors; 3 warnings emitted [INFO] [stdout] error: aborting due to 11 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `runtime_state` [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:250:26 [INFO] [stdout] | [INFO] [stdout] 250 | fn upgrade_ultimate_impl(runtime_state: &mut RuntimeState) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_runtime_state` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MILLIS_TO_SECONDS` is never used [INFO] [stdout] --> src/simple_guestbook/src/env.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const MILLIS_TO_SECONDS: u64 = 1_000_000_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple_guestbook` (lib test) due to 12 previous errors; 3 warnings emitted [INFO] [stdout] warning: methods `now`, `canister_id`, `random_u32`, `cycles_balance`, and `memory_used` are never used [INFO] [stdout] --> src/simple_guestbook/src/env.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Environment { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] 11 | fn now(&self) -> TimestampMillis; [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | fn caller(&self) -> Principal; [INFO] [stdout] 13 | fn canister_id(&self) -> Principal; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 14 | fn random_u32(&mut self) -> u32; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 15 | fn cycles_balance(&self) -> Cycles; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 16 | fn memory_used(&self) -> u64; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 53 | #[derive(CandidType, Deserialize, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 66 | #[derive(CandidType, Deserialize, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:96:52 [INFO] [stdout] | [INFO] [stdout] 96 | RUNTIME_STATE.with(|state| add_impl(text, &mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:119:45 [INFO] [stdout] | [INFO] [stdout] 119 | RUNTIME_STATE.with(|state| get_all_impl(state.borrow())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:135:54 [INFO] [stdout] | [INFO] [stdout] 135 | RUNTIME_STATE.with(|state| get_user_details_impl(state.borrow())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:150:22 [INFO] [stdout] | [INFO] [stdout] 150 | #[derive(CandidType, Deserialize, Clone, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:160:45 [INFO] [stdout] | [INFO] [stdout] 160 | let caller = RUNTIME_STATE.with(|state| state.borrow().env.caller()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:213:45 [INFO] [stdout] | [INFO] [stdout] 213 | let caller = RUNTIME_STATE.with(|state| state.borrow().env.caller()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:237:40 [INFO] [stdout] | [INFO] [stdout] 237 | RUNTIME_STATE.with(|state| state.borrow_mut().data.upgrade_requests.insert(caller, x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lib.rs:247:59 [INFO] [stdout] | [INFO] [stdout] 247 | RUNTIME_STATE.with(|state| upgrade_ultimate_impl(&mut state.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_guestbook/src/lifetime.rs:17:32 [INFO] [stdout] | [INFO] [stdout] 17 | RUNTIME_STATE.with(|state| ic_cdk::storage::stable_save((&state.borrow().data,)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple_guestbook` (lib) due to 12 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ba6316c5e31a7e4d7f77abbc94877bd0dc92b2bce083fb32b7e551692646c765", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba6316c5e31a7e4d7f77abbc94877bd0dc92b2bce083fb32b7e551692646c765", kill_on_drop: false }` [INFO] [stdout] ba6316c5e31a7e4d7f77abbc94877bd0dc92b2bce083fb32b7e551692646c765