[INFO] cloning repository https://github.com/FrauH0lle/dotdeploy-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FrauH0lle/dotdeploy-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFrauH0lle%2Fdotdeploy-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFrauH0lle%2Fdotdeploy-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fef5b34cd9397e158b5fe3b5d810c49c8ac207b5 [INFO] checking FrauH0lle/dotdeploy-rs/fef5b34cd9397e158b5fe3b5d810c49c8ac207b5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFrauH0lle%2Fdotdeploy-rs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/FrauH0lle/dotdeploy-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/FrauH0lle/dotdeploy-rs [INFO] finished tweaking git repo https://github.com/FrauH0lle/dotdeploy-rs [INFO] tweaked toml for git repo https://github.com/FrauH0lle/dotdeploy-rs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/FrauH0lle/dotdeploy-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 72715f1c7dc55bce22a7ef74d2183e876e15d5c1b53e9a9270e0f610f7da04d6 [INFO] running `Command { std: "docker" "start" "-a" "72715f1c7dc55bce22a7ef74d2183e876e15d5c1b53e9a9270e0f610f7da04d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "72715f1c7dc55bce22a7ef74d2183e876e15d5c1b53e9a9270e0f610f7da04d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72715f1c7dc55bce22a7ef74d2183e876e15d5c1b53e9a9270e0f610f7da04d6", kill_on_drop: false }` [INFO] [stdout] 72715f1c7dc55bce22a7ef74d2183e876e15d5c1b53e9a9270e0f610f7da04d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 078e7a1a6d0a162a1f288c90b9207c8d79946155b9cdbcdacfc07cf96eb2f17e [INFO] running `Command { std: "docker" "start" "-a" "078e7a1a6d0a162a1f288c90b9207c8d79946155b9cdbcdacfc07cf96eb2f17e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle v1.0.5 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking winnow v0.6.1 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking hashlink v0.9.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking tempfile v3.10.0 [INFO] [stderr] Checking which v6.0.0 [INFO] [stderr] Checking simplelog v0.12.1 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Compiling pest v2.7.7 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Compiling pest_meta v2.7.7 [INFO] [stderr] Compiling pest_generator v2.7.7 [INFO] [stderr] Compiling pest_derive v2.7.7 [INFO] [stderr] Checking deadpool-runtime v0.1.3 [INFO] [stderr] Checking deadpool v0.11.1 [INFO] [stderr] Checking deadpool-sync v0.1.2 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml_edit v0.22.6 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking handlebars v5.1.0 [INFO] [stderr] Checking deadpool-sqlite v0.8.0 [INFO] [stderr] Checking toml v0.8.10 [INFO] [stderr] Checking dotdeploy v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: value assigned to `install_cmd` is never read [INFO] [stdout] --> src/deploy.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | let mut install_cmd: VecDeque = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `install_cmd` is never read [INFO] [stdout] --> src/deploy.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | let mut install_cmd: VecDeque = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `install_cmd` is never read [INFO] [stdout] --> src/remove.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 95 | let mut install_cmd: VecDeque = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `install_cmd` is never read [INFO] [stdout] --> src/remove.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 95 | let mut install_cmd: VecDeque = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `MetadataExt` [INFO] [stdout] --> src/cache.rs:2:25 [INFO] [stdout] | [INFO] [stdout] 2 | use std::os::unix::fs::{MetadataExt, PermissionsExt}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileOperation` is more private than the item `ManagedFile::operation` [INFO] [stdout] --> src/phases.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | pub(crate) operation: FileOperation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `ManagedFile::operation` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `FileOperation` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/phases.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | enum FileOperation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `InvalidQueryResult` is never constructed [INFO] [stdout] --> src/cache.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub enum SQLiteError { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 44 | InvalidQueryResult, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SQLiteError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_module`, `get_file`, `get_destination_checksum`, `get_all_checksums`, `get_all_src_checksums`, and `get_all_dest_checksums` are never used [INFO] [stdout] --> src/cache.rs:429:25 [INFO] [stdout] | [INFO] [stdout] 181 | impl Store { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 429 | pub(crate) async fn get_module>( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 497 | pub(crate) async fn get_file>( [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 726 | pub(crate) async fn get_destination_checksum>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 736 | async fn get_all_checksums( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 787 | pub(crate) async fn get_all_src_checksums( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 794 | pub(crate) async fn get_all_dest_checksums( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `run` is never used [INFO] [stdout] --> src/phases.rs:43:14 [INFO] [stdout] | [INFO] [stdout] 42 | impl FileOperation { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] 43 | async fn run(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:651:23 [INFO] [stdout] | [INFO] [stdout] 648 | let mut stmt = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 651 | match stmt.query_row(params![path_str], |row| row.get::<_, String>(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:872:87 [INFO] [stdout] | [INFO] [stdout] 872 | tempfile::NamedTempFile::new().map_err(|e| SQLiteError::Other(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:993:23 [INFO] [stdout] | [INFO] [stdout] 991 | let mut stmt = conn.prepare("SELECT path FROM backups where path = $1")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 992 | [INFO] [stdout] 993 | match stmt.query_row(params![path_str], |row| row.get::<_, String>(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1076:65 [INFO] [stdout] | [INFO] [stdout] 1076 | ... .map_err(|e| SQLiteError::Other(e.into()))?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1081:65 [INFO] [stdout] | [INFO] [stdout] 1081 | ... .map_err(|e| SQLiteError::Other(e.into()))?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1094:83 [INFO] [stdout] | [INFO] [stdout] 1094 | tempfile::NamedTempFile::new().map_err(|e| SQLiteError::Other(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1107:61 [INFO] [stdout] | [INFO] [stdout] 1107 | ... .map_err(|e| SQLiteError::Other(e.into()))? [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1132:65 [INFO] [stdout] | [INFO] [stdout] 1132 | ... .map_err(|e| SQLiteError::Other(e.into()))?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1137:65 [INFO] [stdout] | [INFO] [stdout] 1137 | ... .map_err(|e| SQLiteError::Other(e.into()))?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1190:49 [INFO] [stdout] | [INFO] [stdout] 1190 | .map_err(|e| SQLiteError::Other(e.into()))? [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1235:41 [INFO] [stdout] | [INFO] [stdout] 1235 | .map_err(|e| SQLiteError::Other(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:134:30 [INFO] [stdout] | [INFO] [stdout] 134 | .map(|mut i| i.next().is_none()) [INFO] [stdout] | ----- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:233:8 [INFO] [stdout] | [INFO] [stdout] 232 | pub(crate) fn user_to_uid>(u: S) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | Ok(nix::unistd::User::from_name(u.as_ref()) [INFO] [stdout] | ________^ [INFO] [stdout] 234 | | .unwrap() [INFO] [stdout] 235 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:242:8 [INFO] [stdout] | [INFO] [stdout] 241 | pub(crate) fn group_to_gid>(u: S) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Ok(nix::unistd::Group::from_name(u.as_ref()) [INFO] [stdout] | ________^ [INFO] [stdout] 243 | | .unwrap() [INFO] [stdout] 244 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:217:36 [INFO] [stdout] | [INFO] [stdout] 217 | .unwrap_or_else(|| Self::get_distro().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:220:36 [INFO] [stdout] | [INFO] [stdout] 220 | .unwrap_or_else(|| Self::get_hostname().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deploy.rs:42:99 [INFO] [stdout] | [INFO] [stdout] 39 | let stores_clone = Arc::clone(&stores); // Clone the Arc [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let hb_clone = Arc::clone(&hb); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let context_clone = Arc::clone(&context); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | set.spawn(async move { file.perform(&stores_clone, &context_clone, &hb_clone).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate.rs:117:98 [INFO] [stdout] | [INFO] [stdout] 112 | let stores_clone = Arc::clone(&stores); // Clone the Arc [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let context_clone = Arc::clone(&context); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let hb_clone = Arc::clone(&hb); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | async move { generate_file(stores_clone, target, &config, &context_clone, &hb_clone).await }, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_module.rs:278:5 [INFO] [stdout] | [INFO] [stdout] 270 | fn deserialize_files<'de, D, T>(deserializer: D) -> Result>, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let opt_map: Option> = Option::deserialize(deserializer)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | // Run shellexpand on keys (file destinations) [INFO] [stdout] 278 | / opt_map [INFO] [stdout] 279 | | .map(|map| { [INFO] [stdout] 280 | | map.into_iter() [INFO] [stdout] 281 | | .map(|(key, value)| { [INFO] [stdout] ... | [INFO] [stdout] 286 | | .collect() [INFO] [stdout] 287 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_module.rs:280:13 [INFO] [stdout] | [INFO] [stdout] 279 | .map(|map| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | / map.into_iter() [INFO] [stdout] 281 | | .map(|(key, value)| { [INFO] [stdout] 282 | | shellexpand::full(&key) [INFO] [stdout] 283 | | .map(|expanded| (PathBuf::from(expanded.as_ref()), value)) [INFO] [stdout] 284 | | .map_err(serde::de::Error::custom) [INFO] [stdout] 285 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_module.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 281 | .map(|(key, value)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | / shellexpand::full(&key) [INFO] [stdout] 283 | | .map(|expanded| (PathBuf::from(expanded.as_ref()), value)) [INFO] [stdout] | |__________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remove.rs:130:23 [INFO] [stdout] | [INFO] [stdout] 128 | let stores_clone = Arc::clone(&stores); // Clone the Arc [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | set.spawn(async move { [INFO] [stdout] 130 | match remove_file(&file.destination, stores_clone).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dotdeploy` (bin "dotdeploy") due to 23 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: type `FileOperation` is more private than the item `ManagedFile::operation` [INFO] [stdout] --> src/phases.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | pub(crate) operation: FileOperation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `ManagedFile::operation` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `FileOperation` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/phases.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | enum FileOperation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `InvalidQueryResult` is never constructed [INFO] [stdout] --> src/cache.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub enum SQLiteError { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 44 | InvalidQueryResult, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SQLiteError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_module` is never used [INFO] [stdout] --> src/cache.rs:429:25 [INFO] [stdout] | [INFO] [stdout] 181 | impl Store { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 429 | pub(crate) async fn get_module>( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `run` is never used [INFO] [stdout] --> src/phases.rs:43:14 [INFO] [stdout] | [INFO] [stdout] 42 | impl FileOperation { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] 43 | async fn run(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:651:23 [INFO] [stdout] | [INFO] [stdout] 648 | let mut stmt = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 651 | match stmt.query_row(params![path_str], |row| row.get::<_, String>(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:872:87 [INFO] [stdout] | [INFO] [stdout] 872 | tempfile::NamedTempFile::new().map_err(|e| SQLiteError::Other(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:993:23 [INFO] [stdout] | [INFO] [stdout] 991 | let mut stmt = conn.prepare("SELECT path FROM backups where path = $1")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 992 | [INFO] [stdout] 993 | match stmt.query_row(params![path_str], |row| row.get::<_, String>(0)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1076:65 [INFO] [stdout] | [INFO] [stdout] 1076 | ... .map_err(|e| SQLiteError::Other(e.into()))?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1081:65 [INFO] [stdout] | [INFO] [stdout] 1081 | ... .map_err(|e| SQLiteError::Other(e.into()))?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1094:83 [INFO] [stdout] | [INFO] [stdout] 1094 | tempfile::NamedTempFile::new().map_err(|e| SQLiteError::Other(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1107:61 [INFO] [stdout] | [INFO] [stdout] 1107 | ... .map_err(|e| SQLiteError::Other(e.into()))? [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1132:65 [INFO] [stdout] | [INFO] [stdout] 1132 | ... .map_err(|e| SQLiteError::Other(e.into()))?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1137:65 [INFO] [stdout] | [INFO] [stdout] 1137 | ... .map_err(|e| SQLiteError::Other(e.into()))?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1190:49 [INFO] [stdout] | [INFO] [stdout] 1190 | .map_err(|e| SQLiteError::Other(e.into()))? [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1235:41 [INFO] [stdout] | [INFO] [stdout] 1235 | .map_err(|e| SQLiteError::Other(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:1249:65 [INFO] [stdout] | [INFO] [stdout] 1249 | let temp_dir = tempdir().map_err(|e| SQLiteError::Other(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:134:30 [INFO] [stdout] | [INFO] [stdout] 134 | .map(|mut i| i.next().is_none()) [INFO] [stdout] | ----- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:233:8 [INFO] [stdout] | [INFO] [stdout] 232 | pub(crate) fn user_to_uid>(u: S) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | Ok(nix::unistd::User::from_name(u.as_ref()) [INFO] [stdout] | ________^ [INFO] [stdout] 234 | | .unwrap() [INFO] [stdout] 235 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:242:8 [INFO] [stdout] | [INFO] [stdout] 241 | pub(crate) fn group_to_gid>(u: S) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Ok(nix::unistd::Group::from_name(u.as_ref()) [INFO] [stdout] | ________^ [INFO] [stdout] 243 | | .unwrap() [INFO] [stdout] 244 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:217:36 [INFO] [stdout] | [INFO] [stdout] 217 | .unwrap_or_else(|| Self::get_distro().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:220:36 [INFO] [stdout] | [INFO] [stdout] 220 | .unwrap_or_else(|| Self::get_hostname().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deploy.rs:42:99 [INFO] [stdout] | [INFO] [stdout] 39 | let stores_clone = Arc::clone(&stores); // Clone the Arc [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let hb_clone = Arc::clone(&hb); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let context_clone = Arc::clone(&context); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | set.spawn(async move { file.perform(&stores_clone, &context_clone, &hb_clone).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate.rs:117:98 [INFO] [stdout] | [INFO] [stdout] 112 | let stores_clone = Arc::clone(&stores); // Clone the Arc [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let context_clone = Arc::clone(&context); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let hb_clone = Arc::clone(&hb); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | async move { generate_file(stores_clone, target, &config, &context_clone, &hb_clone).await }, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_module.rs:278:5 [INFO] [stdout] | [INFO] [stdout] 270 | fn deserialize_files<'de, D, T>(deserializer: D) -> Result>, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let opt_map: Option> = Option::deserialize(deserializer)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | // Run shellexpand on keys (file destinations) [INFO] [stdout] 278 | / opt_map [INFO] [stdout] 279 | | .map(|map| { [INFO] [stdout] 280 | | map.into_iter() [INFO] [stdout] 281 | | .map(|(key, value)| { [INFO] [stdout] ... | [INFO] [stdout] 286 | | .collect() [INFO] [stdout] 287 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_module.rs:280:13 [INFO] [stdout] | [INFO] [stdout] 279 | .map(|map| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | / map.into_iter() [INFO] [stdout] 281 | | .map(|(key, value)| { [INFO] [stdout] 282 | | shellexpand::full(&key) [INFO] [stdout] 283 | | .map(|expanded| (PathBuf::from(expanded.as_ref()), value)) [INFO] [stdout] 284 | | .map_err(serde::de::Error::custom) [INFO] [stdout] 285 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_module.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 281 | .map(|(key, value)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | / shellexpand::full(&key) [INFO] [stdout] 283 | | .map(|expanded| (PathBuf::from(expanded.as_ref()), value)) [INFO] [stdout] | |__________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remove.rs:130:23 [INFO] [stdout] | [INFO] [stdout] 128 | let stores_clone = Arc::clone(&stores); // Clone the Arc [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | set.spawn(async move { [INFO] [stdout] 130 | match remove_file(&file.destination, stores_clone).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dotdeploy` (bin "dotdeploy" test) due to 24 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "078e7a1a6d0a162a1f288c90b9207c8d79946155b9cdbcdacfc07cf96eb2f17e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "078e7a1a6d0a162a1f288c90b9207c8d79946155b9cdbcdacfc07cf96eb2f17e", kill_on_drop: false }` [INFO] [stdout] 078e7a1a6d0a162a1f288c90b9207c8d79946155b9cdbcdacfc07cf96eb2f17e