[INFO] cloning repository https://github.com/FishingHacks/sfs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FishingHacks/sfs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFishingHacks%2Fsfs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFishingHacks%2Fsfs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d5e474156779a0d62f48bd07f0412eed9ba5f83e [INFO] checking FishingHacks/sfs/d5e474156779a0d62f48bd07f0412eed9ba5f83e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFishingHacks%2Fsfs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/FishingHacks/sfs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/FishingHacks/sfs [INFO] finished tweaking git repo https://github.com/FishingHacks/sfs [INFO] tweaked toml for git repo https://github.com/FishingHacks/sfs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/FishingHacks/sfs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 52a1ac84af5eecff3e4ecc3adcf1ccb6e79113c67d5a259977479d8d1ad45ebb [INFO] running `Command { std: "docker" "start" "-a" "52a1ac84af5eecff3e4ecc3adcf1ccb6e79113c67d5a259977479d8d1ad45ebb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "52a1ac84af5eecff3e4ecc3adcf1ccb6e79113c67d5a259977479d8d1ad45ebb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52a1ac84af5eecff3e4ecc3adcf1ccb6e79113c67d5a259977479d8d1ad45ebb", kill_on_drop: false }` [INFO] [stdout] 52a1ac84af5eecff3e4ecc3adcf1ccb6e79113c67d5a259977479d8d1ad45ebb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e405fcf818978c981264e51243f4afa74476cf47df2be723805c563daa9ce0cc [INFO] running `Command { std: "docker" "start" "-a" "e405fcf818978c981264e51243f4afa74476cf47df2be723805c563daa9ce0cc", kill_on_drop: false }` [INFO] [stderr] Checking sfs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::fs::BLOCK_SIZE` [INFO] [stdout] --> src/disk.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::fs::BLOCK_SIZE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::fs::BLOCK_SIZE` [INFO] [stdout] --> src/disk.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::fs::BLOCK_SIZE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write_empty_fs_to_file` is never used [INFO] [stdout] --> src/main.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 68 | fn write_empty_fs_to_file>(num_blocks: u32, name: &str, path: P) -> FileSystem { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 68 | fn write_empty_fs_to_file>(num_blocks: u32, name: &str, path: P) -> FileSystem { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let mut fs = FileSystem::create(num_blocks, name).expect("Failed to create empty fs"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut f = File::options() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | / FileSystem::from_disk(Disk::new(Box::new( [INFO] [stdout] 82 | | File::options() [INFO] [stdout] 83 | | .read(true) [INFO] [stdout] 84 | | .write(true) [INFO] [stdout] 85 | | .open(path) [INFO] [stdout] 86 | | .expect("Failed to read newly created file"), [INFO] [stdout] 87 | | ))) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn from_disk(mut disk: Disk) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let superblock = Superblock::read(&mut disk, 4096 /* block #1 */)?; [INFO] [stdout] 126 | Ok(Self { disk, superblock }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sfs` (bin "sfs" test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `write_empty_fs_to_file` is never used [INFO] [stdout] --> src/main.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 68 | fn write_empty_fs_to_file>(num_blocks: u32, name: &str, path: P) -> FileSystem { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 68 | fn write_empty_fs_to_file>(num_blocks: u32, name: &str, path: P) -> FileSystem { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let mut fs = FileSystem::create(num_blocks, name).expect("Failed to create empty fs"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut f = File::options() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | / FileSystem::from_disk(Disk::new(Box::new( [INFO] [stdout] 82 | | File::options() [INFO] [stdout] 83 | | .read(true) [INFO] [stdout] 84 | | .write(true) [INFO] [stdout] 85 | | .open(path) [INFO] [stdout] 86 | | .expect("Failed to read newly created file"), [INFO] [stdout] 87 | | ))) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn from_disk(mut disk: Disk) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let superblock = Superblock::read(&mut disk, 4096 /* block #1 */)?; [INFO] [stdout] 126 | Ok(Self { disk, superblock }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sfs` (bin "sfs") due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e405fcf818978c981264e51243f4afa74476cf47df2be723805c563daa9ce0cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e405fcf818978c981264e51243f4afa74476cf47df2be723805c563daa9ce0cc", kill_on_drop: false }` [INFO] [stdout] e405fcf818978c981264e51243f4afa74476cf47df2be723805c563daa9ce0cc