[INFO] cloning repository https://github.com/FinnLidbetter/lobster [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FinnLidbetter/lobster" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFinnLidbetter%2Flobster", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFinnLidbetter%2Flobster'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cb879a61bb7a07f2728123a96418619ea1fa90e2 [INFO] checking FinnLidbetter/lobster/cb879a61bb7a07f2728123a96418619ea1fa90e2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFinnLidbetter%2Flobster" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/FinnLidbetter/lobster on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/FinnLidbetter/lobster [INFO] finished tweaking git repo https://github.com/FinnLidbetter/lobster [INFO] tweaked toml for git repo https://github.com/FinnLidbetter/lobster written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/FinnLidbetter/lobster already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e77a990325f329898e3d67d63811352f1fc72fb054116c8232dc5414f900bc4 [INFO] running `Command { std: "docker" "start" "-a" "3e77a990325f329898e3d67d63811352f1fc72fb054116c8232dc5414f900bc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e77a990325f329898e3d67d63811352f1fc72fb054116c8232dc5414f900bc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e77a990325f329898e3d67d63811352f1fc72fb054116c8232dc5414f900bc4", kill_on_drop: false }` [INFO] [stdout] 3e77a990325f329898e3d67d63811352f1fc72fb054116c8232dc5414f900bc4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 710fcb526433e2111169a08bc20a1f73f7552d0796173fd21e200b80ece20408 [INFO] running `Command { std: "docker" "start" "-a" "710fcb526433e2111169a08bc20a1f73f7552d0796173fd21e200b80ece20408", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.122 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking tracing-core v0.1.24 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling httparse v1.6.0 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking ipnet v2.4.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking configparser v3.0.0 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Checking tracing v0.1.33 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking serde_with v1.12.1 [INFO] [stderr] Checking reqwest v0.11.10 [INFO] [stderr] Checking aislobsterble v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `PlayedTileSerializer` [INFO] [stdout] --> src/controller.rs:11:86 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::models::serializers::{FlatPlayedTileSerializer, GameInfo, GameSerializer, PlayedTileSerializer, TileSerializer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PlayedTileSerializer` [INFO] [stdout] --> src/controller.rs:11:86 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::models::serializers::{FlatPlayedTileSerializer, GameInfo, GameSerializer, PlayedTileSerializer, TileSerializer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tile` [INFO] [stdout] --> src/controller.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | let tile = TileSerializer{ letter: letter_for_serializer, is_blank, value }; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_tile` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tile` [INFO] [stdout] --> src/controller.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | let tile = TileSerializer{ letter: letter_for_serializer, is_blank, value }; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_tile` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/utilities.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let mut expected_permutations = [ [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_continuous` and `is_available` are never used [INFO] [stdout] --> src/models/game_models.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 108 | impl GameBoard { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 200 | pub fn is_continuous(&self, played_tiles: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 250 | pub fn is_available(&self, played_tiles: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `started` and `game_players` are never read [INFO] [stdout] --> src/models/serializers.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct GameInfo { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 10 | #[serde_as(as = "TimestampSeconds")] [INFO] [stdout] 11 | pub started: DateTime, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | pub game_players: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GameInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `score`, `player`, and `turn_order` are never read [INFO] [stdout] --> src/models/serializers.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct GamePlayerInfo { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 22 | pub score: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 23 | pub player: PlayerInfo, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 24 | pub turn_order: i32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GamePlayerInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `display_name` are never read [INFO] [stdout] --> src/models/serializers.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct PlayerInfo { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 29 | pub id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 30 | pub display_name: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlayerInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `whose_turn_name` and `num_tiles_remaining` are never read [INFO] [stdout] --> src/models/serializers.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct GameSerializer { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | pub whose_turn_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 40 | pub num_tiles_remaining: i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `score` and `num_tiles_remaining` are never read [INFO] [stdout] --> src/models/serializers.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub struct GamePlayerSerializer { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 78 | pub score: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | pub num_tiles_remaining: i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `display_name` is never read [INFO] [stdout] --> src/models/serializers.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 85 | pub struct PlayerSerializer { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 86 | pub id: i32, [INFO] [stdout] 87 | pub display_name: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `word`, `player_id`, `display_name`, and `exchanged_count` are never read [INFO] [stdout] --> src/models/serializers.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 112 | pub struct PrevMoveSerializer { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 113 | pub word: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 114 | pub score: i32, [INFO] [stdout] 115 | pub player_id: i32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 116 | pub display_name: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 117 | pub exchanged_count: i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 34 | let request = self.client.get(games_path) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | .header(AUTHORIZATION, self.get_access_auth_header()); [INFO] [stdout] 36 | let response = request.send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:58:15 [INFO] [stdout] | [INFO] [stdout] 55 | let request = self.client.get(game_path) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | .header(AUTHORIZATION, self.get_access_auth_header()); [INFO] [stdout] 57 | let response = request.send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 71 | let request = self.client.post(game_path) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let response = request.send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 106 | let response = self.client.post(auth_path).json(&map).send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:146:15 [INFO] [stdout] | [INFO] [stdout] 142 | let request = self.client [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let response = request.send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 28 | let dictionary = load_dictionary(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Controller{ client: SlobsterbleClient::new(config.clone()), config, dictionary } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&game_models::Tile` instead of cloning the inner type [INFO] [stdout] --> src/models/game_models.rs:296:85 [INFO] [stdout] | [INFO] [stdout] 296 | played_tiles.push(PlayedTile{ coordinates: position.clone(), tile: *tile.clone()}); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aislobsterble` (bin "aislobsterble" test) due to 7 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `is_continuous` and `is_available` are never used [INFO] [stdout] --> src/models/game_models.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 108 | impl GameBoard { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 200 | pub fn is_continuous(&self, played_tiles: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 250 | pub fn is_available(&self, played_tiles: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `started` and `game_players` are never read [INFO] [stdout] --> src/models/serializers.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct GameInfo { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 10 | #[serde_as(as = "TimestampSeconds")] [INFO] [stdout] 11 | pub started: DateTime, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | pub game_players: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GameInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `score`, `player`, and `turn_order` are never read [INFO] [stdout] --> src/models/serializers.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct GamePlayerInfo { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 22 | pub score: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 23 | pub player: PlayerInfo, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 24 | pub turn_order: i32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GamePlayerInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `display_name` are never read [INFO] [stdout] --> src/models/serializers.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct PlayerInfo { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 29 | pub id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 30 | pub display_name: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlayerInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `whose_turn_name` and `num_tiles_remaining` are never read [INFO] [stdout] --> src/models/serializers.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct GameSerializer { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | pub whose_turn_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 40 | pub num_tiles_remaining: i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `score` and `num_tiles_remaining` are never read [INFO] [stdout] --> src/models/serializers.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub struct GamePlayerSerializer { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 78 | pub score: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | pub num_tiles_remaining: i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `display_name` is never read [INFO] [stdout] --> src/models/serializers.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 85 | pub struct PlayerSerializer { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 86 | pub id: i32, [INFO] [stdout] 87 | pub display_name: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `word`, `player_id`, `display_name`, and `exchanged_count` are never read [INFO] [stdout] --> src/models/serializers.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 112 | pub struct PrevMoveSerializer { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 113 | pub word: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 114 | pub score: i32, [INFO] [stdout] 115 | pub player_id: i32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 116 | pub display_name: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 117 | pub exchanged_count: i32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 34 | let request = self.client.get(games_path) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | .header(AUTHORIZATION, self.get_access_auth_header()); [INFO] [stdout] 36 | let response = request.send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:58:15 [INFO] [stdout] | [INFO] [stdout] 55 | let request = self.client.get(game_path) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | .header(AUTHORIZATION, self.get_access_auth_header()); [INFO] [stdout] 57 | let response = request.send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 71 | let request = self.client.post(game_path) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let response = request.send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 106 | let response = self.client.post(auth_path).json(&map).send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slobsterble_client.rs:146:15 [INFO] [stdout] | [INFO] [stdout] 142 | let request = self.client [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let response = request.send()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | match response.error_for_status() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 28 | let dictionary = load_dictionary(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Controller{ client: SlobsterbleClient::new(config.clone()), config, dictionary } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Tile` instead of cloning the inner type [INFO] [stdout] --> src/models/game_models.rs:296:85 [INFO] [stdout] | [INFO] [stdout] 296 | played_tiles.push(PlayedTile{ coordinates: position.clone(), tile: *tile.clone()}); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aislobsterble` (bin "aislobsterble") due to 7 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "710fcb526433e2111169a08bc20a1f73f7552d0796173fd21e200b80ece20408", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "710fcb526433e2111169a08bc20a1f73f7552d0796173fd21e200b80ece20408", kill_on_drop: false }` [INFO] [stdout] 710fcb526433e2111169a08bc20a1f73f7552d0796173fd21e200b80ece20408