[INFO] cloning repository https://github.com/Fingerlingus/icoextract [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Fingerlingus/icoextract" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFingerlingus%2Ficoextract", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFingerlingus%2Ficoextract'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b5c10ad297480ee611972ae4a2cc1a9d791abc42 [INFO] checking Fingerlingus/icoextract/b5c10ad297480ee611972ae4a2cc1a9d791abc42 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFingerlingus%2Ficoextract" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Fingerlingus/icoextract on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Fingerlingus/icoextract [INFO] finished tweaking git repo https://github.com/Fingerlingus/icoextract [INFO] tweaked toml for git repo https://github.com/Fingerlingus/icoextract written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eb46b7cfe304f52ca458810933b5b0253b02b2c42b300b942835b296008ff1d1 [INFO] running `Command { std: "docker" "start" "-a" "eb46b7cfe304f52ca458810933b5b0253b02b2c42b300b942835b296008ff1d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb46b7cfe304f52ca458810933b5b0253b02b2c42b300b942835b296008ff1d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb46b7cfe304f52ca458810933b5b0253b02b2c42b300b942835b296008ff1d1", kill_on_drop: false }` [INFO] [stdout] eb46b7cfe304f52ca458810933b5b0253b02b2c42b300b942835b296008ff1d1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8418d35d5b8019b16a8a38543f67e74bc7e78f8ea9925391be180581f52403db [INFO] running `Command { std: "docker" "start" "-a" "8418d35d5b8019b16a8a38543f67e74bc7e78f8ea9925391be180581f52403db", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking utf16string v0.2.0 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking icoextract v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `virtual_size`, `relocations_offset`, `line_numbers_offset`, `num_relocations`, `num_line_numbers`, and `characteristics` are never read [INFO] [stdout] --> src/pe/nt.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 158 | pub struct SectionHeader { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 159 | pub name: String, [INFO] [stdout] 160 | pub virtual_size: usize, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 164 | pub relocations_offset: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 165 | pub line_numbers_offset: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 166 | pub num_relocations: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 167 | pub num_line_numbers: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 168 | pub characteristics: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SectionHeader` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `entry` is never read [INFO] [stdout] --> src/pe/nt.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 217 | pub struct ResourceDirectoryEntry { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] 218 | pub entry: u16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `characteristics`, `time_date_stamp`, `major_version`, and `minor_version` are never read [INFO] [stdout] --> src/pe/nt.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 306 | pub struct ResourceDirectory { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 307 | pub characteristics: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 308 | pub time_date_stamp: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 309 | pub major_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 310 | pub minor_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ResourceDirectory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:15 [INFO] [stdout] | [INFO] [stdout] 47 | let mut file = match std::fs::File::create(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | match file.write_all(&self.icon) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `icoextract` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `virtual_size`, `relocations_offset`, `line_numbers_offset`, `num_relocations`, `num_line_numbers`, and `characteristics` are never read [INFO] [stdout] --> src/pe/nt.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 158 | pub struct SectionHeader { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 159 | pub name: String, [INFO] [stdout] 160 | pub virtual_size: usize, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 164 | pub relocations_offset: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 165 | pub line_numbers_offset: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 166 | pub num_relocations: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 167 | pub num_line_numbers: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 168 | pub characteristics: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SectionHeader` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `entry` is never read [INFO] [stdout] --> src/pe/nt.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 217 | pub struct ResourceDirectoryEntry { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] 218 | pub entry: u16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `characteristics`, `time_date_stamp`, `major_version`, and `minor_version` are never read [INFO] [stdout] --> src/pe/nt.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 306 | pub struct ResourceDirectory { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 307 | pub characteristics: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 308 | pub time_date_stamp: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 309 | pub major_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 310 | pub minor_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ResourceDirectory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:15 [INFO] [stdout] | [INFO] [stdout] 47 | let mut file = match std::fs::File::create(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | match file.write_all(&self.icon) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `icoextract` (lib) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8418d35d5b8019b16a8a38543f67e74bc7e78f8ea9925391be180581f52403db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8418d35d5b8019b16a8a38543f67e74bc7e78f8ea9925391be180581f52403db", kill_on_drop: false }` [INFO] [stdout] 8418d35d5b8019b16a8a38543f67e74bc7e78f8ea9925391be180581f52403db